Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121561/?format=api
{ "id": 121561, "url": "https://patches.dpdk.org/api/patches/121561/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20230104072053.86366-4-ke1.xu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20230104072053.86366-4-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20230104072053.86366-4-ke1.xu@intel.com", "date": "2023-01-04T07:20:53", "name": "[V3,3/3] tests/vf_offload: implement packets count, super-long packet and random payload.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "35ea64d32b0a6d4da3e1c0b870995377338117a0", "submitter": { "id": 2810, "url": "https://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20230104072053.86366-4-ke1.xu@intel.com/mbox/", "series": [ { "id": 26378, "url": "https://patches.dpdk.org/api/series/26378/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=26378", "date": "2023-01-04T07:20:50", "name": "add packets count, super-long packets and random payload to the case", "version": 3, "mbox": "https://patches.dpdk.org/series/26378/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121561/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/121561/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DBB42A00C4;\n\tWed, 4 Jan 2023 08:22:36 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D83F642D21;\n\tWed, 4 Jan 2023 08:22:36 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id DB7D240697\n for <dts@dpdk.org>; Wed, 4 Jan 2023 08:22:35 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Jan 2023 23:22:35 -0800", "from dpdk-xuke-lab.sh.intel.com ([10.67.119.8])\n by fmsmga007.fm.intel.com with ESMTP; 03 Jan 2023 23:22:34 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1672816956; x=1704352956;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=19pzDMXXoontqVziMyU4/1Ke4byLxmWHoeKimB1RmFU=;\n b=Mj3kwz8S+uBZVRbKgN52XXy3CuzCV3HnZUXE9NqHjyjvB6oocHlO5ENw\n eJFU0HXGTKpHzD1VCwiUjhdKv19MMByEcXdgkZ855+V3L6k8tZtJrG2Ut\n SpU+Dp2CWEOIU8Dqy/UDEqAGhgCPNtaSfv/ZJ9rat1t4sC+FAKyCG5trR\n yXSeJrioLrI5+u8I9sycTFln2yzKGq6d5O4d/5uMOizVnVNKRErz/vlIb\n p8HM3qgE2IqRVSwx3Y/o1dLZYXJFhEjaMSZv3+KC0MuNKRTOFZr8JZatm\n iGE/dDCTpzjwcmGf/onMoGDUKdc1fBDwrZ3UodAyQcipEf7wgFGqow8D8 A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10579\"; a=\"321928109\"", "E=Sophos;i=\"5.96,299,1665471600\"; d=\"scan'208\";a=\"321928109\"", "E=McAfee;i=\"6500,9779,10579\"; a=\"657022773\"", "E=Sophos;i=\"5.96,299,1665471600\"; d=\"scan'208\";a=\"657022773\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "lijuan.tu@intel.com,\n\tyuan.peng@intel.com,\n\tke1.xu@intel.com", "Subject": "[DTS][PATCH V3 3/3] tests/vf_offload: implement packets count,\n super-long packet and random payload.", "Date": "Wed, 4 Jan 2023 15:20:53 +0800", "Message-Id": "<20230104072053.86366-4-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230104072053.86366-1-ke1.xu@intel.com>", "References": "<20230104072053.86366-1-ke1.xu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Implemented packets count that sends multiple packets of one packet combination.\n\nImplemented random payload.\n\nAdded super-long packet of payload length of 8500.\n\nSigned-off-by: Ke Xu <ke1.xu@intel.com>\n---\n tests/TestSuite_vf_offload.py | 150 ++++++++++++++++++++++++++++------\n 1 file changed, 125 insertions(+), 25 deletions(-)", "diff": "diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py\nindex 7a55c791..a212133c 100644\n--- a/tests/TestSuite_vf_offload.py\n+++ b/tests/TestSuite_vf_offload.py\n@@ -646,7 +646,17 @@ class TestVfOffload(TestCase):\n self.tester.get_local_port(self.dut_ports[1])\n )\n \n- self.loading_sizes = [128, 800, 801, 1700, 2500]\n+ # Here size_and_count is a list of tuples for the test scopes that\n+ # in a tuple (size, count) means, sending packets for count times\n+ # for TSO with a payload size of size.\n+ self.size_and_count = [\n+ (128, 10),\n+ (800, 10),\n+ (801, 10),\n+ (1700, 10),\n+ (2500, 10),\n+ (8500, 1000),\n+ ]\n \n self.tester.send_expect(\n \"ethtool -K %s rx off tx off tso off gso off gro off lro off\"\n@@ -720,13 +730,13 @@ class TestVfOffload(TestCase):\n self.tester.scapy_foreground()\n time.sleep(5)\n \n- for loading_size in self.loading_sizes:\n+ for loading_size, packet_count in self.size_and_count:\n # IPv4 tcp test\n out = self.vm0_testpmd.execute_cmd(\"clear port info all\", \"testpmd> \", 120)\n self.tcpdump_start_sniffing([tx_interface, rx_interface])\n self.tester.scapy_append(\n- 'sendp([Ether(dst=\"%s\",src=\"52:00:00:00:00:00\")/IP(src=\"192.168.1.1\",dst=\"192.168.1.2\")/TCP(sport=1021,dport=1021)/(\"X\"*%s)], iface=\"%s\")'\n- % (mac, loading_size, tx_interface)\n+ 'sendp([Ether(dst=\"%s\",src=\"52:00:00:00:00:00\")/IP(src=\"192.168.1.1\",dst=\"192.168.1.2\")/TCP(sport=1021,dport=1021)/Raw(RandString(size=%s))], iface=\"%s\", count=%s)'\n+ % (mac, loading_size, tx_interface, packet_count)\n )\n out = self.tester.scapy_execute()\n out = self.vm0_testpmd.execute_cmd(\"show port stats all\")\n@@ -738,29 +748,49 @@ class TestVfOffload(TestCase):\n self.logger.info(payload_size_list)\n if loading_size <= 800:\n self.verify(\n- rx_stats == tx_stats and int(payload_size_list[0]) == loading_size,\n+ # for all packet_count packets, verifying the packet size equals the size we sent.\n+ rx_stats == tx_stats\n+ and all(\n+ [\n+ int(payload_size_list[0]) == loading_size\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"IPV4 RX or TX packet number not correct\",\n )\n else:\n num = loading_size // 800\n for i in range(num):\n self.verify(\n- int(payload_size_list[i]) == 800,\n+ # i * packet_count + j is the i-th segmentation for j-th packet.\n+ all(\n+ [\n+ int(payload_size_list[i * packet_count + j]) == 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n if loading_size % 800 != 0:\n self.verify(\n- int(payload_size_list[num]) == loading_size % 800,\n+ # num * packet_count + j is the last segmentation for j-th packet.\n+ all(\n+ [\n+ int(payload_size_list[num * packet_count + j])\n+ == loading_size % 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n \n- for loading_size in self.loading_sizes:\n+ for loading_size, packet_count in self.size_and_count:\n # IPv6 tcp test\n out = self.vm0_testpmd.execute_cmd(\"clear port info all\", \"testpmd> \", 120)\n self.tcpdump_start_sniffing([tx_interface, rx_interface])\n self.tester.scapy_append(\n- 'sendp([Ether(dst=\"%s\", src=\"52:00:00:00:00:00\")/IPv6(src=\"FE80:0:0:0:200:1FF:FE00:200\", dst=\"3555:5555:6666:6666:7777:7777:8888:8888\")/TCP(sport=1021,dport=1021)/(\"X\"*%s)], iface=\"%s\")'\n- % (mac, loading_size, tx_interface)\n+ 'sendp([Ether(dst=\"%s\", src=\"52:00:00:00:00:00\")/IPv6(src=\"FE80:0:0:0:200:1FF:FE00:200\", dst=\"3555:5555:6666:6666:7777:7777:8888:8888\")/TCP(sport=1021,dport=1021)/Raw(RandString(size=%s))], iface=\"%s\", count=%s)'\n+ % (mac, loading_size, tx_interface, packet_count)\n )\n out = self.tester.scapy_execute()\n out = self.vm0_testpmd.execute_cmd(\"show port stats all\")\n@@ -772,19 +802,39 @@ class TestVfOffload(TestCase):\n self.logger.info(payload_size_list)\n if loading_size <= 800:\n self.verify(\n- rx_stats == tx_stats and int(payload_size_list[0]) == loading_size,\n+ # for all packet_count packets, verifying the packet size equals the size we sent.\n+ rx_stats == tx_stats\n+ and all(\n+ [\n+ int(payload_size_list[j]) == loading_size\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"IPV6 RX or TX packet number not correct\",\n )\n else:\n num = loading_size // 800\n for i in range(num):\n self.verify(\n- int(payload_size_list[i]) == 800,\n+ # i * packet_count + j is the i-th segmentation for j-th packet.\n+ all(\n+ [\n+ int(payload_size_list[i * packet_count + j]) == 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n if loading_size % 800 != 0:\n self.verify(\n- int(payload_size_list[num]) == loading_size % 800,\n+ # num * packet_count + j is the last segmentation for j-th packet.\n+ all(\n+ [\n+ int(payload_size_list[num * packet_count + j])\n+ == loading_size % 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n \n@@ -803,7 +853,17 @@ class TestVfOffload(TestCase):\n self.tester.get_local_port(self.vm0_dut_ports[1])\n )\n \n- self.loading_sizes = [128, 800, 801, 1700, 2500]\n+ # Here size_and_count is a list of tuples for the test scopes that\n+ # in a tuple (size, count) means, sending packets for count times\n+ # for TSO with a payload size of size.\n+ self.size_and_count = [\n+ (128, 10),\n+ (800, 10),\n+ (801, 10),\n+ (1700, 10),\n+ (2500, 10),\n+ (8500, 1000),\n+ ]\n \n self.tester.send_expect(\n \"ethtool -K %s rx off tx off tso off gso off gro off lro off\"\n@@ -860,7 +920,7 @@ class TestVfOffload(TestCase):\n time.sleep(5)\n \n for key_outer in pkts_outer:\n- for loading_size in self.loading_sizes:\n+ for loading_size, packet_count in self.size_and_count:\n # IPv4 tcp test\n out = self.vm0_testpmd.execute_cmd(\n \"clear port info all\", \"testpmd> \", 120\n@@ -874,9 +934,9 @@ class TestVfOffload(TestCase):\n (\n 'sendp([Ether(dst=\"%s\",src=\"52:00:00:00:00:00\")/'\n + pkts_outer[key_outer]\n- + '/IP(src=\"192.168.1.1\",dst=\"192.168.1.2\")/TCP(sport=1021,dport=1021)/(\"X\"*%s)], iface=\"%s\")'\n+ + '/IP(src=\"192.168.1.1\",dst=\"192.168.1.2\")/TCP(sport=1021,dport=1021)/Raw(RandString(size=%s))], iface=\"%s\", count = %s)'\n )\n- % (mac, loading_size, tx_interface)\n+ % (mac, loading_size, tx_interface, packet_count)\n )\n out = self.tester.scapy_execute()\n out = self.vm0_testpmd.execute_cmd(\"show port stats all\")\n@@ -888,23 +948,43 @@ class TestVfOffload(TestCase):\n self.logger.info(payload_size_list)\n if loading_size <= 800:\n self.verify(\n- rx_stats == tx_stats and payload_size_list[0] == loading_size,\n+ # for all packet_count packets, verifying the packet size equals the size we sent.\n+ rx_stats == tx_stats\n+ and all(\n+ [\n+ payload_size_list == loading_size\n+ for j in range(packet_count)\n+ ]\n+ ),\n f\"{key_outer} tunnel IPV4 RX or TX packet number not correct\",\n )\n else:\n num = loading_size // 800\n for i in range(num):\n self.verify(\n- payload_size_list[i] == 800,\n+ # i * packet_count + j is the i-th segmentation for j-th packet.\n+ all(\n+ [\n+ payload_size_list[i * packet_count + j] == 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n if loading_size % 800 != 0:\n self.verify(\n- payload_size_list[num] == loading_size % 800,\n+ # num * packet_count + j is the last segmentation for j-th packet.\n+ all(\n+ [\n+ payload_size_list[num * packet_count + j]\n+ == loading_size % 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n \n- for loading_size in self.loading_sizes:\n+ for loading_size, packet_count in self.size_and_count:\n # IPv6 tcp test\n out = self.vm0_testpmd.execute_cmd(\n \"clear port info all\", \"testpmd> \", 120\n@@ -920,7 +1000,7 @@ class TestVfOffload(TestCase):\n + pkts_outer[key_outer]\n + '/IPv6(src=\"FE80:0:0:0:200:1FF:FE00:200\", dst=\"3555:5555:6666:6666:7777:7777:8888:8888\")/TCP(sport=1021,dport=1021)/(\"X\"*%s)], iface=\"%s\")'\n )\n- % (mac, loading_size, tx_interface)\n+ % (mac, loading_size, tx_interface, packet_count)\n )\n out = self.tester.scapy_execute()\n out = self.vm0_testpmd.execute_cmd(\"show port stats all\")\n@@ -932,19 +1012,39 @@ class TestVfOffload(TestCase):\n self.logger.info(payload_size_list)\n if loading_size <= 800:\n self.verify(\n- rx_stats == tx_stats and payload_size_list[0] == loading_size,\n+ # for all packet_count packets, verifying the packet size equals the size we sent.\n+ rx_stats == tx_stats\n+ and all(\n+ [\n+ payload_size_list[j] == loading_size\n+ for j in range(packet_count)\n+ ]\n+ ),\n f\"{key_outer} tunnel IPV6 RX or TX packet number not correct\",\n )\n else:\n num = loading_size // 800\n for i in range(num):\n self.verify(\n- payload_size_list[i] == 800,\n+ # i * packet_count + j is the i-th segmentation for j-th packet.\n+ all(\n+ [\n+ payload_size_list[i * packet_count + j] == 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n if loading_size % 800 != 0:\n self.verify(\n- payload_size_list[num] == loading_size % 800,\n+ # num * packet_count + j is the last segmentation for j-th packet.\n+ all(\n+ [\n+ payload_size_list[num * packet_count + j]\n+ == loading_size % 800\n+ for j in range(packet_count)\n+ ]\n+ ),\n \"the packet segmentation incorrect, %s\" % payload_size_list,\n )\n \n", "prefixes": [ "V3", "3/3" ] }