Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120759/?format=api
{ "id": 120759, "url": "https://patches.dpdk.org/api/patches/120759/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1670829165-138835-1-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1670829165-138835-1-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1670829165-138835-1-git-send-email-andy.pei@intel.com", "date": "2022-12-12T07:12:45", "name": "vdpa/ifc: fix reconnetion issue in SW assisted live migration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9cce7f63d4fbc8e63fb5d5c610ce5805df555806", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1670829165-138835-1-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 26081, "url": "https://patches.dpdk.org/api/series/26081/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26081", "date": "2022-12-12T07:12:45", "name": "vdpa/ifc: fix reconnetion issue in SW assisted live migration", "version": 1, "mbox": "https://patches.dpdk.org/series/26081/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120759/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/120759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1B5AA034C;\n\tMon, 12 Dec 2022 09:05:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B39F640687;\n\tMon, 12 Dec 2022 09:05:51 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 4733440687;\n Mon, 12 Dec 2022 09:05:50 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2022 00:05:42 -0800", "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by orsmga001.jf.intel.com with ESMTP; 12 Dec 2022 00:05:40 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1670832350; x=1702368350;\n h=from:to:cc:subject:date:message-id;\n bh=s6UN9YqRSgAoqtrplwGaZotDQBky7YAUyaHVWcweLyE=;\n b=Cj/v07yNL/emu0fUwpyJWsx/fWEEwA7R1lcSqBQo/682+3LS8DcEPlsT\n 5D0docgO73HVrpOiw7sr/K9KW8/R40NssdSWCaBDsfDNNmA1E8+snryfz\n ytJFvm8cGdhP0jMvGOrUodqvUBT9t723ovAHTGpCtn91Df99IzEufi4UL\n IE2K3k9glwPgHNj5eY0FUVB41AV3//tPgrWIIZVY590st5CdtV2UYDUpL\n ZVmOP61ScAQR5SxBWBPuN0j1HK8Vupalx8iXfgulJvDjW/gXoxCv1HKS1\n itHRMsCsBbCbai6jv8Z4g/OcuRHuEsw9WBAduG3GFxKOdCNHUK64NVtIb A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10558\"; a=\"318937067\"", "E=Sophos;i=\"5.96,237,1665471600\"; d=\"scan'208\";a=\"318937067\"", "E=McAfee;i=\"6500,9779,10558\"; a=\"680595073\"", "E=Sophos;i=\"5.96,237,1665471600\"; d=\"scan'208\";a=\"680595073\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, xiao.w.wang@intel.com,\n stable@dpdk.org", "Subject": "[PATCH] vdpa/ifc: fix reconnetion issue in SW assisted live migration", "Date": "Mon, 12 Dec 2022 15:12:45 +0800", "Message-Id": "<1670829165-138835-1-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the case using argument \"sw-live-migration=1\" to enable SW assisted live \nmigration, we take QEMU as front end for example, after source VM migrates \nto destination VM, we keep vdpa process for source VM there, we kill the \nQEMU process for source VM, and restart the QEMU process for source VM. \nIn this case, vdpa driver will not perform DMA map and data path will not \nwork properly.\n\nThe above case works fine in the case \"sw-live-migration=0\".\n\nThe root cause is that current code driver does not set running flag to 0.\nDriver treats device as ruuning and does not perform DMA map.\n\nFixes: 4bb531e152d3 (\"net/ifc: support SW assisted VDPA live migration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 49d68ad..dc8600d 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -1044,6 +1044,8 @@ struct rte_vdpa_dev_info {\n \n \tvdpa_disable_vfio_intr(internal);\n \n+\trte_atomic32_set(&internal->running, 0);\n+\n \tret = rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, false);\n \tif (ret && ret != -ENOTSUP)\n \t\tgoto error;\n", "prefixes": [] }