Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120717/?format=api
{ "id": 120717, "url": "https://patches.dpdk.org/api/patches/120717/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221209110450.62456-8-lihuisong@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221209110450.62456-8-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221209110450.62456-8-lihuisong@huawei.com", "date": "2022-12-09T11:04:46", "name": "[V2,07/11] mem: possible data truncation and conversion error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ebc9f17cce6bf0821ebd465c22cd48ded5dcf5bb", "submitter": { "id": 2085, "url": "https://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221209110450.62456-8-lihuisong@huawei.com/mbox/", "series": [ { "id": 26064, "url": "https://patches.dpdk.org/api/series/26064/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26064", "date": "2022-12-09T11:04:39", "name": "telemetry: add u32 value type and hex integer string API", "version": 2, "mbox": "https://patches.dpdk.org/series/26064/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120717/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/120717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4139DA00C2;\n\tFri, 9 Dec 2022 12:05:46 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9E6F542D60;\n\tFri, 9 Dec 2022 12:05:00 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 05C2B42D3E\n for <dev@dpdk.org>; Fri, 9 Dec 2022 12:04:54 +0100 (CET)", "from kwepemm600004.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NT7SF2pHFzJqRW;\n Fri, 9 Dec 2022 19:03:57 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 9 Dec 2022 19:04:45 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<bruce.richardson@intel.com>, <mb@smartsharesystems.com>,\n <ciara.power@intel.com>, <liudongdong3@huawei.com>, <huangdaode@huawei.com>,\n <fengchengwen@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH V2 07/11] mem: possible data truncation and conversion error", "Date": "Fri, 9 Dec 2022 19:04:46 +0800", "Message-ID": "<20221209110450.62456-8-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20221209110450.62456-1-lihuisong@huawei.com>", "References": "<20221208080540.62913-1-lihuisong@huawei.com>\n <20221209110450.62456-1-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemm600004.china.huawei.com (7.193.23.242)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32'\ndata need to use the 'u32' telemetry API to add, and the 'u64' data need to\nuse the 'u64' telemetry API to add.\n\nFixes: e6732d0d6e26 (\"mem: add telemetry infos\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n lib/eal/common/eal_common_memory.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c\nindex 688dc615d7..b7981507da 100644\n--- a/lib/eal/common/eal_common_memory.c\n+++ b/lib/eal/common/eal_common_memory.c\n@@ -1139,7 +1139,7 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params,\n \tmalloc_heap_get_stats(heap, &sock_stats);\n \n \trte_tel_data_start_dict(d);\n-\trte_tel_data_add_dict_int(d, \"Head id\", heap_id);\n+\trte_tel_data_add_dict_u32(d, \"Head id\", heap_id);\n \trte_tel_data_add_dict_string(d, \"Name\", heap->name);\n \trte_tel_data_add_dict_u64(d, \"Heap_size\",\n \t\t\t\t sock_stats.heap_totalsz_bytes);\n@@ -1148,8 +1148,8 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params,\n \t\t\t\t sock_stats.heap_allocsz_bytes);\n \trte_tel_data_add_dict_u64(d, \"Greatest_free_size\",\n \t\t\t\t sock_stats.greatest_free_size);\n-\trte_tel_data_add_dict_u64(d, \"Alloc_count\", sock_stats.alloc_count);\n-\trte_tel_data_add_dict_u64(d, \"Free_count\", sock_stats.free_count);\n+\trte_tel_data_add_dict_u32(d, \"Alloc_count\", sock_stats.alloc_count);\n+\trte_tel_data_add_dict_u32(d, \"Free_count\", sock_stats.free_count);\n \n \treturn 0;\n }\n@@ -1201,13 +1201,13 @@ handle_eal_memzone_info_request(const char *cmd __rte_unused,\n \tmz = rte_fbarray_get(&mcfg->memzones, mz_idx);\n \n \trte_tel_data_start_dict(d);\n-\trte_tel_data_add_dict_int(d, \"Zone\", mz_idx);\n+\trte_tel_data_add_dict_u32(d, \"Zone\", mz_idx);\n \trte_tel_data_add_dict_string(d, \"Name\", mz->name);\n-\trte_tel_data_add_dict_int(d, \"Length\", mz->len);\n+\trte_tel_data_add_dict_u64(d, \"Length\", mz->len);\n \tsnprintf(addr, ADDR_STR, \"%p\", mz->addr);\n \trte_tel_data_add_dict_string(d, \"Address\", addr);\n \trte_tel_data_add_dict_int(d, \"Socket\", mz->socket_id);\n-\trte_tel_data_add_dict_int(d, \"Flags\", mz->flags);\n+\trte_tel_data_add_dict_u32(d, \"Flags\", mz->flags);\n \n \t/* go through each page occupied by this memzone */\n \tmsl = rte_mem_virt2memseg_list(mz->addr);\n@@ -1222,7 +1222,7 @@ handle_eal_memzone_info_request(const char *cmd __rte_unused,\n \tms_idx = RTE_PTR_DIFF(mz->addr, msl->base_va) / page_sz;\n \tms = rte_fbarray_get(&msl->memseg_arr, ms_idx);\n \n-\trte_tel_data_add_dict_int(d, \"Hugepage_size\", page_sz);\n+\trte_tel_data_add_dict_u64(d, \"Hugepage_size\", page_sz);\n \tsnprintf(addr, ADDR_STR, \"%p\", ms->addr);\n \trte_tel_data_add_dict_string(d, \"Hugepage_base\", addr);\n \n", "prefixes": [ "V2", "07/11" ] }