Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120412/?format=api
{ "id": 120412, "url": "https://patches.dpdk.org/api/patches/120412/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1669879940-60846-1-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1669879940-60846-1-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1669879940-60846-1-git-send-email-andy.pei@intel.com", "date": "2022-12-01T07:32:20", "name": "vdpa/ifc: fix argument compatibility check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7221a419832df48f7071de0de9cd47789d937032", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1669879940-60846-1-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 25972, "url": "https://patches.dpdk.org/api/series/25972/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25972", "date": "2022-12-01T07:32:20", "name": "vdpa/ifc: fix argument compatibility check", "version": 1, "mbox": "https://patches.dpdk.org/series/25972/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/120412/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/120412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F19B3A00C5;\n\tThu, 1 Dec 2022 09:24:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AE66F42D11;\n\tThu, 1 Dec 2022 09:24:09 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 6E6C242D0D;\n Thu, 1 Dec 2022 09:24:07 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Dec 2022 00:23:56 -0800", "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by fmsmga004.fm.intel.com with ESMTP; 01 Dec 2022 00:23:54 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1669883047; x=1701419047;\n h=from:to:cc:subject:date:message-id;\n bh=BHkpSyQMmHV+vMSQbr5L/xbEbZUOWT3B4gCeUhx6a1Y=;\n b=m4eYW1yOKtWjEl/9GakudLcKwdOKbr+808QXtypy4Aktvx4OirEW2jxa\n TjiTjf6FYdu4LSyjNlH91obxuRYhUA1VbFRnq1XTXfRvUjAw7I7JL/ffU\n S/J/SPUOSnLG3vrwv4qUr6issNGawo1+PRuoq7q5pEmMsRZ7LX6ypoRhC\n lG8hOd9gnqqPPm8l+6fVTIlkpX7DJjNrDz9Z//Q5egwizMcH/pzOVWIKY\n PgVchLulEojlDRK0tqQ6lgzR7KExlLttRCCkoooSfUQrnd26q4qh0uHuP\n nru/cLmbbzWr9FlHCvHAAb+eq4i1Mcl29xLTEUcGNFCoTv+h70yxPu5mK A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10547\"; a=\"314323277\"", "E=Sophos;i=\"5.96,207,1665471600\"; d=\"scan'208\";a=\"314323277\"", "E=McAfee;i=\"6500,9779,10547\"; a=\"713136808\"", "E=Sophos;i=\"5.96,207,1665471600\"; d=\"scan'208\";a=\"713136808\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com,\n\tmaxime.coquelin@redhat.com,\n\tstable@dpdk.org", "Subject": "[PATCH] vdpa/ifc: fix argument compatibility check", "Date": "Thu, 1 Dec 2022 15:32:20 +0800", "Message-Id": "<1669879940-60846-1-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "\"sw_fallback_lm=0\" means driver does not provide live migration assistance.\nso hardware assistance is needed to support live migration.\nHowever registers for live migration in BAR4 are not implemented.\nIn the case, we just return error after display some logs.\n\nFixes: 4c3f55cc23ea (\"net/ifc: add LM mode parameter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 49d68ad..9468f66 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -1746,6 +1746,11 @@ struct rte_vdpa_dev_info dev_info[] = {\n \t\t\tgoto error;\n \t}\n \tinternal->sw_lm = sw_fallback_lm;\n+\tif (!internal->sw_lm && !internal->hw.lm_cfg) {\n+\t\tDRV_LOG(ERR, \"Device %s does not support HW assist live migration, please enable sw-live-migration!\",\n+\t\t\tpci_dev->name);\n+\t\tgoto error;\n+\t}\n \n \tpthread_mutex_lock(&internal_list_lock);\n \tTAILQ_INSERT_TAIL(&internal_list, list, next);\n", "prefixes": [] }