Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119939/?format=api
{ "id": 119939, "url": "https://patches.dpdk.org/api/patches/119939/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221117152807.1259256-1-michaelba@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221117152807.1259256-1-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221117152807.1259256-1-michaelba@nvidia.com", "date": "2022-11-17T15:28:07", "name": "net/mlx5: fix invalid memory access in port closing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f98492bebed05b354bff18a5cf7e51b133f2d9b8", "submitter": { "id": 1949, "url": "https://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221117152807.1259256-1-michaelba@nvidia.com/mbox/", "series": [ { "id": 25806, "url": "https://patches.dpdk.org/api/series/25806/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25806", "date": "2022-11-17T15:28:07", "name": "net/mlx5: fix invalid memory access in port closing", "version": 1, "mbox": "https://patches.dpdk.org/series/25806/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119939/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119939/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 57F44A0552;\n\tThu, 17 Nov 2022 16:28:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 413CC40DDC;\n\tThu, 17 Nov 2022 16:28:31 +0100 (CET)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam02on2060.outbound.protection.outlook.com [40.107.212.60])\n by mails.dpdk.org (Postfix) with ESMTP id 83CB740DDA\n for <dev@dpdk.org>; Thu, 17 Nov 2022 16:28:29 +0100 (CET)", "from BN0PR04CA0047.namprd04.prod.outlook.com (2603:10b6:408:e8::22)\n by DM8PR12MB5496.namprd12.prod.outlook.com (2603:10b6:8:38::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov\n 2022 15:28:28 +0000", "from BN8NAM11FT096.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:e8:cafe::b3) by BN0PR04CA0047.outlook.office365.com\n (2603:10b6:408:e8::22) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend\n Transport; Thu, 17 Nov 2022 15:28:27 +0000", "from mail.nvidia.com (216.228.117.160) by\n BN8NAM11FT096.mail.protection.outlook.com (10.13.177.195) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 15:28:27 +0000", "from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 17 Nov\n 2022 07:28:13 -0800", "from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com\n (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 17 Nov\n 2022 07:28:13 -0800", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36 via Frontend\n Transport; Thu, 17 Nov 2022 07:28:11 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dl0A9SOXq2NDPno7ZCRQZnY+1C2IuDeruQl43xF2qwhQBm4QeIu9nJw/FlOBdNsr2/FDlfqO8KsywpQSewioL3DlXoro6w9z53qLRChJLBsCkwHgJOmP4JBZzyK2rIWUyK249fcxOMfR/pwPNtejylEeqQ9Ks8uadwK4hkRA7Jcu8iGBwDjBHPdQn4Kv1hrClNGdvaYaWcztxNyak+OPTp2EtX7HSRNsX12zG+cYqSyKrC00jDaCWUDeWJFo5ngBwv09d+nWl6RpSXMksnTe8EKddwM+KzP2cNaotVs921uSDR1MOBsypL1ZY5FwXf3lIayT2oqwkyxOj9Qn/BivsA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=pLgwvbN+UDpTMclXcdNq5GVNg/i4dkvQ8UxRbpWio2E=;\n b=MDqYz6IX97iXCN2Ap58fWgcKhkXJOMKUmmb5C6UQLYAjAe83F/A/8ZYFAkibzeEisbMxl4Jg6KP+LD6ax69P3I5tb6+hQrZ9qY7mKM6us4ThoJWowkqeUwAaWwTWg3F9nVILhYgUZLwGCTKFfB62vjpkfTyj0IqNWeyXAQ0bM/93ktmDCAm6O3CX97J34qxCLMUPNhGBaN/OQBpFY9s6ezhUOMY3WyEjVRfkcJQZlSfrvDpYAgw7U4MWAA90NvdG5bPLkrrkKEcsHx6ssQNbNQDtCvjfbup0FhTkQpSsIVyKzBVh6vK8KNR3RyIzs0XUnx1n7GX2HopNinc+hDqu2Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pLgwvbN+UDpTMclXcdNq5GVNg/i4dkvQ8UxRbpWio2E=;\n b=SHWJlrWDLMltSpsDCVdgPt1NT1AQz4j/l1MzGM2NHCnNYXipGGiMiwrOFst9vJbejqYuuDIfHGym8fqoqdcK7FfWTj1rNa9neglpB69BbaTLi7UeKPiEECVQOuf2esY2rkp7gMfUCnM9/5kjiXojKnfn/Xc5cGYG/kKU1U6uUKhDLZbUEYdSPAa18UVNhzQwuueha1ut6gBj7HOZe8fIoUHfsXlNKXpAwOttce0CUZZB2uaq5cxUnOpE+fj7OoAZ+We4iL8MXoV7b3Otacm9NaIZUft+g8IT+677j4n8dwBlabLWhYrHRjOIc2273qsaQPPQrIePbRLnXQjPK7snow==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <michaelba@nvidia.com>", "Subject": "[PATCH] net/mlx5: fix invalid memory access in port closing", "Date": "Thu, 17 Nov 2022 17:28:07 +0200", "Message-ID": "<20221117152807.1259256-1-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM11FT096:EE_|DM8PR12MB5496:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e22450d1-4bf7-4b3b-e35b-08dac8b05fe5", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n BmeBoh49xtNLuot5TE1WX6HXXPbFVJMLk3VRamL8hhIeTRGZ9lJs8DT/kyh1yjuFyAmJmVH1Gv7Z0+s7tMVRcKLwy83zhcXKcwrkNFlP2GZ1/idCUbmi75s+7fSn3azFRL9/TYdJZvDhvccVBXC0DtpgX00vLB3eRI4WzLFGbBCZOX++QCw6b5Mv+kTiSsdj9kwEBCeCk4XCp8TWLjlUcI6fvYmsOH5sePdtjsZ7Qjg9rElYb9eI6shEaTO1qkmphZ7wyUqNTpCSathH3VF0YrXcpDM+MsXqF7HX5ZzOW1/9i5XyclDwhUIBF1+XbVR9IjxCeQIe4CH4T/CE20qvPiui7eq64f2CrzbDH1ftbVL6DZ/Ocv9uFYRzGnsRcVCVWfJpMiHnSmDOdvczvEEIHfTmue84VxjBY+c0JhPJIFQID67u3880jcdMqpsfOWQ8lT50yG23oQcEw9KYLyLy8zv2E0jhFjcibYyjq0m/RSDLa5Ab09UXbdQDwHlrjpN2zrZxcy4WDuUPkrkHc5RC3Gvq8GiuYeCqNf0+FyojwHbFfiViekMCSdGPWFNT57JHVTEievtNwQDhSKJtRbw31GMBZraLIhwUVvfop3iNgJB17TzPoQjhh3xvPgG/Hkgyh38Rt6mXiiOyF6AoWhwgXqLMzOFca1P8UPT76MzO2EUAc+VekiKVt5JATHsLPpbhlXw4Wn1udvXsTqwTL47AgQ==", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(2906002)(36860700001)(83380400001)(55016003)(40480700001)(40460700003)(36756003)(41300700001)(70206006)(70586007)(2616005)(7636003)(82310400005)(86362001)(186003)(82740400003)(6286002)(7696005)(6916009)(54906003)(356005)(26005)(8936002)(426003)(5660300002)(336012)(4326008)(8676002)(47076005)(1076003)(316002)(107886003)(6666004)(478600001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Nov 2022 15:28:27.3016 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e22450d1-4bf7-4b3b-e35b-08dac8b05fe5", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT096.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM8PR12MB5496", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The shared IB device (sh) has per port data updated in port creation.\nIn port closing this port data is updated even when the SH still exist.\n\nHowever, this updating is happened after SH has been released and for\nlast port it actually accesses to freed memory.\n\nThis patch updates the port data before SH releasing.\n\nFixes: 13c5c093905c (\"net/mlx5: fix port event cleaning order\")\nCc: michaelba@nvidia.com\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 6a0d66247a..e55be8720e 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -2119,6 +2119,12 @@ mlx5_dev_close(struct rte_eth_dev *dev)\n \tif (priv->hrxqs)\n \t\tmlx5_list_destroy(priv->hrxqs);\n \tmlx5_free(priv->ext_rxqs);\n+\tpriv->sh->port[priv->dev_port - 1].nl_ih_port_id = RTE_MAX_ETHPORTS;\n+\t/*\n+\t * The interrupt handler port id must be reset before priv is reset\n+\t * since 'mlx5_dev_interrupt_nl_cb' uses priv.\n+\t */\n+\trte_io_wmb();\n \t/*\n \t * Free the shared context in last turn, because the cleanup\n \t * routines above may use some shared fields, like\n@@ -2144,12 +2150,6 @@ mlx5_dev_close(struct rte_eth_dev *dev)\n \t\tif (!c)\n \t\t\tclaim_zero(rte_eth_switch_domain_free(priv->domain_id));\n \t}\n-\tpriv->sh->port[priv->dev_port - 1].nl_ih_port_id = RTE_MAX_ETHPORTS;\n-\t/*\n-\t * The interrupt handler port id must be reset before priv is reset\n-\t * since 'mlx5_dev_interrupt_nl_cb' uses priv.\n-\t */\n-\trte_io_wmb();\n \tmemset(priv, 0, sizeof(*priv));\n \tpriv->domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;\n \t/*\n", "prefixes": [] }