Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119040/?format=api
{ "id": 119040, "url": "https://patches.dpdk.org/api/patches/119040/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20221018014511.106207-1-kim.tae.kyung@navercorp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221018014511.106207-1-kim.tae.kyung@navercorp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221018014511.106207-1-kim.tae.kyung@navercorp.com", "date": "2022-10-18T01:45:11", "name": "vdpa/ifc: fix update datapath error handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9116b7cb4a74a63f5650458282fec6b891ff8ff8", "submitter": { "id": 2877, "url": "https://patches.dpdk.org/api/people/2877/?format=api", "name": "Taekyung Kim", "email": "kim.tae.kyung@navercorp.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20221018014511.106207-1-kim.tae.kyung@navercorp.com/mbox/", "series": [ { "id": 25397, "url": "https://patches.dpdk.org/api/series/25397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=25397", "date": "2022-10-18T01:45:11", "name": "vdpa/ifc: fix update datapath error handling", "version": 1, "mbox": "https://patches.dpdk.org/series/25397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/119040/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/119040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 366BEA0542;\n\tMon, 24 Oct 2022 17:34:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6221642C01;\n\tMon, 24 Oct 2022 17:33:18 +0200 (CEST)", "from cvbackendsmtp001.nmdf.navercorp.com\n (cvbackendsmtp001.nmdf.navercorp.com [125.209.246.148])\n by mails.dpdk.org (Postfix) with ESMTP id 6E14F4021E\n for <dev@dpdk.org>; Tue, 18 Oct 2022 03:45:41 +0200 (CEST)", "from dev-tkkim-git-send-email-ncl.nfra.io ([10.113.149.62])\n by cvbackendsmtp001.nmdf.navercorp.com with ESMTP id e2l0O-PBS5O33tUHNjDWow\n for <multiple recipients>; Tue, 18 Oct 2022 01:45:39 -0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=navercorp.com;\n s=s20171120; t=1666057539;\n bh=03W03VsQtV0pZ55Aq6ydQ1M+1bmcwzVv4I2UzOwOv/8=;\n h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID:\n X-Works-Security;\n b=Rja4/efoNWs4bBy83gMRsOD0ADaTX4e1yL8ZUo10GLBsTVwTcpsRK1gY1AXQD50GH\n G3idROR2CHqwhgZwtxP++dzf1xKvNp5NwKbzuMThsKGZSRgCYQTooKd4dkmZ6f9bVj\n zFWAohu/W708KUKbpP4URQ2Uwn4iYdLaNaukHnXX+7YkTvlohmZvj+chmv2SBUZY7U\n aC/5PpaT+XAXGL4XyPB0lOHhxJx8w5QrlW5s+3hs1Vu2eHdmebXqlS2Sj1CgUUx73x\n 1tW7TgFeD56Z5FiuVroh2rtiAdfO114OGgvrzV9PDOhg9d72gLTA+deuMT9ROBfCFH\n lqkS0z01zY1fg==", "X-Session-ID": "e2l0O-PBS5O33tUHNjDWow", "X-Works-Smtp-Source": "9rbZKAMrFoJCpNmlKqu9WHF0", "From": "Taekyung Kim <kim.tae.kyung@navercorp.com>", "To": "dev@dpdk.org", "Cc": "Taekyung Kim <kim.tae.kyung@navercorp.com>,\n Xiao Wang <xiao.w.wang@intel.com>", "Subject": "[PATCH] vdpa/ifc: fix update datapath error handling", "Date": "Tue, 18 Oct 2022 10:45:11 +0900", "Message-Id": "<20221018014511.106207-1-kim.tae.kyung@navercorp.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 24 Oct 2022 17:33:00 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Stop and return the error code if update_datapath fails.\nupdate_datapath prepares resources for the vdpa device.\nThe driver should not perform any further actions\nif update_datapath returns an error.\n\nSigned-off-by: Taekyung Kim <kim.tae.kyung@navercorp.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 20 ++++++++++++++++----\n 1 file changed, 16 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex d5ac583589..795967e998 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -1063,7 +1063,10 @@ ifcvf_dev_config(int vid)\n \tinternal = list->internal;\n \tinternal->vid = vid;\n \trte_atomic32_set(&internal->dev_attached, 1);\n-\tupdate_datapath(internal);\n+\tif (update_datapath(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to update datapath: %p\", vdev);\n+\t\treturn -1;\n+\t}\n \n \tif (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) != 0)\n \t\tDRV_LOG(NOTICE, \"vDPA (%s): software relay is used.\",\n@@ -1105,7 +1108,10 @@ ifcvf_dev_close(int vid)\n \t\tinternal->sw_fallback_running = false;\n \t} else {\n \t\trte_atomic32_set(&internal->dev_attached, 0);\n-\t\tupdate_datapath(internal);\n+\t\tif (update_datapath(internal) < 0) {\n+\t\t\tDRV_LOG(ERR, \"failed to update datapath: %p\", vdev);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \tinternal->configured = 0;\n@@ -1632,7 +1638,10 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tpthread_mutex_unlock(&internal_list_lock);\n \n \trte_atomic32_set(&internal->started, 1);\n-\tupdate_datapath(internal);\n+\tif (update_datapath(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to update datapath: %s\", pci_dev->name);\n+\t\treturn -1;\n+\t}\n \n \trte_kvargs_free(kvlist);\n \treturn 0;\n@@ -1661,7 +1670,10 @@ ifcvf_pci_remove(struct rte_pci_device *pci_dev)\n \n \tinternal = list->internal;\n \trte_atomic32_set(&internal->started, 0);\n-\tupdate_datapath(internal);\n+\tif (update_datapath(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to update datapath: %s\", pci_dev->name);\n+\t\treturn -1;\n+\t}\n \n \trte_pci_unmap_device(internal->pdev);\n \trte_vfio_container_destroy(internal->vfio_container_fd);\n", "prefixes": [] }