Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113772/?format=api
{ "id": 113772, "url": "https://patches.dpdk.org/api/patches/113772/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220707065513.66458-1-xuan.ding@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220707065513.66458-1-xuan.ding@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220707065513.66458-1-xuan.ding@intel.com", "date": "2022-07-07T06:55:13", "name": "vhost: fix unnecessary dirty page logging", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2b1fac47c1cf57d94703a243b9f52856ffedd4ee", "submitter": { "id": 1401, "url": "https://patches.dpdk.org/api/people/1401/?format=api", "name": "Ding, Xuan", "email": "xuan.ding@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220707065513.66458-1-xuan.ding@intel.com/mbox/", "series": [ { "id": 23915, "url": "https://patches.dpdk.org/api/series/23915/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23915", "date": "2022-07-07T06:55:13", "name": "vhost: fix unnecessary dirty page logging", "version": 1, "mbox": "https://patches.dpdk.org/series/23915/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/113772/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/113772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C92A1A0540;\n\tThu, 7 Jul 2022 08:56:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B996F40A7B;\n\tThu, 7 Jul 2022 08:56:59 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 12B3D406B4\n for <dev@dpdk.org>; Thu, 7 Jul 2022 08:56:57 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2022 23:56:56 -0700", "from npg-dpdk-xuan-cbdma.sh.intel.com ([10.67.110.228])\n by fmsmga008.fm.intel.com with ESMTP; 06 Jul 2022 23:56:53 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1657177018; x=1688713018;\n h=from:to:cc:subject:date:message-id;\n bh=P13Ier8MTm/9LW2Pujrhbdyj4H2Y4IiPliOueUXGZGw=;\n b=ghvCRyK1xhXVJgYhIDa7aDO4ZAIDChKBDPcxA6uANmQzy+Ed+1usHMgV\n U1/3wJMsA2f2ACroeNzFQ09gmfiOtctlZTiDJfim/kIj97DYJWHhFA9iv\n Rp2ECNKUw+8ZFuEt2S6uD02yI6IbLzP0CWuyqyAO8j0jp+/CqwR0nepYc\n HIG3uRAB67+6UA8Kqm7xqzqLnfqKoXWe2WHmKWqz0SGLf4fJdhMJu/sQU\n 4GDKne/AMsZ9lyehLz7pojOA4GjVB9gpmB1eeeTpWqDjfQM+59N18jVE8\n 1vLj4RZOo3EgAKoR44tECbFl+Xi/LPXJC39wD8ZdZooQNR2UEkxd9Efb1 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10400\"; a=\"285073089\"", "E=Sophos;i=\"5.92,252,1650956400\"; d=\"scan'208\";a=\"285073089\"", "E=Sophos;i=\"5.92,252,1650956400\"; d=\"scan'208\";a=\"651007551\"" ], "X-ExtLoop1": "1", "From": "xuan.ding@intel.com", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com,\n yvonnex.yang@intel.com, cheng1.jiang@intel.com,\n Xuan Ding <xuan.ding@intel.com>", "Subject": "[PATCH] vhost: fix unnecessary dirty page logging", "Date": "Thu, 7 Jul 2022 06:55:13 +0000", "Message-Id": "<20220707065513.66458-1-xuan.ding@intel.com>", "X-Mailer": "git-send-email 2.17.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Xuan Ding <xuan.ding@intel.com>\n\nThe dirty page logging is only required in vhost enqueue direction for\nlive migration. This patch removes the unnecessary dirty page logging\nin vhost dequeue direction. Otherwise, it will result in a performance\ndrop. Some if-else judgements are also optimized to improve performance.\n\nFixes: 6d823bb302c7 (\"vhost: prepare sync for descriptor to mbuf refactoring\")\nFixes: b6eee3e83402 (\"vhost: fix sync dequeue offload\")\n\nSigned-off-by: Xuan Ding <xuan.ding@intel.com>\n---\n lib/vhost/virtio_net.c | 31 +++++++++++++------------------\n 1 file changed, 13 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex e842c35fef..12b7fbe7f9 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -1113,27 +1113,27 @@ sync_fill_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\trte_memcpy((void *)((uintptr_t)(buf_addr)),\n \t\t\t\trte_pktmbuf_mtod_offset(m, void *, mbuf_offset),\n \t\t\t\tcpy_len);\n+\t\t\tvhost_log_cache_write_iova(dev, vq, buf_iova, cpy_len);\n+\t\t\tPRINT_PACKET(dev, (uintptr_t)(buf_addr), cpy_len, 0);\n \t\t} else {\n \t\t\trte_memcpy(rte_pktmbuf_mtod_offset(m, void *, mbuf_offset),\n \t\t\t\t(void *)((uintptr_t)(buf_addr)),\n \t\t\t\tcpy_len);\n \t\t}\n-\t\tvhost_log_cache_write_iova(dev, vq, buf_iova, cpy_len);\n-\t\tPRINT_PACKET(dev, (uintptr_t)(buf_addr), cpy_len, 0);\n \t} else {\n \t\tif (to_desc) {\n \t\t\tbatch_copy[vq->batch_copy_nb_elems].dst =\n \t\t\t\t(void *)((uintptr_t)(buf_addr));\n \t\t\tbatch_copy[vq->batch_copy_nb_elems].src =\n \t\t\t\trte_pktmbuf_mtod_offset(m, void *, mbuf_offset);\n+\t\t\tbatch_copy[vq->batch_copy_nb_elems].log_addr = buf_iova;\n+\t\t\tbatch_copy[vq->batch_copy_nb_elems].len = cpy_len;\n \t\t} else {\n \t\t\tbatch_copy[vq->batch_copy_nb_elems].dst =\n \t\t\t\trte_pktmbuf_mtod_offset(m, void *, mbuf_offset);\n \t\t\tbatch_copy[vq->batch_copy_nb_elems].src =\n \t\t\t\t(void *)((uintptr_t)(buf_addr));\n \t\t}\n-\t\tbatch_copy[vq->batch_copy_nb_elems].log_addr = buf_iova;\n-\t\tbatch_copy[vq->batch_copy_nb_elems].len = cpy_len;\n \t\tvq->batch_copy_nb_elems++;\n \t}\n }\n@@ -2739,18 +2739,14 @@ desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\tif (async_fill_seg(dev, vq, cur, mbuf_offset,\n \t\t\t\t\t buf_iova + buf_offset, cpy_len, false) < 0)\n \t\t\t\tgoto error;\n+\t\t} else if (likely(hdr && cur == m)) {\n+\t\t\trte_memcpy(rte_pktmbuf_mtod_offset(cur, void *, mbuf_offset),\n+\t\t\t\t(void *)((uintptr_t)(buf_addr + buf_offset)),\n+\t\t\t\tcpy_len);\n \t\t} else {\n-\t\t\tif (hdr && cur == m) {\n-\t\t\t\trte_memcpy(rte_pktmbuf_mtod_offset(cur, void *, mbuf_offset),\n-\t\t\t\t\t(void *)((uintptr_t)(buf_addr + buf_offset)),\n-\t\t\t\t\tcpy_len);\n-\t\t\t\tvhost_log_cache_write_iova(dev, vq, buf_iova + buf_offset, cpy_len);\n-\t\t\t\tPRINT_PACKET(dev, (uintptr_t)(buf_addr + buf_offset), cpy_len, 0);\n-\t\t\t} else {\n-\t\t\t\tsync_fill_seg(dev, vq, cur, mbuf_offset,\n-\t\t\t\t\tbuf_addr + buf_offset,\n-\t\t\t\t\tbuf_iova + buf_offset, cpy_len, false);\n-\t\t\t}\n+\t\t\tsync_fill_seg(dev, vq, cur, mbuf_offset,\n+\t\t\t\t buf_addr + buf_offset,\n+\t\t\t\t buf_iova + buf_offset, cpy_len, false);\n \t\t}\n \n \t\tmbuf_avail -= cpy_len;\n@@ -2804,9 +2800,8 @@ desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tasync_iter_finalize(async);\n \t\tif (hdr)\n \t\t\tpkts_info[slot_idx].nethdr = *hdr;\n-\t} else {\n-\t\tif (hdr)\n-\t\t\tvhost_dequeue_offload(dev, hdr, m, legacy_ol_flags);\n+\t} else if (hdr) {\n+\t\tvhost_dequeue_offload(dev, hdr, m, legacy_ol_flags);\n \t}\n \n \treturn 0;\n", "prefixes": [] }