Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109020/?format=api
{ "id": 109020, "url": "https://patches.dpdk.org/api/patches/109020/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220330084356.3614662-1-rbhansali@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220330084356.3614662-1-rbhansali@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220330084356.3614662-1-rbhansali@marvell.com", "date": "2022-03-30T08:43:55", "name": "[1/2] common/cnxk: add ROC errata list", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4ef5ce6389f5997129ee4026e50b94fe8472fa85", "submitter": { "id": 2436, "url": "https://patches.dpdk.org/api/people/2436/?format=api", "name": "Rahul Bhansali", "email": "rbhansali@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220330084356.3614662-1-rbhansali@marvell.com/mbox/", "series": [ { "id": 22289, "url": "https://patches.dpdk.org/api/series/22289/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22289", "date": "2022-03-30T08:43:55", "name": "[1/2] common/cnxk: add ROC errata list", "version": 1, "mbox": "https://patches.dpdk.org/series/22289/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109020/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/109020/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40D1BA0509;\n\tWed, 30 Mar 2022 10:44:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F3DC140685;\n\tWed, 30 Mar 2022 10:44:12 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id B626E4013F\n for <dev@dpdk.org>; Wed, 30 Mar 2022 10:44:10 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 22U3h0o1016534\n for <dev@dpdk.org>; Wed, 30 Mar 2022 01:44:09 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3f475c3897-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 30 Mar 2022 01:44:09 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Wed, 30 Mar 2022 01:44:07 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 30 Mar 2022 01:44:07 -0700", "from localhost.localdomain (unknown [10.28.48.107])\n by maili.marvell.com (Postfix) with ESMTP id 9ABDB3F7057;\n Wed, 30 Mar 2022 01:44:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=JOI8qZLL5xJIwb1fGzaD/MXSLHwBt85L0tonnKFZlHI=;\n b=AfNFUj1RezUwYq61/vAf9BxTuA9wY9K5cqQELXCqK7n/LYOimq9K6qDknl5SNsCKSNc3\n hWXcTb3iJqvr/iPBP9whCGQcCC3paJGD6lrBtbqOcHBoaS8cC5WXvAwXvRzu6C+UjRau\n kB9mQMFCU44V+Uf1nkVe9tkr/FoAGTQDvFB/Z00ApRK11VTZ+8DKFl3U4wrmZSvDzOkl\n AupSoEFcapnaFDsVYpTn39FvCmIqZz70dRzANXiwiAfmE4Knvsy8doI1f8jVOCNESBDF\n gpjMMGI9LG3SvWaVdaNOgKN1BCZ36c1Fo7qZ2u368yojbfoNOmWWnHiphbK/pL/KOLKE DA==", "From": "Rahul Bhansali <rbhansali@marvell.com>", "To": "<dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, Rahul Bhansali <rbhansali@marvell.com>", "Subject": "[PATCH 1/2] common/cnxk: add ROC errata list", "Date": "Wed, 30 Mar 2022 14:13:55 +0530", "Message-ID": "<20220330084356.3614662-1-rbhansali@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "NBLDm_n-zFpNqiPNdr8pptgSTYlLi-fW", "X-Proofpoint-GUID": "NBLDm_n-zFpNqiPNdr8pptgSTYlLi-fW", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514\n definitions=2022-03-30_03,2022-03-29_01,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Created roc_errata.h to list the errata handled in userspace drivers.\nAdded no_drop_re, cq_min_size_4k, no_fc_stype_ststp, no_drop_aging,\nno_vwqe_flush_op etc erratas.\n\nSigned-off-by: Rahul Bhansali <rbhansali@marvell.com>\n---\n drivers/common/cnxk/roc_api.h | 3 +\n drivers/common/cnxk/roc_errata.h | 80 +++++++++++++++++++++++++++\n drivers/common/cnxk/roc_nix_inl_dev.c | 3 +-\n drivers/common/cnxk/roc_nix_queue.c | 4 +-\n drivers/common/cnxk/roc_nix_tm_ops.c | 2 +-\n 5 files changed, 87 insertions(+), 5 deletions(-)\n create mode 100644 drivers/common/cnxk/roc_errata.h", "diff": "diff --git a/drivers/common/cnxk/roc_api.h b/drivers/common/cnxk/roc_api.h\nindex de7452bf55..072f16d77d 100644\n--- a/drivers/common/cnxk/roc_api.h\n+++ b/drivers/common/cnxk/roc_api.h\n@@ -47,6 +47,9 @@\n /* Model */\n #include \"roc_model.h\"\n \n+/* HW Errata */\n+#include \"roc_errata.h\"\n+\n /* Mbox */\n #include \"roc_mbox.h\"\n \ndiff --git a/drivers/common/cnxk/roc_errata.h b/drivers/common/cnxk/roc_errata.h\nnew file mode 100644\nindex 0000000000..31162d5232\n--- /dev/null\n+++ b/drivers/common/cnxk/roc_errata.h\n@@ -0,0 +1,80 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2022 Marvell.\n+ */\n+#ifndef _ROC_ERRATA_H_\n+#define _ROC_ERRATA_H_\n+\n+/* Errata IPBUNIXRX-40129 */\n+static inline bool\n+roc_errata_nix_has_no_drop_re(void)\n+{\n+\treturn (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||\n+\t\troc_model_is_cnf10kb_a0());\n+}\n+\n+/* Errata NIX-34873 */\n+static inline bool\n+roc_errata_nix_has_cq_min_size_4k(void)\n+{\n+\treturn (roc_model_is_cn96_a0() || roc_model_is_cn95_a0());\n+}\n+\n+/* Errata IPBUNPA-37480 */\n+static inline bool\n+roc_errata_npa_has_no_fc_stype_ststp(void)\n+{\n+\treturn roc_model_is_cn10ka_a0() ? true : false;\n+}\n+\n+/* Errata IPBUNIXTX-39337 */\n+static inline bool\n+roc_errata_nix_has_no_drop_aging(void)\n+{\n+\treturn (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||\n+\t\troc_model_is_cnf10kb_a0());\n+}\n+\n+/* Errata IPBUNIXRX-40130 */\n+static inline bool\n+roc_errata_nix_has_no_vwqe_flush_op(void)\n+{\n+\treturn (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||\n+\t\troc_model_is_cnf10kb_a0());\n+}\n+\n+/* Errata IPBURVUM-38481 */\n+static inline bool\n+roc_errata_ruvm_has_no_interrupt_with_msixen(void)\n+{\n+\treturn true;\n+}\n+\n+/* Errata IPBUNIXTX-39300 */\n+static inline bool\n+roc_errata_nix_has_assign_incorrect_qintidx(void)\n+{\n+\treturn true;\n+}\n+\n+/* Errata IPBUCPT-38551 */\n+static inline bool\n+roc_errata_cpt_has_use_incorrect_ldwb(void)\n+{\n+\treturn true;\n+}\n+\n+/* Errata IPBUNIXTX-39322 */\n+static inline bool\n+roc_errata_nix_has_overwrite_incorrect_sq_intr(void)\n+{\n+\treturn true;\n+}\n+\n+/* Errata IPBUNIXTX-39248 */\n+static inline bool\n+roc_errata_nix_has_perf_issue_on_stats_update(void)\n+{\n+\treturn true;\n+}\n+\n+#endif /* _ROC_ERRATA_H_ */\ndiff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c\nindex 5a032aab52..51f1f6807b 100644\n--- a/drivers/common/cnxk/roc_nix_inl_dev.c\n+++ b/drivers/common/cnxk/roc_nix_inl_dev.c\n@@ -358,8 +358,7 @@ nix_inl_nix_setup(struct nix_inl_dev *inl_dev)\n \treq->rx_cfg = NIX_INL_LF_RX_CFG;\n \treq->flags = NIX_LF_RSS_TAG_LSB_AS_ADDER;\n \n-\tif (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||\n-\t roc_model_is_cnf10kb_a0())\n+\tif (roc_errata_nix_has_no_drop_re())\n \t\treq->rx_cfg &= ~ROC_NIX_LF_RX_CFG_DROP_RE;\n \n \trc = mbox_process_msg(mbox, (void *)&rsp);\ndiff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_nix_queue.c\nindex 7d271854f4..07dab4b74f 100644\n--- a/drivers/common/cnxk/roc_nix_queue.c\n+++ b/drivers/common/cnxk/roc_nix_queue.c\n@@ -527,7 +527,7 @@ roc_nix_cq_init(struct roc_nix *roc_nix, struct roc_nix_cq *cq)\n \t/* Map CQ0 [RQ0] to CINT0 and so on till max 64 irqs */\n \tcq_ctx->cint_idx = cq->qid;\n \n-\tif (roc_model_is_cn96_a0() || roc_model_is_cn95_a0()) {\n+\tif (roc_errata_nix_has_cq_min_size_4k()) {\n \t\tconst float rx_cq_skid = NIX_CQ_FULL_ERRATA_SKID;\n \t\tuint16_t min_rx_drop;\n \n@@ -658,7 +658,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)\n \n \tmemset(&aura, 0, sizeof(aura));\n \taura.fc_ena = 1;\n-\tif (roc_model_is_cn9k() || roc_model_is_cn10ka_a0())\n+\tif (roc_model_is_cn9k() || roc_errata_npa_has_no_fc_stype_ststp())\n \t\taura.fc_stype = 0x0; /* STF */\n \telse\n \t\taura.fc_stype = 0x3; /* STSTP */\ndiff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c\nindex 1d9a02bc06..5884ce5114 100644\n--- a/drivers/common/cnxk/roc_nix_tm_ops.c\n+++ b/drivers/common/cnxk/roc_nix_tm_ops.c\n@@ -38,7 +38,7 @@ roc_nix_tm_sq_aura_fc(struct roc_nix_sq *sq, bool enable)\n \n \treq->aura.fc_ena = enable;\n \treq->aura_mask.fc_ena = 1;\n-\tif (roc_model_is_cn9k() || roc_model_is_cn10ka_a0()) {\n+\tif (roc_model_is_cn9k() || roc_errata_npa_has_no_fc_stype_ststp()) {\n \t\treq->aura.fc_stype = 0x0; /* STF */\n \t\treq->aura_mask.fc_stype = 0x0; /* STF */\n \t} else {\n", "prefixes": [ "1/2" ] }