Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 109007,
    "url": "https://patches.dpdk.org/api/patches/109007/?format=api",
    "web_url": "https://patches.dpdk.org/project/dts/patch/20220329102408.1137392-3-tadhg.kearney@intel.com/",
    "project": {
        "id": 3,
        "url": "https://patches.dpdk.org/api/projects/3/?format=api",
        "name": "DTS",
        "link_name": "dts",
        "list_id": "dts.dpdk.org",
        "list_email": "dts@dpdk.org",
        "web_url": "",
        "scm_url": "git://dpdk.org/tools/dts",
        "webscm_url": "http://git.dpdk.org/tools/dts/",
        "list_archive_url": "https://inbox.dpdk.org/dts",
        "list_archive_url_format": "https://inbox.dpdk.org/dts/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220329102408.1137392-3-tadhg.kearney@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dts/20220329102408.1137392-3-tadhg.kearney@intel.com",
    "date": "2022-03-29T10:24:08",
    "name": "[V3,2/2] tests/*: Remove old DPDK flags from power tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "5f3dea66b85f00a81d93fd85523d74023aa3e087",
    "submitter": {
        "id": 2533,
        "url": "https://patches.dpdk.org/api/people/2533/?format=api",
        "name": "Tadhg Kearney",
        "email": "tadhg.kearney@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dts/patch/20220329102408.1137392-3-tadhg.kearney@intel.com/mbox/",
    "series": [
        {
            "id": 22282,
            "url": "https://patches.dpdk.org/api/series/22282/?format=api",
            "web_url": "https://patches.dpdk.org/project/dts/list/?series=22282",
            "date": "2022-03-29T10:24:06",
            "name": "Remove old DPDK flags from power tests",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/22282/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/109007/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/109007/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dts-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9C66DA0509;\n\tTue, 29 Mar 2022 12:24:16 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9708C42818;\n\tTue, 29 Mar 2022 12:24:16 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 72DD24281B\n for <dts@dpdk.org>; Tue, 29 Mar 2022 12:24:15 +0200 (CEST)",
            "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Mar 2022 03:24:14 -0700",
            "from silpixa00401183.ir.intel.com ([10.55.129.105])\n by orsmga007.jf.intel.com with ESMTP; 29 Mar 2022 03:24:13 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1648549455; x=1680085455;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=zj34JRaIylt3X49r6XsIrHhG8xEoyDfAmG2cky8cAbQ=;\n b=ODHHI2TavFq33bwUwyU0ipnAoAnOBt9Rft3AS/AqJMGdeqK0vtHfhgcO\n 6cVBiRHd5I2TQP/2pXyp7WVmWvW/C9zew/CMQwRbME3UkaXqVVf45GBU1\n atvIU0ddkxAmYmflKT5kjqK+bo+KAASCYQlKpSJxEN+UneIj/5UoKv/Di\n G2Gy39JDg7MoRxz7d9M4WnxU+pWicAdwNaaSi5izecXn/RPTQwKpH6M01\n LWeMYGUAKqd/isyManuBN20I6p9InTv/ISS34Oi+AeGT/RWmXBbTA3/f0\n c0TGMut4gHZVD5CgB5Cu2/Vy4QP165FR84EijivS+ZZMuN6kh8/ppVmdh g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10300\"; a=\"239811230\"",
            "E=Sophos;i=\"5.90,220,1643702400\"; d=\"scan'208\";a=\"239811230\"",
            "E=Sophos;i=\"5.90,220,1643702400\"; d=\"scan'208\";a=\"546332889\""
        ],
        "X-ExtLoop1": "1",
        "From": "Tadhg Kearney <tadhg.kearney@intel.com>",
        "To": "dts@dpdk.org",
        "Cc": "reshma.pattan@intel.com,\n\tTadhg Kearney <tadhg.kearney@intel.com>",
        "Subject": "[dts][V3 2/2] tests/*: Remove old DPDK flags from power tests",
        "Date": "Tue, 29 Mar 2022 10:24:08 +0000",
        "Message-Id": "<20220329102408.1137392-3-tadhg.kearney@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220329102408.1137392-1-tadhg.kearney@intel.com>",
        "References": "<20220329102408.1137392-1-tadhg.kearney@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dts@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
        "List-Post": "<mailto:dts@dpdk.org>",
        "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dts-bounces@dpdk.org"
    },
    "content": "* CONFIG_RTE_LIBRTE_I40E_PMD, CONFIG_RTE_LIBRTE_POWER + _CONFIG option do not exist anymore\n* Telemetry is built by default + _LIBRTE_ option also does not exist anymore\n\nSigned-off-by: Tadhg Kearney <tadhg.kearney@intel.com>\n---\n tests/TestSuite_power_branch_ratio.py | 39 +--------------------------\n tests/TestSuite_power_telemetry.py    | 18 +------------\n 2 files changed, 2 insertions(+), 55 deletions(-)",
    "diff": "diff --git a/tests/TestSuite_power_branch_ratio.py b/tests/TestSuite_power_branch_ratio.py\nindex deb271e0..a2c28478 100644\n--- a/tests/TestSuite_power_branch_ratio.py\n+++ b/tests/TestSuite_power_branch_ratio.py\n@@ -44,8 +44,7 @@ from pprint import pformat\n from framework.exception import VerifyFailure\n from framework.packet import Packet\n from framework.pktgen import TRANSMIT_CONT\n-from framework.qemu_libvirt import LibvirtKvm\n-from framework.settings import HEADER_SIZE, HOST_BUILD_TYPE_SETTING, load_global_setting\n+from framework.settings import HEADER_SIZE\n from framework.test_case import TestCase\n from framework.utils import create_mask as dts_create_mask\n \n@@ -227,27 +226,6 @@ class TestPowerBranchRatio(TestCase):\n \n         return result\n \n-    @property\n-    def compile_switch(self):\n-        sw_table = [\n-            \"CONFIG_RTE_LIBRTE_POWER\",\n-            \"CONFIG_RTE_LIBRTE_POWER_DEBUG\",\n-        ]\n-        return sw_table\n-\n-    def preset_compilation(self):\n-        if \"meson\" == load_global_setting(HOST_BUILD_TYPE_SETTING):\n-            compile_SWs = self.compile_switch + [\"CONFIG_RTE_LIBRTE_I40E_PMD\"]\n-            self.dut.set_build_options(dict([(sw[7:], \"y\") for sw in compile_SWs]))\n-        else:\n-            for sw in self.compile_switch:\n-                cmd = (\n-                    \"sed -i -e \" \"'s/{0}=n$/{0}=y/' \" \"{1}/config/common_base\"\n-                ).format(sw, self.target_dir)\n-                self.d_a_con(cmd)\n-        # re-compile dpdk source code\n-        self.dut.build_install_dpdk(self.target)\n-\n     @contextmanager\n     def restore_environment(self):\n         try:\n@@ -258,19 +236,6 @@ class TestPowerBranchRatio(TestCase):\n                 self.restore_port_drv()\n             except Exception as e:\n                 self.logger.error(traceback.format_exc())\n-            # restore compilation\n-            if \"meson\" == load_global_setting(HOST_BUILD_TYPE_SETTING):\n-                self.dut.set_build_options(\n-                    dict([(sw[7:], \"n\") for sw in self.compile_switch])\n-                )\n-            else:\n-                for sw in self.compile_switch:\n-                    cmd = (\n-                        \"sed -i -e \" \"'s/{0}=y$/{0}=n/' \" \"{1}/config/common_base\"\n-                    ).format(sw, self.target_dir)\n-                    self.d_a_con(cmd)\n-            # re-compile dpdk source code\n-            self.dut.build_install_dpdk(self.target)\n \n     def restore_port_drv(self):\n         driver = self.drivername\n@@ -532,8 +497,6 @@ class TestPowerBranchRatio(TestCase):\n         # modprobe msr module to let the application can get the CPU HW info\n         self.d_a_con(\"modprobe msr\")\n         self.d_a_con(\"cpupower frequency-set -g userspace > /dev/null 2>&1\")\n-        # compile\n-        self.preset_compilation()\n         # init binary\n         self.init_vm_power_mgr()\n         self.init_testpmd()\ndiff --git a/tests/TestSuite_power_telemetry.py b/tests/TestSuite_power_telemetry.py\nindex afb55262..39acdef2 100644\n--- a/tests/TestSuite_power_telemetry.py\n+++ b/tests/TestSuite_power_telemetry.py\n@@ -45,7 +45,7 @@ from pprint import pformat\n from framework.exception import VerifyFailure\n from framework.packet import Packet\n from framework.pktgen import TRANSMIT_CONT\n-from framework.settings import HEADER_SIZE, HOST_BUILD_TYPE_SETTING, load_global_setting\n+from framework.settings import HEADER_SIZE\n from framework.test_case import TestCase\n from framework.utils import create_mask as dts_create_mask\n \n@@ -125,20 +125,6 @@ class TestPowerTelemetry(TestCase):\n \n         return result\n \n-    def preset_compilation(self):\n-        if self.dut.skip_setup:\n-            return\n-        SW = \"CONFIG_RTE_LIBRTE_TELEMETRY\"\n-        if \"meson\" == load_global_setting(HOST_BUILD_TYPE_SETTING):\n-            self.dut.set_build_options({SW[7:]: \"y\"})\n-        else:\n-            cmd = \"sed -i -e 's/{0}=n$/{0}=y/' {1}/config/common_base\".format(\n-                SW, self.target_dir\n-            )\n-            self.d_a_con(cmd)\n-        # re-compile dpdk source code\n-        self.dut.build_install_dpdk(self.target)\n-\n     def prepare_binary(self, name):\n         example_dir = \"examples/\" + name\n         out = self.dut.build_dpdk_apps(\"./\" + example_dir)\n@@ -445,8 +431,6 @@ class TestPowerTelemetry(TestCase):\n \n     def preset_test_environment(self):\n         self.is_l3fwd_on = None\n-        # open compile switch and re-compile target source code\n-        self.preset_compilation()\n         # init binary\n         self.init_l3fwd_power()\n         self.init_telemetry()\n",
    "prefixes": [
        "V3",
        "2/2"
    ]
}