Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103889/?format=api
{ "id": 103889, "url": "https://patches.dpdk.org/api/patches/103889/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211105215409.5706-3-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211105215409.5706-3-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211105215409.5706-3-ivan.malov@oktetlabs.ru", "date": "2021-11-05T21:54:06", "name": "[2/5] common/sfc_efx/base: refine adding count action to a set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "71d74581be1b0970f5d527f64f2bba2873250e9f", "submitter": { "id": 869, "url": "https://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211105215409.5706-3-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 20356, "url": "https://patches.dpdk.org/api/series/20356/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20356", "date": "2021-11-05T21:54:04", "name": "net/sfc: support IP TTL decrement actions in transfer flows", "version": 1, "mbox": "https://patches.dpdk.org/series/20356/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103889/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/103889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA20DA0C41;\n\tFri, 5 Nov 2021 22:54:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6E5034111E;\n\tFri, 5 Nov 2021 22:54:34 +0100 (CET)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 69E9440689;\n Fri, 5 Nov 2021 22:54:31 +0100 (CET)", "from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPS id 05AD17F6F3;\n Sat, 6 Nov 2021 00:54:31 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 05AD17F6F3", "Authentication-Results": "shelob.oktetlabs.ru/05AD17F6F3; dkim=none;\n dkim-atps=neutral", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>,\n Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Sat, 6 Nov 2021 00:54:06 +0300", "Message-Id": "<20211105215409.5706-3-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211105215409.5706-1-ivan.malov@oktetlabs.ru>", "References": "<20211105215409.5706-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/5] common/sfc_efx/base: refine adding count\n action to a set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1) Invalid counter ID is always set by default.\n Do not set it again when adding the action.\n\n2) Counter ID validity check is missing in the\n action set allocation helper. Introduce it.\n\nFixes: 238306cf9aff (\"common/sfc_efx/base: support counter in action set\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx_mae.c | 25 +++++++++++++++++--------\n 1 file changed, 17 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex 542c345b76..c93fe9bdfc 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -1567,13 +1567,14 @@ efx_mae_action_set_add_count(\n \t * two steps: first add this action to the action spec, and then\n \t * add the counter ID to the spec. This allows validity checking\n \t * and resource allocation to be done separately.\n-\t * Mark the counter ID as invalid in the spec to ensure that the\n-\t * caller must also invoke efx_mae_action_set_fill_in_counter_id()\n-\t * before action set allocation.\n+\t *\n+\t * In order to fill in the counter ID, the caller is supposed to invoke\n+\t * efx_mae_action_set_fill_in_counter_id(). If they do not do that,\n+\t * efx_mae_action_set_alloc() invocation will throw an error.\n+\t *\n+\t * For now, no arguments are supposed to be handled.\n \t */\n-\tspec->ema_rsrc.emar_counter_id.id = EFX_MAE_RSRC_ID_INVALID;\n \n-\t/* Nothing else is supposed to take place over here. */\n \tif (arg_size != 0) {\n \t\trc = EINVAL;\n \t\tgoto fail1;\n@@ -2585,6 +2586,12 @@ efx_mae_action_set_alloc(\n \t\tgoto fail2;\n \t}\n \n+\tif (spec->ema_n_count_actions == 1 &&\n+\t spec->ema_rsrc.emar_counter_id.id == EFX_MAE_RSRC_ID_INVALID) {\n+\t\trc = EINVAL;\n+\t\tgoto fail3;\n+\t}\n+\n \treq.emr_cmd = MC_CMD_MAE_ACTION_SET_ALLOC;\n \treq.emr_in_buf = payload;\n \treq.emr_in_length = MC_CMD_MAE_ACTION_SET_ALLOC_IN_LEN;\n@@ -2662,24 +2669,26 @@ efx_mae_action_set_alloc(\n \n \tif (req.emr_rc != 0) {\n \t\trc = req.emr_rc;\n-\t\tgoto fail3;\n+\t\tgoto fail4;\n \t}\n \n \tif (req.emr_out_length_used < MC_CMD_MAE_ACTION_SET_ALLOC_OUT_LEN) {\n \t\trc = EMSGSIZE;\n-\t\tgoto fail4;\n+\t\tgoto fail5;\n \t}\n \n \taset_id.id = MCDI_OUT_DWORD(req, MAE_ACTION_SET_ALLOC_OUT_AS_ID);\n \tif (aset_id.id == EFX_MAE_RSRC_ID_INVALID) {\n \t\trc = ENOENT;\n-\t\tgoto fail5;\n+\t\tgoto fail6;\n \t}\n \n \taset_idp->id = aset_id.id;\n \n \treturn (0);\n \n+fail6:\n+\tEFSYS_PROBE(fail6);\n fail5:\n \tEFSYS_PROBE(fail5);\n fail4:\n", "prefixes": [ "2/5" ] }