Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101102/?format=api
{ "id": 101102, "url": "https://patches.dpdk.org/api/patches/101102/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211011155057.302142-24-skori@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211011155057.302142-24-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211011155057.302142-24-skori@marvell.com", "date": "2021-10-11T15:50:51", "name": "[v4,23/28] net/cnxk: support ops to delete meter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6a3cbc8de8ba7a2aa5c4bcb90a5e4e70cafdaaf2", "submitter": { "id": 1318, "url": "https://patches.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211011155057.302142-24-skori@marvell.com/mbox/", "series": [ { "id": 19528, "url": "https://patches.dpdk.org/api/series/19528/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19528", "date": "2021-10-11T15:50:28", "name": "Support ingress policer", "version": 4, "mbox": "https://patches.dpdk.org/series/19528/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/101102/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/101102/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EAB3FA034F;\n\tMon, 11 Oct 2021 17:53:33 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4F233411C0;\n\tMon, 11 Oct 2021 17:52:00 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4B5BA411D3\n for <dev@dpdk.org>; Mon, 11 Oct 2021 17:51:59 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19BEFXow028248\n for <dev@dpdk.org>; Mon, 11 Oct 2021 08:51:58 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3bmpv4rc49-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 11 Oct 2021 08:51:58 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 11 Oct 2021 08:51:56 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 11 Oct 2021 08:51:56 -0700", "from localhost.localdomain (unknown [10.28.34.25])\n by maili.marvell.com (Postfix) with ESMTP id BEB503F7079;\n Mon, 11 Oct 2021 08:51:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=d4pm+w3UmlMu+uldMG0Z27hlC5y/xYivyd+9MHt+5wE=;\n b=YOKb/gtulPWl5fPaAPwPOZ9LlExw8wB1R1fMxJRLLGKfpjrH4BDsBxQmBdm/LIES2RYG\n 3WC8L5mf1/qu4TOrQST32Y3KDY6ou8Ra1IK1cUZvB3kY2/JIdqsa8nQ7DN08Tt+Lfm2b\n H0RxeR7QngKMfNrZSYZvi7jOuCz9OQk+kwV18uLrjv+x2GbZlwy2mcuZrD960dQQwak1\n +jbylvtSsBqJolYKQKkCE0tX9+EGHQL4fvpdHa61vXTP5x5o456ZSVEPTEp4h1oKEGCA\n VHLKbywdaXrJfz/TTWGBOrIRCi2fex7GoWWKPRne30SdETabgBJb+LDed+MMtOUAt98S oQ==", "From": "<skori@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Rakesh Kudurumalla <rkudurumalla@marvell.com>", "Date": "Mon, 11 Oct 2021 21:20:51 +0530", "Message-ID": "<20211011155057.302142-24-skori@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211011155057.302142-1-skori@marvell.com>", "References": "<20210930090844.1059326-1-skori@marvell.com>\n <20211011155057.302142-1-skori@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "JLhmQdWHoUFmpP3T7l4idrg18TmBtFa9", "X-Proofpoint-GUID": "JLhmQdWHoUFmpP3T7l4idrg18TmBtFa9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-11_05,2021-10-11_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH v4 23/28] net/cnxk: support ops to delete meter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nImplement API to delete meter instance for CNXK platform.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\nSigned-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>\n---\nv4:\n - Rebase support on dpdk-next-net-mrvl branch\n - Handled meter action during flow destroy\n - Handled meter cleanup during port shutdown\n \nv3:\n - Rebase support on latest DPDK\n - Handled multilevel chaining for tree hierarchy\n - Fix naming convention\nv2:\n - Rebase support on latest DPDK\n - Handled multilevel chaining for linear hierarchy\n - Review comments incorporated\n\n drivers/net/cnxk/cnxk_ethdev_mtr.c | 90 ++++++++++++++++++++++++++++++\n 1 file changed, 90 insertions(+)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev_mtr.c b/drivers/net/cnxk/cnxk_ethdev_mtr.c\nindex b258de0253..28eba29f0a 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_mtr.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_mtr.c\n@@ -8,6 +8,10 @@\n #define NIX_MTR_COUNT_MAX 73 /* 64(leaf) + 8(mid) + 1(top) */\n #define NIX_MTR_COUNT_PER_FLOW 3 /* 1(leaf) + 1(mid) + 1(top) */\n \n+static const enum roc_nix_bpf_level_flag lvl_map[] = {ROC_NIX_BPF_LEVEL_F_LEAF,\n+\t\t\t\t\t\t ROC_NIX_BPF_LEVEL_F_MID,\n+\t\t\t\t\t\t ROC_NIX_BPF_LEVEL_F_TOP};\n+\n static struct rte_mtr_capabilities mtr_capa = {\n \t.n_max = NIX_MTR_COUNT_MAX,\n \t.n_shared_max = NIX_MTR_COUNT_PER_FLOW,\n@@ -466,6 +470,91 @@ cnxk_nix_mtr_create(struct rte_eth_dev *eth_dev, uint32_t mtr_id,\n \treturn 0;\n }\n \n+static int\n+cnxk_nix_mtr_destroy(struct rte_eth_dev *eth_dev, uint32_t mtr_id,\n+\t\t struct rte_mtr_error *error)\n+{\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tstruct roc_nix_bpf_objs profs = {0};\n+\tstruct cnxk_mtr *fm = &dev->mtr;\n+\tstruct roc_nix *nix = &dev->nix;\n+\tstruct cnxk_meter_node *mtr;\n+\tstruct cnxk_meter_node *mid_mtr;\n+\tstruct cnxk_meter_node *top_mtr;\n+\tint rc = 0;\n+\n+\tmtr = nix_mtr_find(dev, mtr_id);\n+\tif (mtr == NULL) {\n+\t\treturn -rte_mtr_error_set(error, ENOENT,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_ID, &mtr_id,\n+\t\t\t\t\t \"Meter id is invalid.\");\n+\t}\n+\n+\tif (mtr->ref_cnt) {\n+\t\treturn -rte_mtr_error_set(error, EADDRINUSE,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_ID, &mtr_id,\n+\t\t\t\t\t \"Meter id in use.\");\n+\t}\n+\n+\tswitch (lvl_map[mtr->level]) {\n+\tcase ROC_NIX_BPF_LEVEL_F_LEAF:\n+\t\tif (mtr->is_next) {\n+\t\t\trc = roc_nix_bpf_connect(nix, ROC_NIX_BPF_LEVEL_F_LEAF,\n+\t\t\t\t\t\t mtr->bpf_id,\n+\t\t\t\t\t\t ROC_NIX_BPF_ID_INVALID);\n+\t\t}\n+\t\tbreak;\n+\tcase ROC_NIX_BPF_LEVEL_F_MID:\n+\t\twhile ((mtr->prev_cnt) + 1) {\n+\t\t\tmid_mtr =\n+\t\t\t\tnix_mtr_find(dev, mtr->prev_id[mtr->prev_cnt]);\n+\t\t\trc = roc_nix_bpf_connect(nix, ROC_NIX_BPF_LEVEL_F_LEAF,\n+\t\t\t\t\t\t mid_mtr->bpf_id,\n+\t\t\t\t\t\t ROC_NIX_BPF_ID_INVALID);\n+\t\t\tmtr->prev_cnt--;\n+\t\t}\n+\t\tif (mtr->is_next) {\n+\t\t\trc = roc_nix_bpf_connect(nix, ROC_NIX_BPF_LEVEL_F_MID,\n+\t\t\t\t\t\t mtr->bpf_id,\n+\t\t\t\t\t\t ROC_NIX_BPF_ID_INVALID);\n+\t\t}\n+\t\tbreak;\n+\tcase ROC_NIX_BPF_LEVEL_F_TOP:\n+\t\twhile (mtr->prev_cnt) {\n+\t\t\ttop_mtr =\n+\t\t\t\tnix_mtr_find(dev, mtr->prev_id[mtr->prev_cnt]);\n+\t\t\trc = roc_nix_bpf_connect(nix, ROC_NIX_BPF_LEVEL_F_MID,\n+\t\t\t\t\t\t top_mtr->bpf_id,\n+\t\t\t\t\t\t ROC_NIX_BPF_ID_INVALID);\n+\t\t\tmtr->prev_cnt--;\n+\t\t}\n+\t\tbreak;\n+\tdefault:\n+\t\treturn -rte_mtr_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_ID, NULL,\n+\t\t\t\t\t \"Invalid meter level\");\n+\t}\n+\n+\tif (rc)\n+\t\tgoto exit;\n+\n+\tprofs.level = mtr->level;\n+\tprofs.count = 1;\n+\tprofs.ids[0] = mtr->bpf_id;\n+\trc = roc_nix_bpf_free(nix, &profs, 1);\n+\tif (rc)\n+\t\tgoto exit;\n+\n+\tmtr->policy->ref_cnt--;\n+\tmtr->profile->ref_cnt--;\n+\tTAILQ_REMOVE(fm, mtr, next);\n+\tplt_free(mtr->params.dscp_table);\n+\tplt_free(mtr);\n+\n+exit:\n+\treturn rc;\n+}\n+\n const struct rte_mtr_ops nix_mtr_ops = {\n \t.capabilities_get = cnxk_nix_mtr_capabilities_get,\n \t.meter_profile_add = cnxk_nix_mtr_profile_add,\n@@ -474,6 +563,7 @@ const struct rte_mtr_ops nix_mtr_ops = {\n \t.meter_policy_add = cnxk_nix_mtr_policy_add,\n \t.meter_policy_delete = cnxk_nix_mtr_policy_delete,\n \t.create = cnxk_nix_mtr_create,\n+\t.destroy = cnxk_nix_mtr_destroy,\n };\n \n int\n", "prefixes": [ "v4", "23/28" ] }