Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10042/?format=api
{ "id": 10042, "url": "https://patches.dpdk.org/api/patches/10042/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1453426717-2522-1-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1453426717-2522-1-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1453426717-2522-1-git-send-email-stephen@networkplumber.org", "date": "2016-01-22T01:38:37", "name": "[dpdk-dev] igb: set default thresholds correctly based on mac type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c1e7fd43df8a0b49bfb52dc7d42c629f12ebb9d3", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1453426717-2522-1-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10042/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10042/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 062A08F9D;\n\tFri, 22 Jan 2016 02:38:36 +0100 (CET)", "from mail-pa0-f47.google.com (mail-pa0-f47.google.com\n\t[209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 658838E7F\n\tfor <dev@dpdk.org>; Fri, 22 Jan 2016 02:38:34 +0100 (CET)", "by mail-pa0-f47.google.com with SMTP id yy13so32321665pab.3\n\tfor <dev@dpdk.org>; Thu, 21 Jan 2016 17:38:34 -0800 (PST)", "from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tr12sm5357369pfi.9.2016.01.21.17.38.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Jan 2016 17:38:32 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=2xPDRdmZ1n2yjJ/4zF1Yk69essJZIykrzxrQfWVl3Ko=;\n\tb=csdtMFBX/MwOn808UUA4S6PyG7lpMPnH20iZcDpt9huScReY91Mz/R/SsqVVKEgY3A\n\tbP5rcISKtsugHK8NB2iFSxpKl2mUjuYWlnYUcdwiF2RhgsRhr+JfFLVMPz0zX0swkhVz\n\trgzXkVBIpr5cywPf0CIrb2MvCOdyn3ZXCD//7c6pAXiu4nYWjEPyuT1BAhrJGdMtrjRH\n\t3D0fSxYKX2562Gm4MAHPGDYVLd+DgsQ3Ns09wrNR4zjiGP2i68ks5gl9InKFvyre6jIB\n\tNGQ8/0sWFJjr49G9nRUHsDmYyKPNZ7TEwIdXjCnP7i7pY6s8aiDZz5Hk3pK2bB4FA7cv\n\t8yXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=2xPDRdmZ1n2yjJ/4zF1Yk69essJZIykrzxrQfWVl3Ko=;\n\tb=f28S2CokkitPCi82LHuLNW+gVnlMF/ik9H1YelMdR0K01offdY8FFDp/+/Zf7ergvX\n\tA3xwrh8H1Gmgoum62VuQnUhszEYlzwfmLQb4Ho0/SqbGI0UWO4DFy2CffH4goXovzHRM\n\trA3VyBMdwjihmAAJCf6uqiDa8L2fVChZgf0rlENgHh8r/iBI5h3ZlEnOy/6/3LcNScf+\n\t0pGxbJJZ5f5vsceEQ2IIVIP+NeZmYhYFHHIEQnPD/Br1wv6MWNKiaVCi6eHTn9TDMVr4\n\tFOsy4NvmK8xlGJcdP6EIBsTPpmEz1lTNwXlc3+GHVL66C3yR/F1NKg05wZGjxasqBlKF\n\tfF2w==", "X-Gm-Message-State": "AG10YOQH4NhLrJutdIMTUDWSs7G3BTqk62u9P5AyYLqE5ruqG47i+UXK53ZLwyGM+Xmefg==", "X-Received": "by 10.66.141.165 with SMTP id rp5mr647289pab.56.1453426713822;\n\tThu, 21 Jan 2016 17:38:33 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "wenzhuo.lu@intel.com", "Date": "Thu, 21 Jan 2016 17:38:37 -0800", "Message-Id": "<1453426717-2522-1-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH] igb: set default thresholds correctly based on\n\tmac type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This brings the DPDK igb driver inline with the behavior used by\nthe current Linux driver. The IGB hardware has several different\nMAC types and the threshold values that work vary based on the hardware.\n\nSince DPDK 1.8 it has been up to devices to provide the correct default\nconfiguration parameter. But the igb driver gives values that are broken\non some devices, and always causes a warning message at startup.\n\nPlease test this on real hardware, I don't have the luxury of a\nhardware lab full of variations of this chip.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/e1000/igb_ethdev.c | 11 ++++++-----\n drivers/net/e1000/igb_rxtx.c | 8 ++++----\n 2 files changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex d1bbcda..31b2c1f 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -61,13 +61,14 @@\n * Default values for port configuration\n */\n #define IGB_DEFAULT_RX_FREE_THRESH 32\n-#define IGB_DEFAULT_RX_PTHRESH 8\n+\n+#define IGB_DEFAULT_RX_PTHRESH ((hw->mac.type == e1000_i354) ? 12 : 8)\n #define IGB_DEFAULT_RX_HTHRESH 8\n-#define IGB_DEFAULT_RX_WTHRESH 0\n+#define IGB_DEFAULT_RX_WTHRESH ((hw->mac.type == e1000_82576) ? 1 : 4)\n \n-#define IGB_DEFAULT_TX_PTHRESH 32\n-#define IGB_DEFAULT_TX_HTHRESH 0\n-#define IGB_DEFAULT_TX_WTHRESH 0\n+#define IGB_DEFAULT_TX_PTHRESH ((hw->mac.type == e1000_i354) ? 20: 8)\n+#define IGB_DEFAULT_TX_HTHRESH 1\n+#define IGB_DEFAULT_TX_WTHRESH ((hw->mac.type == e1000_82576) ? 1 : 16)\n \n #define IGB_HKEY_MAX_INDEX 10\n \ndiff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c\nindex 996e7da..499b6b4 100644\n--- a/drivers/net/e1000/igb_rxtx.c\n+++ b/drivers/net/e1000/igb_rxtx.c\n@@ -1315,13 +1315,13 @@ eth_igb_tx_queue_setup(struct rte_eth_dev *dev,\n \t * driver.\n \t */\n \tif (tx_conf->tx_free_thresh != 0)\n-\t\tPMD_INIT_LOG(WARNING, \"The tx_free_thresh parameter is not \"\n+\t\tPMD_INIT_LOG(INFO, \"The tx_free_thresh parameter is not \"\n \t\t\t \"used for the 1G driver.\");\n \tif (tx_conf->tx_rs_thresh != 0)\n-\t\tPMD_INIT_LOG(WARNING, \"The tx_rs_thresh parameter is not \"\n+\t\tPMD_INIT_LOG(INFO, \"The tx_rs_thresh parameter is not \"\n \t\t\t \"used for the 1G driver.\");\n-\tif (tx_conf->tx_thresh.wthresh == 0)\n-\t\tPMD_INIT_LOG(WARNING, \"To improve 1G driver performance, \"\n+\tif (tx_conf->tx_thresh.wthresh == 0 && hw->mac.type != e1000_82576)\n+\t\tPMD_INIT_LOG(INFO, \"To improve 1G driver performance, \"\n \t\t\t \"consider setting the TX WTHRESH value to 4, 8, \"\n \t\t\t \"or 16.\");\n \n", "prefixes": [ "dpdk-dev" ] }