Cover Detail
Show a cover letter.
GET /api/covers/86558/?format=api
{ "id": 86558, "url": "https://patches.dpdk.org/api/covers/86558/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20210114094501.13613-1-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210114094501.13613-1-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210114094501.13613-1-stevex.yang@intel.com", "date": "2021-01-14T09:45:01", "name": "[v3,00/22] fix rx packets dropped issue", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20210114094501.13613-1-stevex.yang@intel.com/mbox/", "series": [ { "id": 14725, "url": "https://patches.dpdk.org/api/series/14725/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14725", "date": "2021-01-14T09:45:01", "name": "fix rx packets dropped issue", "version": 3, "mbox": "https://patches.dpdk.org/series/14725/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/86558/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BFCBFA0A02;\n\tThu, 14 Jan 2021 10:48:46 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4888114102E;\n\tThu, 14 Jan 2021 10:48:46 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 55E2B14102B\n for <dev@dpdk.org>; Thu, 14 Jan 2021 10:48:45 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 01:48:44 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 01:48:34 -0800" ], "IronPort-SDR": [ "\n /JHqLDUiEB9Pl6KZ/vzvfibeYi4V+RCi8Y4QtoA/nw92KzEsVuQDQEZGgD+yhAwqKQiwmabdAW\n SOrKjWr7pNmA==", "\n +QoM5NdCxHh68Q8opu4U1yu7/0ppLlFg956JTX/SX8l88Qv6Gh8Cik15VITuGJPwhxhpBvl1/L\n VC1bQbVsSk9g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9863\"; a=\"165426662\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"165426662\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"382211563\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, wenzhuo.lu@intel.com,\n beilei.xing@intel.com, bernard.iremonger@intel.com, hemant.agrawal@nxp.com,\n xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com,\n oulijun@huawei.com, jingjing.wu@intel.com, qiming.yang@intel.com,\n qi.z.zhang@intel.com, rosen.xu@intel.com, hkalra@marvell.com,\n ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com,\n shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com,\n mczekaj@marvell.com, jia.guo@intel.com, haiyue.wang@intel.com,\n rahul.lakkireddy@chelsio.com, asomalap@amd.com, g.singh@nxp.com,\n sachin.saxena@oss.nxp.com, xuanziyang2@huawei.com,\n cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com,\n heinrich.kuhn@netronome.com, sthotton@marvell.com, srinivasan@marvell.com,\n Steve Yang <stevex.yang@intel.com>", "Date": "Thu, 14 Jan 2021 09:45:01 +0000", "Message-Id": "<20210114094501.13613-1-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201217092312.27033-1-stevex.yang@intel.com>", "References": "<20201217092312.27033-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 00/22] fix rx packets dropped issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this\nfix will change the boundary condition with 'RTE_ETHER_MTU' and overhead.\n\nWhen the MTU(1500) set, the frame type of rx packet will be different\nif used different overhead, it will cause the consistency issue, and the\nnormal packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU'\ncan avoid this issue.\n\nLike,\napp -> max_rx_pkt_len = 1500/*mtu*/ + 22/*overhead*/ = 1522\nethdev -> 1522 > 1518/*MAX*/; max_rx_pkt_len = 1518\ndriver -> MTU = 1518 - 22 = 1496\nPackets with size 1497-1500 are dropped although intention is to be able\nto send/receive them.\n\nFollowing scopes will be changed:\n- 'rte_ethdev'\n- 'app', e.g.: 'test-pmd';\n- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e;\n\nFollowing scopes perhaps will be impacted:\n- the cases of jumbo frame related;\n- the logic of 'max_rx_pkt_len' and 'mtu' related;\n- the using place of 'RTE_ETHER_MAX_LEN';\n\n---\nv3:\n - removed redundant if-conditions in rte_ethdev and testpmd;\n - adjusted the alignment style;\n - added offload check before updating mtu;\nv2:\n - defined the 'RTE_ETHER_MTU + overhead' to 'driver_ETH_MAX_LEN';\n - changed the 'mtu > RTE_ETHER_MTU' to 'frame_size > driver_ETH_MAX_LEN';\n---\n\nSteve Yang (22):\n ethdev: fix MTU size exceeds max rx packet length\n app/testpmd: fix max rx packet length for VLAN packets\n net/dpaa: fix the jumbo frame flag condition for mtu set\n net/dpaa2: fix the jumbo frame flag condition for mtu set\n net/e1000: fix the jumbo frame flag condition for mtu set\n net/hns3: fix the jumbo frame flag condition for mtu set\n net/i40e: fix the jumbo frame flag condition\n net/iavf: fix the jumbo frame flag condition\n net/ice: fix the jumbo frame flag condition\n net/ipn3ke: fix the jumbo frame flag condition for mtu set\n net/octeontx: fix the jumbo frame flag condition for mtu set\n net/octeontx2: fix the jumbo frame flag condition for mtu\n net/qede: fix the jumbo frame flag condition for mtu set\n net/sfc: fix the jumbo frame flag condition for mtu set\n net/thunderx: fix the jumbo frame flag condition for mtu set\n net/ixgbe: fix the jumbo frame flag condition\n net/cxgbe: fix the jumbo frame flag condition\n net/axgbe: fix the jumbo frame flag condition for mtu set\n net/enetc: fix the jumbo frame flag condition for mtu set\n net/hinic: fix the jumbo frame flag condition for mtu set\n net/nfp: fix the jumbo frame flag condition for mtu set\n net/liquidio: fix the jumbo frame flag condition for mtu set\n\n app/test-pmd/cmdline.c | 6 -----\n app/test-pmd/config.c | 2 +-\n app/test-pmd/parameters.c | 7 ++----\n app/test-pmd/testpmd.c | 18 +++++++++++++++\n drivers/net/axgbe/axgbe_ethdev.c | 2 +-\n drivers/net/axgbe/axgbe_ethdev.h | 6 +++++\n drivers/net/cxgbe/cxgbe.h | 4 ++++\n drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++--\n drivers/net/dpaa/dpaa_ethdev.c | 2 +-\n drivers/net/dpaa/dpaa_ethdev.h | 4 ++++\n drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-\n drivers/net/dpaa2/dpaa2_ethdev.h | 4 ++++\n drivers/net/e1000/e1000_ethdev.h | 2 +-\n drivers/net/e1000/em_ethdev.c | 5 ++---\n drivers/net/e1000/igb_ethdev.c | 2 +-\n drivers/net/enetc/enetc.h | 4 ++++\n drivers/net/enetc/enetc_ethdev.c | 2 +-\n drivers/net/hinic/hinic_pmd_ethdev.c | 5 ++++-\n drivers/net/hns3/hns3_ethdev.c | 2 +-\n drivers/net/hns3/hns3_ethdev_vf.c | 2 +-\n drivers/net/i40e/i40e_ethdev.c | 2 +-\n drivers/net/i40e/i40e_ethdev.h | 1 +\n drivers/net/i40e/i40e_ethdev_vf.c | 10 ++++-----\n drivers/net/i40e/i40e_fdir.c | 2 +-\n drivers/net/i40e/i40e_rxtx.c | 8 +++----\n drivers/net/iavf/iavf.h | 1 +\n drivers/net/iavf/iavf_ethdev.c | 10 ++++-----\n drivers/net/ice/ice_dcf_ethdev.c | 8 +++----\n drivers/net/ice/ice_ethdev.c | 2 +-\n drivers/net/ice/ice_ethdev.h | 1 +\n drivers/net/ice/ice_rxtx.c | 10 ++++-----\n drivers/net/ipn3ke/ipn3ke_ethdev.h | 1 +\n drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++\n drivers/net/ixgbe/ixgbe_pf.c | 2 +-\n drivers/net/liquidio/lio_ethdev.c | 2 +-\n drivers/net/liquidio/lio_ethdev.h | 3 +++\n drivers/net/nfp/nfp_net.c | 2 +-\n drivers/net/octeontx/octeontx_ethdev.c | 2 +-\n drivers/net/octeontx/octeontx_ethdev.h | 1 +\n drivers/net/octeontx2/otx2_ethdev.h | 2 ++\n drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +-\n drivers/net/qede/qede_ethdev.c | 2 +-\n drivers/net/qede/qede_rxtx.h | 1 +\n drivers/net/sfc/sfc_ethdev.c | 2 +-\n drivers/net/thunderx/base/nicvf_hw_defs.h | 1 +\n drivers/net/thunderx/nicvf_ethdev.c | 2 +-\n lib/librte_ethdev/rte_ethdev.c | 27 ++++++++++++++++++++---\n 49 files changed, 134 insertions(+), 65 deletions(-)" }