Cover Detail
Show a cover letter.
GET /api/covers/69478/?format=api
{ "id": 69478, "url": "https://patches.dpdk.org/api/covers/69478/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20200428235015.2820677-1-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200428235015.2820677-1-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200428235015.2820677-1-dmitry.kozliuk@gmail.com", "date": "2020-04-28T23:50:07", "name": "[v4,0/8] Windows basic memory management", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20200428235015.2820677-1-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 9713, "url": "https://patches.dpdk.org/api/series/9713/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9713", "date": "2020-04-28T23:50:07", "name": "Windows basic memory management", "version": 4, "mbox": "https://patches.dpdk.org/series/9713/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/69478/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C3CAA00BE;\n\tWed, 29 Apr 2020 01:50:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 393F31D644;\n\tWed, 29 Apr 2020 01:50:25 +0200 (CEST)", "from mail-lj1-f193.google.com (mail-lj1-f193.google.com\n [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id D8E851D640\n for <dev@dpdk.org>; Wed, 29 Apr 2020 01:50:23 +0200 (CEST)", "by mail-lj1-f193.google.com with SMTP id u15so726182ljd.3\n for <dev@dpdk.org>; Tue, 28 Apr 2020 16:50:23 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.googlemail.com with ESMTPSA id g10sm183339lfc.95.2020.04.28.16.50.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2020 16:50:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=VPL3dnPxuwdR5ruYLJW3hSb4AZz5WcrFmVenpuEhzWI=;\n b=bwVNIo/svDLaTW5eZPlxNY6OnI1Qsnrf6uM7/S9GYAFqe0v9NeZVKCjb49xlWwgp3F\n xaywt9n+0ULI53Jc6LeeRlEF2fXk83jZxD9Qtg4q6uKqvmGOWvRXKQLcE3BWygl6mgKU\n 7t4WibxF/tpNCGHPY0NcXqmTVQBxhQrwxOLofqKuDD2qVseSVfAq+yrJWvjqDsr1FkQo\n WgAnl7s54IDogEbPsnjQOEZ3HCGXv50aY/kDZUhnhsGkemI48wUPWo1mOwRrv49Xptrz\n VB2j2a05vSeLjncMmhDHBVs8x+bVXOnyXoqEpn4RUL8rvwk2qme8qkFwtTenUTHPx8nh\n u5zQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=VPL3dnPxuwdR5ruYLJW3hSb4AZz5WcrFmVenpuEhzWI=;\n b=LUlQElmVBtBPTGdsnhsR7/EJ5rrQyYEnVZHCdLTdLvy0dUmVYSJWVrk0TWasTcOrPq\n X3oK+LF72LfMgJcfrgUAxepOwGkMGqJN2jgVvp8gZGMaejM+7OhuWisc7DpTaOQwChWK\n u0W9bXZZJoKAEpKbLGqBEP0PoqwZGTf+1Drr3dc2nt4dx6j9+Tjjmv55GZHmNjmcEQhk\n pZxJ81DYmuizjRuYsb2m7xu4UxQNvs3iJFyU7jBGIzu0cmk8sfVNK5QqAQguDAI30dnG\n kloIadsmcRNKWTsNLOfzqsxl8E0820p13+Y4pw6qXGcW4PDTgJH39tA5N0vuzTnw4qJa\n 4Ffw==", "X-Gm-Message-State": "AGi0PuYc+sNwb6da3j8X8l6gr4iAYzfFHuY68+fJ/Jt863wDa06tIVTL\n AApyC0V1Wb2GVNbztJ+yVedRv9YK", "X-Google-Smtp-Source": "\n APiQypJ4KdSb7+yrALOsADSR/gY2105S8zC1r+tm7pZ8dTyNZVm7XQqZ4ywlId36VksXYog520Yomw==", "X-Received": "by 2002:a2e:b17a:: with SMTP id\n a26mr18045905ljm.215.1588117822696;\n Tue, 28 Apr 2020 16:50:22 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "\"Dmitry Malloy (MESHCHANINOV)\" <dmitrym@microsoft.com>,\n Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,\n Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Date": "Wed, 29 Apr 2020 02:50:07 +0300", "Message-Id": "<20200428235015.2820677-1-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200410164342.1194634-1-dmitry.kozliuk@gmail.com>", "References": "<20200410164342.1194634-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 0/8] Windows basic memory management", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Note: symbols and release notes updated for v20.05, despite this patch\n now targeting v20.08, because proper sections don't yet exist.\n\nThis patchset implements basic MM with the following features:\n\n* Hugepages are dynamically allocated in user-mode.\n* Only 2MB hugepages are supported.\n* IOVA is always PA, obtained through kernel-mode driver.\n* No 32-bit support (presumably not demanded).\n* Ni multi-process support (it is forcefully disabled).\n* No-huge mode for testing with IOVA unavailable.\n\nNew EAL public functions for memory mapping are introduced\nto mitigate OS differences in DPDK libraries and applications:\n\n* rte_mem_map\n* rte_mem_unmap\n* rte_mem_lock\n* rte_get_page_size\n\nTo support common MM routines, internal wrappers for low-level\nmemory reservation and file management are introduced. These changes\naffect Linux and FreeBSD EAL. Shared code is placed unded /unix/\nsubdirectory (suggested by Thomas).\n\nAlso, entire <sys/queue.h> is imported from FreeBSD, replacing existing\npartial import. There is already a license exception for this file.\n\n\nWindows MM duplicates quite a lot of code from Linux EAL:\n\n* eal_memalloc_alloc_seg_bulk\n* eal_memalloc_free_seg_bulk\n* calc_num_pages_per_socket\n* rte_eal_hugepage_init\n\nPerhaps this should be left as-is until Windows MM evolves into having\nsome specific requirements for these parts.\n\n\nNotes on checkpatch warnings:\n\n* No space after comma / no space before closing parent in macros---\n definitely a false-positive, unclear how to suppress this.\n* Issues from imported BSD code---probably should be ignored?\n\n---\n\nv4:\n\n * Rebase on ToT, drop patches merged into master.\n * Rearrange patches to split Windows code (Jerin).\n * Fix Linux and FreeBSD build with make (Ophir).\n * Use int instead of enum to hold a set of flags (Anatoly).\n * Rename eal_mem_reserve items and fix their description (Anatoly).\n * Add eal_mem_set_dump() wrapper around madvise (Anatoly).\n * Don't claim Windows Server 2016 support due to lack of API (Tal).\n * Replace enum rte_page_sizes with a set of #defines (Jerin).\n * Fix documentation, SPDX tags, logging (Thomas).\n\nv3:\n\n * Fix Linux build on and aarch64 and 32-bit x86 (reported by CI).\n * Fix logic and error handling while allocating segments.\n * Fix Unix rte_mem_map(): return NULL on failure.\n * Fix some checkpatch.sh issues:\n * Do not return positive errno, use DWORD for GetLastError().\n * Make dpdk-kmods source files non-executable.\n * Improve GSG for Windows Server (suggested by Ranjit Menon).\n\nv2:\n\n * Rebase on ToT. Move all new code shared between Linux and FreeBSD\n to /unix/ subdirectory, also factor out some existing code there.\n * Improve description of Clang issue with rte_page_sizes on Windows.\n Restore -fstrict-enum for EAL. Check running, not target compiler.\n * Use EAL prefix for private facilities instead if RTE.\n * Improve documentation comments for new functions.\n * Remove co-installer for virt2phys. Add a typecast for clarity.\n * Document virt2phys in user guide, improve its own README.\n * Explicitly and forcefully disable multi-process.\n\n\nDmitry Kozlyuk (8):\n eal: replace rte_page_sizes with a set of constants\n eal: introduce internal wrappers for file operations\n eal: introduce memory management wrappers\n eal: extract common code for memseg list initialization\n eal/windows: replace sys/queue.h with a complete one from FreeBSD\n eal/windows: improve CPU and NUMA node detection\n eal/windows: initialize hugepage info\n eal/windows: implement basic memory management\n\n config/meson.build | 12 +-\n doc/guides/rel_notes/release_20_05.rst | 2 +\n doc/guides/windows_gsg/build_dpdk.rst | 20 -\n doc/guides/windows_gsg/index.rst | 1 +\n doc/guides/windows_gsg/run_apps.rst | 95 ++\n lib/librte_eal/common/eal_common_fbarray.c | 56 +-\n lib/librte_eal/common/eal_common_memory.c | 116 +-\n lib/librte_eal/common/eal_common_memzone.c | 7 +\n lib/librte_eal/common/eal_private.h | 155 ++-\n lib/librte_eal/common/meson.build | 10 +\n lib/librte_eal/common/rte_malloc.c | 9 +\n lib/librte_eal/freebsd/Makefile | 5 +\n lib/librte_eal/freebsd/eal_memory.c | 57 +-\n lib/librte_eal/include/rte_memory.h | 109 +-\n lib/librte_eal/linux/Makefile | 5 +\n lib/librte_eal/linux/eal_memalloc.c | 5 +-\n lib/librte_eal/linux/eal_memory.c | 68 +-\n lib/librte_eal/meson.build | 4 +\n lib/librte_eal/rte_eal_exports.def | 119 ++\n lib/librte_eal/rte_eal_version.map | 4 +\n lib/librte_eal/unix/eal_unix.c | 51 +\n lib/librte_eal/unix/eal_unix_memory.c | 144 ++\n lib/librte_eal/unix/meson.build | 7 +\n lib/librte_eal/windows/eal.c | 158 +++\n lib/librte_eal/windows/eal_hugepages.c | 108 ++\n lib/librte_eal/windows/eal_lcore.c | 185 ++-\n lib/librte_eal/windows/eal_memalloc.c | 418 ++++++\n lib/librte_eal/windows/eal_memory.c | 1155 +++++++++++++++++\n lib/librte_eal/windows/eal_mp.c | 103 ++\n lib/librte_eal/windows/eal_windows.h | 100 ++\n lib/librte_eal/windows/include/meson.build | 1 +\n lib/librte_eal/windows/include/rte_os.h | 4 +\n .../windows/include/rte_virt2phys.h | 34 +\n lib/librte_eal/windows/include/rte_windows.h | 2 +\n lib/librte_eal/windows/include/sys/queue.h | 663 +++++++++-\n lib/librte_eal/windows/include/unistd.h | 3 +\n lib/librte_eal/windows/meson.build | 6 +\n 37 files changed, 3655 insertions(+), 346 deletions(-)\n create mode 100644 doc/guides/windows_gsg/run_apps.rst\n create mode 100644 lib/librte_eal/unix/eal_unix.c\n create mode 100644 lib/librte_eal/unix/eal_unix_memory.c\n create mode 100644 lib/librte_eal/unix/meson.build\n create mode 100644 lib/librte_eal/windows/eal_hugepages.c\n create mode 100644 lib/librte_eal/windows/eal_memalloc.c\n create mode 100644 lib/librte_eal/windows/eal_memory.c\n create mode 100644 lib/librte_eal/windows/eal_mp.c\n create mode 100644 lib/librte_eal/windows/include/rte_virt2phys.h" }