meson: error out on failed kernel module builds
Checks
Commit Message
Now that kernel modules aren't built by default, we can be more
strict with their build process, and fail the build if they were
requested to be built, but weren't.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
kernel/linux/meson.build | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Comments
On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote:
> Now that kernel modules aren't built by default, we can be more
> strict with their build process, and fail the build if they were
> requested to be built, but weren't.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
I think erroring out is the right thing to do, now that modules need to be
explicitly enabled.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
11/05/2020 12:27, Bruce Richardson:
> On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote:
> > Now that kernel modules aren't built by default, we can be more
> > strict with their build process, and fail the build if they were
> > requested to be built, but weren't.
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> I think erroring out is the right thing to do, now that modules need to be
> explicitly enabled.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
@@ -5,8 +5,7 @@ subdirs = ['igb_uio', 'kni']
# if we are cross-compiling we need kernel_dir specified
if get_option('kernel_dir') == '' and meson.is_cross_build()
- warning('Need "kernel_dir" option for kmod compilation when cross-compiling')
- subdir_done()
+ error('Need "kernel_dir" option for kmod compilation when cross-compiling')
endif
kernel_dir = get_option('kernel_dir')
@@ -20,8 +19,7 @@ endif
make_returncode = run_command('make', '-sC', kernel_dir + '/build',
'kernelversion').returncode()
if make_returncode != 0
- warning('Cannot compile kernel modules as requested - are kernel headers installed?')
- subdir_done()
+ error('Cannot compile kernel modules as requested - are kernel headers installed?')
endif
# DO ACTUAL MODULE BUILDING