| Message ID | e41a1a5b087d7bbe93e6bef424637fabb541383e.1545304267.git.anatoly.burakov@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | eal: fix runtime dir cleanup in noshconf mode | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
| ci/mellanox-Performance-Testing | success | Performance Testing PASS |
| ci/intel-Performance-Testing | success | Performance Testing PASS |
20/12/2018 12:11, Anatoly Burakov: > When using --no-shconf or --in-memory modes, there is no runtime > directory to be created, so there is no point in attempting to > clean it. > > Fixes: 0a529578f162 ("eal: clean up unused files on initialization") > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> Applied, thanks
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 41ddb5a22..20f790a71 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c @@ -901,8 +901,11 @@ rte_eal_init(int argc, char **argv) * whether we are primary or secondary process, but we cannot remove * primary process' files because secondary should be able to run even * if primary process is dead. + * + * In no_shconf mode, no runtime directory is created in the first + * place, so no cleanup needed. */ - if (eal_clean_runtime_dir() < 0) { + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) { rte_eal_init_alert("Cannot clear runtime directory\n"); return -1; } diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index d252c8591..acac92987 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -1189,8 +1189,11 @@ rte_eal_init(int argc, char **argv) * whether we are primary or secondary process, but we cannot remove * primary process' files because secondary should be able to run even * if primary process is dead. + * + * In no_shconf mode, no runtime directory is created in the first + * place, so no cleanup needed. */ - if (eal_clean_runtime_dir() < 0) { + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) { rte_eal_init_alert("Cannot clear runtime directory\n"); return -1; }
When using --no-shconf or --in-memory modes, there is no runtime directory to be created, so there is no point in attempting to clean it. Fixes: 0a529578f162 ("eal: clean up unused files on initialization") Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> --- lib/librte_eal/bsdapp/eal/eal.c | 5 ++++- lib/librte_eal/linuxapp/eal/eal.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)