net/i40e: downgrade unnecessary error log
Checks
Commit Message
When receiving the unsupported AQ messages, it's taken as an
error. It's not appropriate and triggers too much unnecessary print.
This commit is similar to commit e130425300b0 ("net/i40e: downgrade
unnecessary error log") which made the same change for the PF instance.
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> wrote:
>
> When receiving the unsupported AQ messages, it's taken as an
> error. It's not appropriate and triggers too much unnecessary print.
>
> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
> unnecessary error log") which made the same change for the PF instance.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index c77b30c54..7b1d485c6 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
> }
> break;
> default:
> - PMD_DRV_LOG(ERR, "Request %u is not supported yet",
> + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
> aq_opc);
> break;
> }
> --
> 2.18.1
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
On 09/12, David Marchand wrote:
>On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> wrote:
>>
>> When receiving the unsupported AQ messages, it's taken as an
>> error. It's not appropriate and triggers too much unnecessary print.
>>
>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>> unnecessary error log") which made the same change for the PF instance.
>>
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>> ---
>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
>> index c77b30c54..7b1d485c6 100644
>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>> }
>> break;
>> default:
>> - PMD_DRV_LOG(ERR, "Request %u is not supported yet",
>> + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
>> aq_opc);
>> break;
>> }
>> --
>> 2.18.1
>>
>
>Reviewed-by: David Marchand <david.marchand@redhat.com>
>
>
>--
>David Marchand
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel.
On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com>
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>> }
>>> break;
>>> default:
>>> - PMD_DRV_LOG(ERR, "Request %u is not
>>> supported yet",
>>> + PMD_DRV_LOG(DEBUG, "Request %u is not
>>> supported yet",
>>> aq_opc);
>>> break;
>>> }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.
Thanks David/Ye
Forgot to include the stable alias to get this in 18.11, sorry Kevin
//Eelco
On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com>
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>> }
>>> break;
>>> default:
>>> - PMD_DRV_LOG(ERR, "Request %u is not
>>> supported yet",
>>> + PMD_DRV_LOG(DEBUG, "Request %u is not
>>> supported yet",
>>> aq_opc);
>>> break;
>>> }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.
On 13/09/2019 10:00, Eelco Chaudron wrote:
> Forgot to include the stable alias to get this in 18.11, sorry Kevin
>
No problem, I'll take a note to backport it and add
Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
> //Eelco
>
> On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
>
>> On 09/12, David Marchand wrote:
>>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com>
>>> wrote:
>>>>
>>>> When receiving the unsupported AQ messages, it's taken as an
>>>> error. It's not appropriate and triggers too much unnecessary print.
>>>>
>>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>>> unnecessary error log") which made the same change for the PF
>>>> instance.
>>>>
>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>>> ---
>>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> index c77b30c54..7b1d485c6 100644
>>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>>> }
>>>> break;
>>>> default:
>>>> - PMD_DRV_LOG(ERR, "Request %u is not
>>>> supported yet",
>>>> + PMD_DRV_LOG(DEBUG, "Request %u is not
>>>> supported yet",
>>>> aq_opc);
>>>> break;
>>>> }
>>>> --
>>>> 2.18.1
>>>>
>>>
>>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>>
>>>
>>> --
>>> David Marchand
>>
>> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>
>> Applied to dpdk-next-net-intel.
@@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
}
break;
default:
- PMD_DRV_LOG(ERR, "Request %u is not supported yet",
+ PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
aq_opc);
break;
}