[dpdk-dev,1/2] pci: deprecate PCI detach

Message ID 4b1edeb12ff61bdb04a0189be30395589c713dbb.1494420483.git.gaetan.rivet@6wind.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Gaëtan Rivet May 10, 2017, 12:52 p.m. UTC
  This patch deprecates the function rte_eal_pci_detach in 17.05,
which will be removed in 17.08.

The generic detach bus method should be used instead.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: Jan Blunck <jblunck@infradead.org>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Thomas Monjalon May 10, 2017, 1:02 p.m. UTC | #1
10/05/2017 14:52, Gaetan Rivet:
> This patch deprecates the function rte_eal_pci_detach in 17.05,
> which will be removed in 17.08.
> 
> The generic detach bus method should be used instead.

Can we wait to have a new generic detach method for deprecating this one?
  
Gaëtan Rivet May 10, 2017, 3:48 p.m. UTC | #2
On Wed, May 10, 2017 at 03:02:51PM +0200, Thomas Monjalon wrote:
>10/05/2017 14:52, Gaetan Rivet:
>> This patch deprecates the function rte_eal_pci_detach in 17.05,
>> which will be removed in 17.08.
>>
>> The generic detach bus method should be used instead.
>
>Can we wait to have a new generic detach method for deprecating this one?

After discussing it with Thomas, this patch has been dropped from this series.
The changes regarding rte_pci_* functions have been postponed to further
DPDK releases and will be discussed later.
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a3e7c72..c2f58eb 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -81,3 +81,9 @@  Deprecation Notices
 
   - ``rte_crpytodev_scheduler_mode_get``, replaced by ``rte_cryptodev_scheduler_mode_get``
   - ``rte_crpytodev_scheduler_mode_set``, replaced by ``rte_cryptodev_scheduler_mode_set``
+
+* pci: The following function is deprecated starting from 17.05 and will be
+  removed in 17.08:
+
+  - ``rte_eal_pci_detach``, replaced by using the corresponding bus generic
+    method ``detach``.