[v3] doc/ipsec_mb: update Arm IPsec-MB library tag

Message ID 20240312173316.2701618-1-jack.bond-preston@foss.arm.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v3] doc/ipsec_mb: update Arm IPsec-MB library tag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Jack Bond-Preston March 12, 2024, 5:33 p.m. UTC
Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
in snow3g and zuc documentation.

Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
---
 .mailmap                         | 1 +
 doc/guides/cryptodevs/snow3g.rst | 2 +-
 doc/guides/cryptodevs/zuc.rst    | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
  

Comments

Akhil Goyal March 14, 2024, 6:50 p.m. UTC | #1
> Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag
> 
> Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
> in snow3g and zuc documentation.
> 
> Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
Is this tag verified in CI?
  
Patrick Robb March 14, 2024, 7:54 p.m. UTC | #2
We are rebuilding from this tag right now. I know the IPSEC update is
now postponed until after 24.03, but once this install is done, do you
want me to issue retests for all the recent patches which had failed
for ARM on this library previously? Then I guess it will be verified
as you say.

On Thu, Mar 14, 2024 at 2:50 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
> > Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag
> >
> > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
> > in snow3g and zuc documentation.
> >
> > Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> > Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> Is this tag verified in CI?
  
Akhil Goyal March 14, 2024, 8:04 p.m. UTC | #3
> Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library
> tag
> 
> We are rebuilding from this tag right now. I know the IPSEC update is
> now postponed until after 24.03, but once this install is done, do you
> want me to issue retests for all the recent patches which had failed
> for ARM on this library previously? Then I guess it will be verified
> as you say.
> 
Yes, IPsec-mb update is postponed.
But, I remember Bryan highlighted an issue in existing library.
Just wanted to check if this tag can be used in the current release or
Are we good without any changes. 

> On Thu, Mar 14, 2024 at 2:50 PM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library
> tag
> > >
> > > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
> > > in snow3g and zuc documentation.
> > >
> > > Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> > > Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> > Is this tag verified in CI?
  
Patrick Robb March 15, 2024, 6:17 p.m. UTC | #4
On Thu, Mar 14, 2024 at 4:04 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
>
>
> > Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library
> > tag
> >
> > We are rebuilding from this tag right now. I know the IPSEC update is
> > now postponed until after 24.03, but once this install is done, do you
> > want me to issue retests for all the recent patches which had failed
> > for ARM on this library previously? Then I guess it will be verified
> > as you say.
> >
> Yes, IPsec-mb update is postponed.
> But, I remember Bryan highlighted an issue in existing library.
> Just wanted to check if this tag can be used in the current release or
> Are we good without any changes.

Okay, triggered a DPDK main "periodic run" on the CI now that we are
running from SECLIB-IPSEC-2024.03.12 and I see it passed. So it looks
like this tag can be used with the current release.

Otherwise, I will take the opportunity to just trigger retests for all
series which failed the crypto tests on ARM in recent weeks, just so
we know whether the new library makes a difference (it should), even
though the new requirement won't go through.
  
Akhil Goyal March 22, 2024, 7:38 p.m. UTC | #5
> > > Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB
> library
> > > tag
> > >
> > > We are rebuilding from this tag right now. I know the IPSEC update is
> > > now postponed until after 24.03, but once this install is done, do you
> > > want me to issue retests for all the recent patches which had failed
> > > for ARM on this library previously? Then I guess it will be verified
> > > as you say.
> > >
> > Yes, IPsec-mb update is postponed.
> > But, I remember Bryan highlighted an issue in existing library.
> > Just wanted to check if this tag can be used in the current release or
> > Are we good without any changes.
> 
> Okay, triggered a DPDK main "periodic run" on the CI now that we are
> running from SECLIB-IPSEC-2024.03.12 and I see it passed. So it looks
> like this tag can be used with the current release.
> 
> Otherwise, I will take the opportunity to just trigger retests for all
> series which failed the crypto tests on ARM in recent weeks, just so
> we know whether the new library makes a difference (it should), even
> though the new requirement won't go through.

Thanks Patrick for testing this out.

Applied to dpdk-next-crypto
  

Patch

diff --git a/.mailmap b/.mailmap
index 58cca13ef6..ac90b71a04 100644
--- a/.mailmap
+++ b/.mailmap
@@ -574,6 +574,7 @@  Jacek Bułatek <jacekx.bulatek@intel.com>
 Jacek Naczyk <jacek.naczyk@intel.com>
 Jacek Piasecki <jacekx.piasecki@intel.com>
 Jacek Siuda <jck@semihalf.com>
+Jack Bond-Preston <jack.bond-preston@arm.com> <jack.bond-preston@foss.arm.com>
 Jacob Keller <jacob.e.keller@intel.com>
 Jakub Chylkowski <jakubx.chylkowski@intel.com>
 Jakub Grajciar <jgrajcia@cisco.com>
diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst
index 3392932653..9c00aa03fa 100644
--- a/doc/guides/cryptodevs/snow3g.rst
+++ b/doc/guides/cryptodevs/snow3g.rst
@@ -54,7 +54,7 @@  can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2024.03.12.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst
index a414b5ad2c..49a5eada46 100644
--- a/doc/guides/cryptodevs/zuc.rst
+++ b/doc/guides/cryptodevs/zuc.rst
@@ -53,7 +53,7 @@  can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2024.03.12.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK: