diff mbox series

test/crypto: fix non ASCII character

Message ID 20240305113428.365-1-anoobj@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series test/crypto: fix non ASCII character |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Anoob Joseph March 5, 2024, 11:34 a.m. UTC 
  Fix non ASCII character in the comment. Revert to original text.

Bugzilla ID: 1396
Fixes: f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ali Alnubani March 5, 2024, 12:14 p.m. UTC | #1 
> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Tuesday, March 5, 2024 1:34 PM
> To: Akhil Goyal <gakhil@marvell.com>; David Marchand
> <david.marchand@redhat.com>
> Cc: Aakash Sasidharan <asasidharan@marvell.com>; dev@dpdk.org
> Subject: [PATCH] test/crypto: fix non ASCII character
> 
> Fix non ASCII character in the comment. Revert to original text.
> 
> Bugzilla ID: 1396
> Fixes: f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---

Build passes with this patch, thanks!

Tested-by: Ali Alnubani <alialnu@nvidia.com>
Thomas Monjalon March 5, 2024, 1:25 p.m. UTC | #2 
05/03/2024 13:14, Ali Alnubani:
> > Subject: [PATCH] test/crypto: fix non ASCII character
> > 
> > Fix non ASCII character in the comment. Revert to original text.
> > 
> > Bugzilla ID: 1396
> > Fixes: f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
> > 
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> 
> Build passes with this patch, thanks!
> 
> Tested-by: Ali Alnubani <alialnu@nvidia.com>

Reported-by: Ali Alnubani <alialnu@nvidia.com>

Applied, thanks.


The script buildtools/get-test-suites.py is not tolerant with Unicode.
We may be more flexible probably.
Bruce, Robin, what do you think about allowing Unicode characters in this script?
David Marchand March 5, 2024, 1:27 p.m. UTC | #3 
On Tue, Mar 5, 2024 at 2:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 05/03/2024 13:14, Ali Alnubani:
> > > Subject: [PATCH] test/crypto: fix non ASCII character
> > >
> > > Fix non ASCII character in the comment. Revert to original text.
> > >
> > > Bugzilla ID: 1396
> > > Fixes: f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
> > >
> > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > ---
> >
> > Build passes with this patch, thanks!
> >
> > Tested-by: Ali Alnubani <alialnu@nvidia.com>
>
> Reported-by: Ali Alnubani <alialnu@nvidia.com>
>
> Applied, thanks.
>
>
> The script buildtools/get-test-suites.py is not tolerant with Unicode.
> We may be more flexible probably.
> Bruce, Robin, what do you think about allowing Unicode characters in this script?

Note: I could reproduce this issue with a Ubuntu 18.04 container, but
not with my fedora 38.
Maybe something to do with a python version.. ?
Robin Jarry March 5, 2024, 1:29 p.m. UTC | #4 
David Marchand, Mar 05, 2024 at 14:27:
> > The script buildtools/get-test-suites.py is not tolerant with Unicode.
> > We may be more flexible probably.
> > Bruce, Robin, what do you think about allowing Unicode characters in this script?
>
> Note: I could reproduce this issue with a Ubuntu 18.04 container, but
> not with my fedora 38.
> Maybe something to do with a python version.. ?

The files are opened without specifying an encoding. So it depends on 
the LC_ALL environment variable.

https://git.dpdk.org/dpdk/tree/buildtools/get-test-suites.py#n22

I will send a patch to fix this.
diff mbox series

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c3c3f587b4..754fab39c5 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -1615,7 +1615,7 @@  ext_mbuf_create(struct rte_mempool *mbuf_pool, int pkt_len,
 			goto fail;
 		}
 
-		/* Save shared data (like callback function) in external buffer’s end */
+		/* Save shared data (like callback function) in external buffer's end */
 		ret_shinfo = rte_pktmbuf_ext_shinfo_init_helper(ext_buf_addr, &buf_len,
 			ext_mbuf_callback_fn_free, &freed);
 		if (ret_shinfo == NULL) {