ml/cnxk: remove unused memory barrier macros

Message ID 20240207033605.1106673-1-honnappa.nagarahalli@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series ml/cnxk: remove unused memory barrier macros |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-unit-amd64-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Honnappa Nagarahalli Feb. 7, 2024, 3:36 a.m. UTC
  The dmb_st abd dsb_st macros are not used in the code.
Remove them to avoid any confusion.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
 drivers/ml/cnxk/cn10k_ml_dev.h | 9 ---------
 1 file changed, 9 deletions(-)
  

Comments

Srikanth Yalavarthi Feb. 7, 2024, 5:24 a.m. UTC | #1
Addressed
> -----Original Message-----
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Sent: Wednesday, February 7, 2024 9:06 AM
> To: dev@dpdk.org; Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; nd@arm.com; Honnappa Nagarahalli
> <honnappa.nagarahalli@arm.com>
> Subject: [EXT] [PATCH] ml/cnxk: remove unused memory barrier macros
> 
> The dmb_st abd dsb_st macros are not used in the code.
> Remove them to avoid any confusion.
> 
> Signed-off-by: Honnappa Nagarahalli <mailto:honnappa.nagarahalli@arm.com>

Acked-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
  
Jerin Jacob Feb. 9, 2024, 7:21 a.m. UTC | #2
On Wed, Feb 7, 2024 at 11:10 AM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> > -----Original Message-----
> > From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Sent: Wednesday, February 7, 2024 9:06 AM
> > To: dev@dpdk.org; Srikanth Yalavarthi <syalavarthi@marvell.com>
> > Cc: Jerin Jacob <jerinj@marvell.com>; nd@arm.com; Honnappa Nagarahalli
> > <honnappa.nagarahalli@arm.com>
> > Subject: [EXT] [PATCH] ml/cnxk: remove unused memory barrier macros
> >
> > The dmb_st abd dsb_st macros are not used in the code.
> > Remove them to avoid any confusion.
> >
> > Signed-off-by: Honnappa Nagarahalli <mailto:honnappa.nagarahalli@arm.com>
>
> Acked-by: Srikanth Yalavarthi <syalavarthi@marvell.com>


Applied to dpdk-next-net-mrvl/for-main. Thanks
  

Patch

diff --git a/drivers/ml/cnxk/cn10k_ml_dev.h b/drivers/ml/cnxk/cn10k_ml_dev.h
index cee405f3f5..ddb8b67e06 100644
--- a/drivers/ml/cnxk/cn10k_ml_dev.h
+++ b/drivers/ml/cnxk/cn10k_ml_dev.h
@@ -42,15 +42,6 @@  extern struct rte_ml_dev_ops ml_dev_dummy_ops;
 #define ML_CN10K_SP_FLAGS_OCM_NONRELOCATABLE BIT(0)
 #define ML_CN10K_SP_FLAGS_EXTENDED_LOAD_JD   BIT(1)
 
-/* Memory barrier macros */
-#if defined(RTE_ARCH_ARM)
-#define dmb_st ({ asm volatile("dmb st" : : : "memory"); })
-#define dsb_st ({ asm volatile("dsb st" : : : "memory"); })
-#else
-#define dmb_st
-#define dsb_st
-#endif
-
 struct cnxk_ml_dev;
 struct cnxk_ml_req;
 struct cnxk_ml_qp;