[v6,12/20] crypto/armv8: do not use PMD logtype

Message ID 20231222171820.8778-13-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Remove uses of PMD logtype |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Stephen Hemminger Dec. 22, 2023, 5:11 p.m. UTC
  Driver already has logging macros, just not used in one place.

Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/crypto/armv8/rte_armv8_pmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Stephen Hemminger Dec. 22, 2023, 5:42 p.m. UTC | #1
On Fri, 22 Dec 2023 09:11:45 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

>  
> -	RTE_LOG(INFO, PMD,
> -		"Closing ARMv8 crypto device %s on numa socket %u\n",
> +	ARVM8_CRYTPO_LOG_INFO(
> +		"Closing ARMv8 crypto device %s on numa socket %u",
>  		name, rte_socket_id

Typo here will fix in next version
  
Ruifeng Wang Dec. 26, 2023, 3:04 a.m. UTC | #2
On 2023/12/23 1:42 AM, Stephen Hemminger wrote:
> On Fri, 22 Dec 2023 09:11:45 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
>>   
>> -	RTE_LOG(INFO, PMD,
>> -		"Closing ARMv8 crypto device %s on numa socket %u\n",
>> +	ARVM8_CRYTPO_LOG_INFO(
>> +		"Closing ARMv8 crypto device %s on numa socket %u",
>>   		name, rte_socket_id
> 
> Typo here will fix in next version

Thanks for the effort.

With change ARVM8_CRYTPO_LOG_INFO -> ARMV8_CRYPTO_LOG_INFO,
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
  

Patch

diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index 824a2cc7352a..3b7f45b46c33 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -833,8 +833,8 @@  cryptodev_armv8_crypto_uninit(struct rte_vdev_device *vdev)
 	if (name == NULL)
 		return -EINVAL;
 
-	RTE_LOG(INFO, PMD,
-		"Closing ARMv8 crypto device %s on numa socket %u\n",
+	ARVM8_CRYTPO_LOG_INFO(
+		"Closing ARMv8 crypto device %s on numa socket %u",
 		name, rte_socket_id());
 
 	cryptodev = rte_cryptodev_pmd_get_named_dev(name);