diff mbox series

[v4,10/17] crypto/caam_jr: use dedicated logtype

Message ID 20231218192631.699267-11-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Replace uses of RTE_LOGTYPE_PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Dec. 18, 2023, 7:22 p.m. UTC 
  The driver has macro and logtype but not used in a couple places.

Fixes: af7c9b5e9ce7 ("crypto/caam_jr: introduce basic driver")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/crypto/caam_jr/caam_jr.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comments

David Marchand Dec. 21, 2023, 9:38 a.m. UTC | #1 
On Mon, Dec 18, 2023 at 8:28 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The driver has macro and logtype but not used in a couple places.
>
> Fixes: af7c9b5e9ce7 ("crypto/caam_jr: introduce basic driver")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

CAAM_JR log macros add a \n, please remove them from the format
strings when converting.
diff mbox series

Patch

diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index b55258689b49..7b42ca529e9f 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -309,7 +309,7 @@  caam_jr_prep_cdb(struct caam_jr_session *ses)
 
 	cdb = caam_jr_dma_mem_alloc(L1_CACHE_BYTES, sizeof(struct sec_cdb));
 	if (!cdb) {
-		CAAM_JR_ERR("failed to allocate memory for cdb\n");
+		CAAM_JR_ERR("failed to allocate memory for cdb");
 		return -1;
 	}
 
@@ -2346,7 +2346,7 @@  caam_jr_dev_init(const char *name,
 
 	rte_cryptodev_pmd_probing_finish(dev);
 
-	RTE_LOG(INFO, PMD, "%s cryptodev init\n", dev->data->name);
+	CAAM_JR_INFO("%s cryptodev init\n", dev->data->name);
 
 	return 0;
 
@@ -2386,8 +2386,7 @@  cryptodev_caam_jr_probe(struct rte_vdev_device *vdev)
 
 	ret = of_init();
 	if (ret) {
-		RTE_LOG(ERR, PMD,
-		"of_init failed\n");
+		CAAM_JR_ERR("of_init failed\n");
 		return -EINVAL;
 	}
 	/* if sec device version is not configured */
@@ -2407,8 +2406,7 @@  cryptodev_caam_jr_probe(struct rte_vdev_device *vdev)
 	}
 #ifdef RTE_LIBRTE_PMD_CAAM_JR_BE
 	if (rta_get_sec_era() > RTA_SEC_ERA_8) {
-		RTE_LOG(ERR, PMD,
-		"CAAM is compiled in BE mode for device with sec era > 8???\n");
+		CAAM_JR_ERR("CAAM is compiled in BE mode for device with sec era > 8???\n");
 		return -EINVAL;
 	}
 #endif