[v4,2/2] config/arm: use common cpu arch for cross files
Checks
Commit Message
The cpu info in some cross files is inconsistent with
that in SoC flags. The mismatch doesn't cause any issue
because the cpu field in the cross file takes no effect
and machine_args in config/arm/meson.build actually works.
Use a common one in cross files to remove any confusion.
Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/arm/arm32_armv8_linux_gcc | 2 +-
config/arm/arm64_altra_linux_gcc | 2 +-
config/arm/arm64_ampereone_linux_gcc | 2 +-
config/arm/arm64_armada_linux_gcc | 2 +-
config/arm/arm64_armv8_linux_clang_ubuntu | 2 +-
config/arm/arm64_armv8_linux_gcc | 2 +-
config/arm/arm64_bluefield3_linux_gcc | 2 +-
config/arm/arm64_bluefield_linux_gcc | 2 +-
config/arm/arm64_cdx_linux_gcc | 2 +-
config/arm/arm64_centriq2400_linux_gcc | 2 +-
config/arm/arm64_cn10k_linux_gcc | 2 +-
config/arm/arm64_cn9k_linux_gcc | 2 +-
config/arm/arm64_dpaa_linux_gcc | 2 +-
config/arm/arm64_emag_linux_gcc | 2 +-
config/arm/arm64_ft2000plus_linux_gcc | 2 +-
config/arm/arm64_graviton2_linux_gcc | 2 +-
config/arm/arm64_graviton3_linux_gcc | 2 +-
config/arm/arm64_hip10_linux_gcc | 2 +-
config/arm/arm64_kunpeng920_linux_gcc | 2 +-
config/arm/arm64_kunpeng930_linux_gcc | 2 +-
config/arm/arm64_n1sdp_linux_gcc | 2 +-
config/arm/arm64_n2_linux_gcc | 2 +-
config/arm/arm64_stingray_linux_gcc | 2 +-
config/arm/arm64_thunderx2_linux_gcc | 2 +-
config/arm/arm64_thunderxt83_linux_gcc | 2 +-
config/arm/arm64_thunderxt88_linux_gcc | 2 +-
config/arm/arm64_tys2500_linux_gcc | 2 +-
27 files changed, 27 insertions(+), 27 deletions(-)
Comments
On Tue, 5 Dec 2023 03:52:59 +0000
Joyce Kong <joyce.kong@arm.com> wrote:
> The cpu info in some cross files is inconsistent with
> that in SoC flags. The mismatch doesn't cause any issue
> because the cpu field in the cross file takes no effect
> and machine_args in config/arm/meson.build actually works.
> Use a common one in cross files to remove any confusion.
>
> Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Good to see consolidation instead of copy/paste.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, December 8, 2023 4:12 AM
> To: Joyce Kong <joyce.kong@arm.com>
> Cc: thomas@monjalon.net; ruifeng.wang@arm.com;
> bruce.richardson@intel.com; dev@dpdk.org; nd@arm.com; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>
> Subject: [EXT] Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross
> files
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, 5 Dec 2023 03:52:59 +0000
> Joyce Kong <joyce.kong@arm.com> wrote:
>
> > The cpu info in some cross files is inconsistent with
> > that in SoC flags. The mismatch doesn't cause any issue
> > because the cpu field in the cross file takes no effect
> > and machine_args in config/arm/meson.build actually works.
> > Use a common one in cross files to remove any confusion.
> >
> > Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Good to see consolidation instead of copy/paste.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Tested-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
05/12/2023 04:52, Joyce Kong:
> The cpu info in some cross files is inconsistent with
> that in SoC flags. The mismatch doesn't cause any issue
> because the cpu field in the cross file takes no effect
> and machine_args in config/arm/meson.build actually works.
> Use a common one in cross files to remove any confusion.
>
> Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
[...]
> --- a/config/arm/arm64_armada_linux_gcc
> +++ b/config/arm/arm64_armada_linux_gcc
> @@ -10,7 +10,7 @@ pcap-config = ''
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'aarch64'
Why aarch64 here and below?
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu
> @@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'auto'
[...]
> --- a/config/arm/arm64_hip10_linux_gcc
> +++ b/config/arm/arm64_hip10_linux_gcc
> @@ -9,7 +9,7 @@ pcap-config = ''
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'aarch64'
Hi Thomas,
> > [host_machine]
> > system = 'linux'
> > cpu_family = 'aarch64'
> > -cpu = 'armv8-a'
> > +cpu = 'aarch64'
>
> Why aarch64 here and below?
Joyce is no longer with Arm, and we have not been able to figure out
this patch. I think the first patch of this series makes sense.
This second patch to us looks like a nice to have, rather than something
that fixes an issue. Therefore, we would like to pull this patch out of the
series and leave first patch intact.
Any concerns/comments on that?
>
> > --- a/config/arm/arm64_armv8_linux_clang_ubuntu
> > +++ b/config/arm/arm64_armv8_linux_clang_ubuntu
> > @@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > [host_machine]
> > system = 'linux'
> > cpu_family = 'aarch64'
> > -cpu = 'armv8-a'
> > +cpu = 'auto'
>
> [...]
> > --- a/config/arm/arm64_hip10_linux_gcc
> > +++ b/config/arm/arm64_hip10_linux_gcc
> > @@ -9,7 +9,7 @@ pcap-config = ''
> > [host_machine]
> > system = 'linux'
> > cpu_family = 'aarch64'
> > -cpu = 'armv8-a'
> > +cpu = 'aarch64'
>
>
22/02/2024 22:38, Wathsala Wathawana Vithanage:
> Hi Thomas,
>
> > > [host_machine]
> > > system = 'linux'
> > > cpu_family = 'aarch64'
> > > -cpu = 'armv8-a'
> > > +cpu = 'aarch64'
> >
> > Why aarch64 here and below?
>
> Joyce is no longer with Arm, and we have not been able to figure out
> this patch. I think the first patch of this series makes sense.
> This second patch to us looks like a nice to have, rather than something
> that fixes an issue. Therefore, we would like to pull this patch out of the
> series and leave first patch intact.
> Any concerns/comments on that?
OK
What will become this second patch?
> > Joyce is no longer with Arm, and we have not been able to figure out
> > this patch. I think the first patch of this series makes sense.
> > This second patch to us looks like a nice to have, rather than
> > something that fixes an issue. Therefore, we would like to pull this
> > patch out of the series and leave first patch intact.
> > Any concerns/comments on that?
>
> OK
> What will become this second patch?
>
I will suppress patch 2/2.
Thanks.
> >
> > OK
> > What will become this second patch?
> >
> I will suppress patch 2/2.
> Thanks.
I'm not allowed to suppress it, perhaps someone with admin privileges could do it.
06/03/2024 16:04, Wathsala Wathawana Vithanage:
> > >
> > > OK
> > > What will become this second patch?
> > >
> > I will suppress patch 2/2.
> > Thanks.
> I'm not allowed to suppress it, perhaps someone with admin privileges could do it.
We don't suppress anything :)
I can change the status to rejected but why not continuing this cleanup?
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch32'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.2-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'aarch64'
endian = 'little'
[properties]
@@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.4-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'aarch64'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]