diff mbox series

[v3] app/testpmd: fix indirect action list ID size

Message ID 20231110070437.517715-1-getelson@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v3] app/testpmd: fix indirect action list ID size |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Gregory Etelson Nov. 10, 2023, 7:04 a.m. UTC 
  Testpmd maps indirect action lists handlers into application IDs.
Testpmd API defines indirect IDs as 32 bits values.

The patch fixes indirect IDs size in  ACTION_INDIRECT_LIST_HANDLE
and ACTION_INDIRECT_LIST_CONF tokens

Fixes: 72a3dec7126f ("ethdev: add indirect flow list action")
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
v2: define `id` as uintptr_t
v3: define indirect ID size as 32 bits
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Nov. 10, 2023, 11:40 p.m. UTC | #1 
On 11/10/2023 7:04 AM, Gregory Etelson wrote:
> Testpmd maps indirect action lists handlers into application IDs.
> Testpmd API defines indirect IDs as 32 bits values.
> 
> The patch fixes indirect IDs size in  ACTION_INDIRECT_LIST_HANDLE
> and ACTION_INDIRECT_LIST_CONF tokens
> 
> Fixes: 72a3dec7126f ("ethdev: add indirect flow list action")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 0d521159e9..ce71818705 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -7383,13 +7383,13 @@  static const struct token token_list[] = {
 		.name = "handle",
 		.help = "indirect list handle",
 		.next = NEXT(next_ial, NEXT_ENTRY(INDIRECT_LIST_ACTION_ID2PTR_HANDLE)),
-		.args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uintptr_t))),
+		.args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uint32_t))),
 	},
 	[ACTION_INDIRECT_LIST_CONF] = {
 		.name = "conf",
 		.help = "indirect list configuration",
 		.next = NEXT(next_ial, NEXT_ENTRY(INDIRECT_LIST_ACTION_ID2PTR_CONF)),
-		.args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uintptr_t))),
+		.args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uint32_t))),
 	},
 	[INDIRECT_LIST_ACTION_ID2PTR_HANDLE] = {
 		.type = "UNSIGNED",