diff mbox series

[v7,23/25] node: remove some of the experimental tags

Message ID 20231024025422.126021-24-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series Promote 22.11 and older API's to stable |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Oct. 24, 2023, 2:54 a.m. UTC 
  The node library has been around long enough that experimental
tag should be removed.  The IPv6 support was added in 23.03
but that is still enough time that it can be marked stable.

The logtype variable should have been marked internal
since it is not intended to be used outside of library.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 MAINTAINERS                 |  2 +-
 lib/node/rte_node_eth_api.h |  1 -
 lib/node/rte_node_ip4_api.h |  2 --
 lib/node/version.map        | 16 ++++++++++++----
 4 files changed, 13 insertions(+), 8 deletions(-)

Comments

David Marchand Nov. 12, 2023, 2:58 p.m. UTC | #1 
On Tue, Oct 24, 2023 at 4:57 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The node library has been around long enough that experimental
> tag should be removed.  The IPv6 support was added in 23.03
> but that is still enough time that it can be marked stable.
>
> The logtype variable should have been marked internal
> since it is not intended to be used outside of library.

There is, even, no need to export this symbol in the first place.

$ git grep -lw rte_node_logtype
lib/node/log.c
lib/node/node_private.h

$ git grep -lw node_private.h '**.h'


We only need to remove rte_node_logtype from version.map.
This can be fixed when applying.

>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Jerin Jacob Nov. 13, 2023, 10:07 a.m. UTC | #2 
On Sun, Nov 12, 2023 at 8:29 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Oct 24, 2023 at 4:57 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The node library has been around long enough that experimental
> > tag should be removed.  The IPv6 support was added in 23.03
> > but that is still enough time that it can be marked stable.
> >
> > The logtype variable should have been marked internal
> > since it is not intended to be used outside of library.
>
> There is, even, no need to export this symbol in the first place.
>
> $ git grep -lw rte_node_logtype
> lib/node/log.c
> lib/node/node_private.h
>
> $ git grep -lw node_private.h '**.h'
>
>
> We only need to remove rte_node_logtype from version.map.
> This can be fixed when applying.
>
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Jerin Jacob <jerinj@marvell.com>


>
>
> --
> David Marchand
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 789507ddccb7..f6ea602da41f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1735,7 +1735,7 @@  F: app/test/test_graph*
 F: examples/l3fwd-graph/
 F: doc/guides/sample_app_ug/l3_forward_graph.rst
 
-Nodes - EXPERIMENTAL
+Nodes
 M: Nithin Dabilpuram <ndabilpuram@marvell.com>
 M: Pavan Nikhilesh <pbhagavatula@marvell.com>
 F: lib/node/
diff --git a/lib/node/rte_node_eth_api.h b/lib/node/rte_node_eth_api.h
index 40b2021f01f9..eaae50772dbe 100644
--- a/lib/node/rte_node_eth_api.h
+++ b/lib/node/rte_node_eth_api.h
@@ -55,7 +55,6 @@  struct rte_node_ethdev_config {
  * @return
  *   0 on successful initialization, negative otherwise.
  */
-__rte_experimental
 int rte_node_eth_config(struct rte_node_ethdev_config *cfg,
 			uint16_t cnt, uint16_t nb_graphs);
 #ifdef __cplusplus
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index a84dbb3b5499..24f8ec843a27 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -82,7 +82,6 @@  struct rte_node_ip4_reassembly_cfg {
  * @return
  *   0 on success, negative otherwise.
  */
-__rte_experimental
 int rte_node_ip4_route_add(uint32_t ip, uint8_t depth, uint16_t next_hop,
 			   enum rte_node_ip4_lookup_next next_node);
 
@@ -101,7 +100,6 @@  int rte_node_ip4_route_add(uint32_t ip, uint8_t depth, uint16_t next_hop,
  * @return
  *   0 on success, negative otherwise.
  */
-__rte_experimental
 int rte_node_ip4_rewrite_add(uint16_t next_hop, uint8_t *rewrite_data,
 			     uint8_t rewrite_len, uint16_t dst_port);
 
diff --git a/lib/node/version.map b/lib/node/version.map
index 3855569228e3..59c72ca76fd3 100644
--- a/lib/node/version.map
+++ b/lib/node/version.map
@@ -1,11 +1,15 @@ 
-EXPERIMENTAL {
+DPDK_24 {
 	global:
 
-	# added in 20.05
 	rte_node_eth_config;
 	rte_node_ip4_route_add;
 	rte_node_ip4_rewrite_add;
-	rte_node_logtype;
+
+	local: *;
+};
+
+EXPERIMENTAL {
+	global:
 
 	# added in 23.07
 	rte_node_ip6_rewrite_add;
@@ -15,6 +19,10 @@  EXPERIMENTAL {
 	rte_node_ip4_reassembly_configure;
 	rte_node_udp4_dst_port_add;
 	rte_node_udp4_usr_node_add;
+};
 
-	local: *;
+INTERNAL {
+	global:
+
+	rte_node_logtype;
 };