diff mbox series

net/virtio: fixed missing next flag when sending packets in packed mode

Message ID 20231017072623.527-1-liufengjiang.0426@bytedance.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series net/virtio: fixed missing next flag when sending packets in packed mode |

Checks

Context Check Description
ci/loongarch-compilation success Compilation OK
ci/checkpatch success coding style OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Fengjiang Liu Oct. 17, 2023, 7:26 a.m. UTC 
  When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc

Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")

Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
---
 drivers/net/virtio/virtqueue.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Maxime Coquelin Oct. 17, 2023, 7:32 a.m. UTC | #1 
Hi,

On 10/17/23 09:26, Fengjiang Liu wrote:
> When the packets is sent in packed mode, and the packets data and
> virtio-header are divided into two desc, set the next flag of
> virtio-header desc
> 
> Bugzilla ID: 1295
> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
> 
> Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
> ---
>   drivers/net/virtio/virtqueue.h | 1 +
>   1 file changed, 1 insertion(+)
> 

No need to resend so many new versions :)
(For new patches, don't forget to increase the revision number).

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin Oct. 25, 2023, 12:24 p.m. UTC | #2 
On 10/17/23 09:26, Fengjiang Liu wrote:
> When the packets is sent in packed mode, and the packets data and
> virtio-header are divided into two desc, set the next flag of
> virtio-header desc
> 
> Bugzilla ID: 1295
> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
> 
> Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
> ---
>   drivers/net/virtio/virtqueue.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index 9d4aba11a3..4e9f2d0358 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
>   		 */
>   		start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
>   		start_dp[idx].len = vq->hw->vtnet_hdr_size;
> +		head_flags |= VRING_DESC_F_NEXT;
>   		hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
>   		idx++;
>   		if (idx >= vq->vq_nentries) {

Applied to next-virtio/for-next-net

Thanks,
Maxime
diff mbox series

Patch

diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 9d4aba11a3..4e9f2d0358 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -672,6 +672,7 @@  virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
 		 */
 		start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
 		start_dp[idx].len = vq->hw->vtnet_hdr_size;
+		head_flags |= VRING_DESC_F_NEXT;
 		hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
 		idx++;
 		if (idx >= vq->vq_nentries) {