diff mbox series

[v4,1/2] doc: increase python max line length to 100

Message ID 20231013075805.169446-1-juraj.linkes@pantheon.tech (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v4,1/2] doc: increase python max line length to 100 |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Juraj Linkeš Oct. 13, 2023, 7:58 a.m. UTC 
  Unify with C recommendations which allow line length of up to 100
characters.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .editorconfig                            | 2 +-
 doc/doc_build/meson-private/meson.lock   | 0
 doc/guides/contributing/coding_style.rst | 1 +
 dts/pyproject.toml                       | 4 ++--
 4 files changed, 4 insertions(+), 3 deletions(-)
 create mode 100644 doc/doc_build/meson-private/meson.lock

Comments

Stephen Hemminger Oct. 13, 2023, 4:09 p.m. UTC | #1 
On Fri, 13 Oct 2023 09:58:04 +0200
Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:

> Unify with C recommendations which allow line length of up to 100
> characters.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  .editorconfig                            | 2 +-
>  doc/doc_build/meson-private/meson.lock   | 0
>  doc/guides/contributing/coding_style.rst | 1 +
>  dts/pyproject.toml                       | 4 ++--
>  4 files changed, 4 insertions(+), 3 deletions(-)
>  create mode 100644 doc/doc_build/meson-private/meson.loc

Look like meson.lock snuck into this patchset.
Assume that was a mistake.
Juraj Linkeš Oct. 16, 2023, 6:44 a.m. UTC | #2 
On Fri, Oct 13, 2023 at 6:09 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 13 Oct 2023 09:58:04 +0200
> Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> > Unify with C recommendations which allow line length of up to 100
> > characters.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  .editorconfig                            | 2 +-
> >  doc/doc_build/meson-private/meson.lock   | 0
> >  doc/guides/contributing/coding_style.rst | 1 +
> >  dts/pyproject.toml                       | 4 ++--
> >  4 files changed, 4 insertions(+), 3 deletions(-)
> >  create mode 100644 doc/doc_build/meson-private/meson.loc
>
> Look like meson.lock snuck into this patchset.
> Assume that was a mistake.

My bad, let me send a fix.
diff mbox series

Patch

diff --git a/.editorconfig b/.editorconfig
index ab41c95085..1e7d74213f 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -16,7 +16,7 @@  max_line_length = 100
 [*.py]
 indent_style = space
 indent_size = 4
-max_line_length = 79
+max_line_length = 100
 
 [meson.build]
 indent_style = space
diff --git a/doc/doc_build/meson-private/meson.lock b/doc/doc_build/meson-private/meson.lock
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index 648849899d..1ebc79ca3c 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -880,6 +880,7 @@  All Python code should be compliant with
 `PEP8 (Style Guide for Python Code) <https://www.python.org/dev/peps/pep-0008/>`_.
 
 The ``pep8`` tool can be used for testing compliance with the guidelines.
+Note that line lengths are acceptable up to 100 characters, which is in line with C recommendations.
 
 Integrating with the Build System
 ---------------------------------
diff --git a/dts/pyproject.toml b/dts/pyproject.toml
index 6762edfa6b..980ac3c7db 100644
--- a/dts/pyproject.toml
+++ b/dts/pyproject.toml
@@ -41,7 +41,7 @@  build-backend = "poetry.core.masonry.api"
 [tool.pylama]
 linters = "mccabe,pycodestyle,pyflakes"
 format = "pylint"
-max_line_length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
+max_line_length = 100
 
 [tool.mypy]
 python_version = "3.10"
@@ -55,4 +55,4 @@  profile = "black"
 [tool.black]
 target-version = ['py310']
 include = '\.pyi?$'
-line-length = 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
+line-length = 100