diff mbox series

[v3,1/2] app/testpmd: fix help string

Message ID 20231008015630.406378-2-huangdengdui@huawei.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series fix help string and add a new command |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Dengdui Huang Oct. 8, 2023, 1:56 a.m. UTC 
  Command help string is missing 'mcast_addr add|remove'.
This patch add it.

Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")
Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
 app/test-pmd/cmdline.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

fengchengwen Oct. 8, 2023, 2:47 a.m. UTC | #1 
Hi Dengdui,

On 2023/10/8 9:56, Dengdui Huang wrote:
> Command help string is missing 'mcast_addr add|remove'.
> This patch add it.
> 
> Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> ---
>  app/test-pmd/cmdline.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index a0e97719b3..3165347a05 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -516,6 +516,12 @@ static void cmd_help_long_parsed(void *parsed_result,
>  			"set allmulti (port_id|all) (on|off)\n"
>  			"    Set the allmulti mode on port_id, or all.\n\n"
>  
> +			"mcast_addr add (port_id) (mcast_addr)\n"
> +			"    Add a multicast MAC addresses on port_id.\n\n"
> +
> +			"mcast_addr remove (port_id) (mcast_addr)"

Please add '\n' at last.

with above fixed,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

> +			"    Remove a multicast MAC address from port_id.\n\n"
> +
>  			"set flow_ctrl rx (on|off) tx (on|off) (high_water)"
>  			" (low_water) (pause_time) (send_xon) mac_ctrl_frame_fwd"
>  			" (on|off) autoneg (on|off) (port_id)\n"
>
Dengdui Huang Oct. 8, 2023, 6:46 a.m. UTC | #2 
On 2023/10/8 10:47, fengchengwen wrote:
> Hi Dengdui,
> 
> On 2023/10/8 9:56, Dengdui Huang wrote:
>> Command help string is missing 'mcast_addr add|remove'.
>> This patch add it.
>>
>> Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>> ---
>>  app/test-pmd/cmdline.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index a0e97719b3..3165347a05 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -516,6 +516,12 @@ static void cmd_help_long_parsed(void *parsed_result,
>>  			"set allmulti (port_id|all) (on|off)\n"
>>  			"    Set the allmulti mode on port_id, or all.\n\n"
>>  
>> +			"mcast_addr add (port_id) (mcast_addr)\n"
>> +			"    Add a multicast MAC addresses on port_id.\n\n"
>> +
>> +			"mcast_addr remove (port_id) (mcast_addr)"
> 
> Please add '\n' at last.
> 
> with above fixed,
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> 
OK, thanks
>> +			"    Remove a multicast MAC address from port_id.\n\n"
>> +
>>  			"set flow_ctrl rx (on|off) tx (on|off) (high_water)"
>>  			" (low_water) (pause_time) (send_xon) mac_ctrl_frame_fwd"
>>  			" (on|off) autoneg (on|off) (port_id)\n"
>>
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index a0e97719b3..3165347a05 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -516,6 +516,12 @@  static void cmd_help_long_parsed(void *parsed_result,
 			"set allmulti (port_id|all) (on|off)\n"
 			"    Set the allmulti mode on port_id, or all.\n\n"
 
+			"mcast_addr add (port_id) (mcast_addr)\n"
+			"    Add a multicast MAC addresses on port_id.\n\n"
+
+			"mcast_addr remove (port_id) (mcast_addr)"
+			"    Remove a multicast MAC address from port_id.\n\n"
+
 			"set flow_ctrl rx (on|off) tx (on|off) (high_water)"
 			" (low_water) (pause_time) (send_xon) mac_ctrl_frame_fwd"
 			" (on|off) autoneg (on|off) (port_id)\n"