[v3] common/mlx5: replace use of PMD logtype
Checks
Commit Message
The goal to eliminate the generic PMD logtype.
One place it is used unnecessarily is in the mlx5 common code.
Change the one RTE_LOG() call here to use the same macro
as other log messages in same file.
Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
Cc: viacheslavo@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v3 - also address use in glue code
drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On Mon, Aug 21, 2023 at 09:16:25AM -0700, Stephen Hemminger wrote:
> The goal to eliminate the generic PMD logtype.
> One place it is used unnecessarily is in the mlx5 common code.
> Change the one RTE_LOG() call here to use the same macro
> as other log messages in same file.
>
> Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
> Cc: viacheslavo@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Hi,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, August 21, 2023 7:16 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Gregory
> Etelson <getelson@nvidia.com>
> Subject: [PATCH v3] common/mlx5: replace use of PMD logtype
>
> The goal to eliminate the generic PMD logtype.
> One place it is used unnecessarily is in the mlx5 common code.
> Change the one RTE_LOG() call here to use the same macro as other log
> messages in same file.
>
> Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query")
> Cc: viacheslavo@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v3 - also address use in glue code
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
@@ -266,7 +266,7 @@ mlx5_glue_path(char *buf, size_t size)
goto error;
return buf;
error:
- RTE_LOG(ERR, PMD, "unable to append \"-glue\" to last component of"
+ DRV_LOG(ERR, "unable to append \"-glue\" to last component of"
" RTE_EAL_PMD_PATH (\"" RTE_EAL_PMD_PATH "\"), please"
" re-configure DPDK");
return NULL;
@@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
- RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA capabilities");
+ DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
vdpa_attr->valid = 0;
} else {
vdpa_attr->valid = 1;