diff mbox series

[06/15] eal: make rte_service_lcore_may_be_active stable

Message ID 20230809164312.308093-7-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series eal: mark older API's stable |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Aug. 9, 2023, 4:42 p.m. UTC 
  This API was added in 2020.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/include/rte_service.h | 1 -
 lib/eal/version.map           | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Van Haaren, Harry Aug. 10, 2023, 9:08 a.m. UTC | #1 
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, August 9, 2023 5:43 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Subject: [PATCH 06/15] eal: make rte_service_lcore_may_be_active stable
> 
> This API was added in 2020.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

It looks like parts of the "rte_drand" patch accidentally got into the service-cores patch, with that minor update;

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip>
Below diffs to 5/15 rte_drand patch.

> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index e6d2fda95770..2e50d6857d26 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -58,6 +58,7 @@ DPDK_24 {
>  	rte_devargs_parsef;
>  	rte_devargs_remove;
>  	rte_devargs_type_count;
> +	rte_drand;
>  	rte_driver_name;
>  	rte_dump_physmem_layout;
>  	rte_dump_stack;

<snip>

> @@ -400,7 +401,6 @@ EXPERIMENTAL {
>  	rte_intr_type_set;
> 
>  	# added in 22.07
> -	rte_drand;
>  	rte_thread_get_affinity_by_id;
>  	rte_thread_get_priority;
>  	rte_thread_self;
> --
> 2.39.2
diff mbox series

Patch

diff --git a/lib/eal/include/rte_service.h b/lib/eal/include/rte_service.h
index a77f33be488c..da5e246f7abf 100644
--- a/lib/eal/include/rte_service.h
+++ b/lib/eal/include/rte_service.h
@@ -275,7 +275,6 @@  int32_t rte_service_lcore_stop(uint32_t lcore_id);
  * @retval 1 Service thread is in the service core polling loop.
  * @retval -EINVAL Invalid *lcore_id* provided.
  */
-__rte_experimental
 int32_t rte_service_lcore_may_be_active(uint32_t lcore_id);
 
 /**
diff --git a/lib/eal/version.map b/lib/eal/version.map
index e6d2fda95770..2e50d6857d26 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -58,6 +58,7 @@  DPDK_24 {
 	rte_devargs_parsef;
 	rte_devargs_remove;
 	rte_devargs_type_count;
+	rte_drand;
 	rte_driver_name;
 	rte_dump_physmem_layout;
 	rte_dump_stack;
@@ -265,6 +266,7 @@  DPDK_24 {
 	rte_service_lcore_count_services;
 	rte_service_lcore_del;
 	rte_service_lcore_list;
+	rte_service_lcore_may_be_active;
 	rte_service_lcore_reset_all;
 	rte_service_lcore_start;
 	rte_service_lcore_stop;
@@ -371,7 +373,6 @@  EXPERIMENTAL {
 	# added in 20.11
 	__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT
 	rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT
-	rte_service_lcore_may_be_active;
 	rte_vect_get_max_simd_bitwidth;
 	rte_vect_set_max_simd_bitwidth;
 
@@ -400,7 +401,6 @@  EXPERIMENTAL {
 	rte_intr_type_set;
 
 	# added in 22.07
-	rte_drand;
 	rte_thread_get_affinity_by_id;
 	rte_thread_get_priority;
 	rte_thread_self;