test/event: remove timer state check
Checks
Commit Message
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Remove checking if timer state is set to RTE_EVENT_TIMER_NOT_ARMED
after the timer has expired as certain timer device implementations
might not have access to the rte_event_timer handle of a timer event.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test/test_event_timer_adapter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Monday, July 31, 2023 8:29 AM
> To: jerinj@marvell.com; Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> Subject: [PATCH] test/event: remove timer state check
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Remove checking if timer state is set to RTE_EVENT_TIMER_NOT_ARMED
> after the timer has expired as certain timer device implementations might
> not have access to the rte_event_timer handle of a timer event.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
On Fri, Aug 4, 2023 at 9:56 PM Carrillo, Erik G
<erik.g.carrillo@intel.com> wrote:
>
> > -----Original Message-----
> > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > Sent: Monday, July 31, 2023 8:29 AM
> > To: jerinj@marvell.com; Carrillo, Erik G <erik.g.carrillo@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Subject: [PATCH] test/event: remove timer state check
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Remove checking if timer state is set to RTE_EVENT_TIMER_NOT_ARMED
> > after the timer has expired as certain timer device implementations might
> > not have access to the rte_event_timer handle of a timer event.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
@@ -1944,9 +1944,9 @@ test_timer_ticks_remaining(void)
TEST_ASSERT_EQUAL(timeout_event_dequeue(&ev, 1, WAIT_TICKS(1)), 1,
"Armed timer failed to trigger.");
- TEST_ASSERT_EQUAL(ev_tim->state, RTE_EVENT_TIMER_NOT_ARMED,
- "Improper timer state set expected %d returned %d",
- RTE_EVENT_TIMER_NOT_ARMED, ev_tim->state);
+
+ if (ev_tim->state != RTE_EVENT_TIMER_NOT_ARMED)
+ ev_tim->state = RTE_EVENT_TIMER_NOT_ARMED;
/* Test that timer that fired returns error */
TEST_ASSERT_FAIL(rte_event_timer_remaining_ticks_get(timdev, ev_tim,