diff mbox series

[v1] doc: deprecation notice to add callback data to rte_event_fp_ops

Message ID 20230717112412.13393-1-sivaprasad.tummala@amd.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] doc: deprecation notice to add callback data to rte_event_fp_ops |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-unit-testing fail Testing issues
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Sivaprasad Tummala July 17, 2023, 11:24 a.m. UTC 
  Deprecation notice to add "rte_eventdev_port_data" field to
``rte_event_fp_ops`` for callback support.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jerin Jacob July 17, 2023, 11:43 a.m. UTC | #1 
On Mon, Jul 17, 2023 at 4:54 PM Sivaprasad Tummala
<sivaprasad.tummala@amd.com> wrote:
>
> Deprecation notice to add "rte_eventdev_port_data" field to
> ``rte_event_fp_ops`` for callback support.
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index fb771a0305..057f97ce5a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -130,6 +130,13 @@ Deprecation Notices
>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>
> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> +  rte_eventdev_port_data is used to hold callbacks registered optionally
> +  per event device port and associated callback data. By adding rte_eventdev_port_data
> +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> +
>  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
>    as these are internal to DPDK library and drivers.
>
> --
> 2.34.1
>
Ferruh Yigit July 17, 2023, 12:42 p.m. UTC | #2 
On 7/17/2023 12:43 PM, Jerin Jacob wrote:
> On Mon, Jul 17, 2023 at 4:54 PM Sivaprasad Tummala
> <sivaprasad.tummala@amd.com> wrote:
>>
>> Deprecation notice to add "rte_eventdev_port_data" field to
>> ``rte_event_fp_ops`` for callback support.
>>
>> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

> 
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index fb771a0305..057f97ce5a 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -130,6 +130,13 @@ Deprecation Notices
>>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>>
>> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
>> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
>> +  rte_eventdev_port_data is used to hold callbacks registered optionally
>> +  per event device port and associated callback data. By adding rte_eventdev_port_data
>> +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
>> +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
>> +
>>  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
>>    as these are internal to DPDK library and drivers.
>>
>> --
>> 2.34.1
>>
Ferruh Yigit July 25, 2023, 8:40 a.m. UTC | #3 
On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> Deprecation notice to add "rte_eventdev_port_data" field to
> ``rte_event_fp_ops`` for callback support.
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index fb771a0305..057f97ce5a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -130,6 +130,13 @@ Deprecation Notices
>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>  
> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> +  rte_eventdev_port_data is used to hold callbacks registered optionally
> +  per event device port and associated callback data. By adding rte_eventdev_port_data
> +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> +
>  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
>    as these are internal to DPDK library and drivers.
>  

+techboard,

Request for review/ack, patch is to extend eventdev to support callbacks
per packet.
Hemant Agrawal July 25, 2023, 4:46 p.m. UTC | #4 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, July 25, 2023 2:11 PM
> To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>; dev@dpdk.org
> Cc: bruce.richardson@intel.com; david.marchand@redhat.com;
> thomas@monjalon.net; jerinjacobk@gmail.com; techboard@dpdk.org
> Subject: Re: [PATCH v1] doc: deprecation notice to add callback data to
> rte_event_fp_ops
> 
> On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > Deprecation notice to add "rte_eventdev_port_data" field to
> > ``rte_event_fp_ops`` for callback support.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index fb771a0305..057f97ce5a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -130,6 +130,13 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``,
> ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > +element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +  rte_eventdev_port_data is used to hold callbacks registered
> > +optionally
> > +  per event device port and associated callback data. By adding
> > +rte_eventdev_port_data
> > +  to rte_event_fp_ops, allows to fetch this data for fastpath
> > +eventdev inline functions
> > +  in advance. This changes the size of rte_event_fp_ops and result in ABI
> change.
> > +
> >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> >    as these are internal to DPDK library and drivers.
> >
> 
> +techboard,
> 
> Request for review/ack, patch is to extend eventdev to support callbacks per
> packet.
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Pavan Nikhilesh Bhagavatula July 25, 2023, 6:44 p.m. UTC | #5 
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@amd.com>
> > Sent: Tuesday, July 25, 2023 2:11 PM
> > To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>; dev@dpdk.org
> > Cc: bruce.richardson@intel.com; david.marchand@redhat.com;
> > thomas@monjalon.net; jerinjacobk@gmail.com; techboard@dpdk.org
> > Subject: Re: [PATCH v1] doc: deprecation notice to add callback data to
> > rte_event_fp_ops
> >
> > On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > > Deprecation notice to add "rte_eventdev_port_data" field to
> > > ``rte_event_fp_ops`` for callback support.
> > >
> > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > b/doc/guides/rel_notes/deprecation.rst
> > > index fb771a0305..057f97ce5a 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -130,6 +130,13 @@ Deprecation Notices
> > >    ``rte_cryptodev_get_auth_algo_string``,
> > ``rte_cryptodev_get_aead_algo_string`` and
> > >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> > >
> > > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > > +element
> > > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > > +  rte_eventdev_port_data is used to hold callbacks registered
> > > +optionally
> > > +  per event device port and associated callback data. By adding
> > > +rte_eventdev_port_data
> > > +  to rte_event_fp_ops, allows to fetch this data for fastpath
> > > +eventdev inline functions
> > > +  in advance. This changes the size of rte_event_fp_ops and result in ABI
> > change.
> > > +
> > >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> > >    as these are internal to DPDK library and drivers.
> > >
> >
> > +techboard,
> >
> > Request for review/ack, patch is to extend eventdev to support callbacks
> per
> > packet.
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Thomas Monjalon July 28, 2023, 3:42 p.m. UTC | #6 
25/07/2023 10:40, Ferruh Yigit:
> On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > Deprecation notice to add "rte_eventdev_port_data" field to
> > ``rte_event_fp_ops`` for callback support.
> > 
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index fb771a0305..057f97ce5a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -130,6 +130,13 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >  
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +  rte_eventdev_port_data is used to hold callbacks registered optionally
> > +  per event device port and associated callback data. By adding rte_eventdev_port_data
> > +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> > +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> > +
> >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> >    as these are internal to DPDK library and drivers.
> >  
> 
> +techboard,
> 
> Request for review/ack, patch is to extend eventdev to support callbacks
> per packet.


It does not look necessary to announce adding new fields.
The ABI compatibility breakage should be covered by this patch:
https://patches.dpdk.org/project/dpdk/patch/20230728152052.1204486-1-thomas@monjalon.net/

Marking as superseded.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fb771a0305..057f97ce5a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -130,6 +130,13 @@  Deprecation Notices
   ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
   ``rte_cryptodev_asym_get_xform_string`` respectively.
 
+* eventdev: The struct rte_event_fp_ops will be updated with a new element
+  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
+  rte_eventdev_port_data is used to hold callbacks registered optionally
+  per event device port and associated callback data. By adding rte_eventdev_port_data
+  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
+  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
+
 * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
   as these are internal to DPDK library and drivers.