diff mbox series

[v1] usertools/telemetry: fix unused parameter

Message ID 20230518134730.68538-1-samina.arshad@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series [v1] usertools/telemetry: fix unused parameter |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS

Commit Message

Samina Arshad May 18, 2023, 1:47 p.m. UTC 
  This bug fix ensures that the runtime socket path is generated
correctly, based on the user-specified file_prefix value,
resolving the issue that occurred in the previous implementation.

Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
Cc: lihuisong@huawei.com
Cc: stable@dpdk.org

Signed-off-by: Samina Arshad <samina.arshad@intel.com>
---
 usertools/dpdk-telemetry-client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anatoly Burakov May 22, 2023, 9:29 a.m. UTC | #1 
On 5/18/2023 2:47 PM, Samina Arshad wrote:
> This bug fix ensures that the runtime socket path is generated
> correctly, based on the user-specified file_prefix value,
> resolving the issue that occurred in the previous implementation.
> 
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> ---
>   usertools/dpdk-telemetry-client.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
> index d6718ca5b0..3441b6b02e 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -55,7 +55,7 @@ def getFilepath(self, file_path):
>           # Gets arguments from Command-Line and assigns to instance of client
>           self.file_path = file_path
>   
> -    def setRunpath(self, file_path):
> +    def setRunpath(self, file_prefix):
>           self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
>                                        RUNTIME_SOCKET_NAME)
>   

Does this fix anything? The path is generated from args.file_prefix 
anyway, so this change will have no effect, I think?
diff mbox series

Patch

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index d6718ca5b0..3441b6b02e 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -55,7 +55,7 @@  def getFilepath(self, file_path):
         # Gets arguments from Command-Line and assigns to instance of client
         self.file_path = file_path
 
-    def setRunpath(self, file_path):
+    def setRunpath(self, file_prefix):
         self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
                                      RUNTIME_SOCKET_NAME)