diff mbox series

[v1] net/ipn3ke: fix thread exit issue

Message ID 20230316204506.360432-1-wei.huang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v1] net/ipn3ke: fix thread exit issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance fail Performance Testing issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Wei Huang March 16, 2023, 8:45 p.m. UTC 
  Thread does not exit after driver is removed. When there is no
more representor exist, the variable 'num' will be 0 and thread
can exit safely at this time.

Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
Cc: stable@dpdk.org

Signed-off-by: Wei Huang <wei.huang@intel.com>
---
 drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xu, Rosen March 20, 2023, 6:53 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Huang, Wei <wei.huang@intel.com>
> Sent: Friday, March 17, 2023 4:45 AM
> To: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com
> Cc: stable@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Subject: [PATCH v1] net/ipn3ke: fix thread exit issue
> 
> Thread does not exit after driver is removed. When there is no more
> representor exist, the variable 'num' will be 0 and thread can exit safely at
> this time.
> 
> Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> ---
>  drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> b/drivers/net/ipn3ke/ipn3ke_representor.c
> index 2ef96a9..e50fc73 100644
> --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> @@ -2579,7 +2579,7 @@ struct rte_eth_xstat_name *xstats_names,
>  		}
>  		rte_delay_us(50 * MS);
> 
> -		if (num == 0xffffff)
> +		if (num == 0 || num == 0xffffff)
>  			return NULL;
>  	}
> 
> --
> 1.8.3.1

Acked-by: Rosen Xu <rosen.xu@intel.com>
Qi Zhang March 20, 2023, 1:01 p.m. UTC | #2 
> -----Original Message-----
> From: Xu, Rosen <rosen.xu@intel.com>
> Sent: Monday, March 20, 2023 2:54 PM
> To: Huang, Wei <wei.huang@intel.com>; dev@dpdk.org;
> thomas@monjalon.net; david.marchand@redhat.com
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v1] net/ipn3ke: fix thread exit issue
> 
> Hi,
> 
> > -----Original Message-----
> > From: Huang, Wei <wei.huang@intel.com>
> > Sent: Friday, March 17, 2023 4:45 AM
> > To: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com
> > Cc: stable@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> > <tianfei.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Huang,
> > Wei <wei.huang@intel.com>
> > Subject: [PATCH v1] net/ipn3ke: fix thread exit issue
> >
> > Thread does not exit after driver is removed. When there is no more
> > representor exist, the variable 'num' will be 0 and thread can exit
> > safely at this time.
> >
> > Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Huang <wei.huang@intel.com>
> > ---
> >  drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> > b/drivers/net/ipn3ke/ipn3ke_representor.c
> > index 2ef96a9..e50fc73 100644
> > --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> > @@ -2579,7 +2579,7 @@ struct rte_eth_xstat_name *xstats_names,
> >  		}
> >  		rte_delay_us(50 * MS);
> >
> > -		if (num == 0xffffff)
> > +		if (num == 0 || num == 0xffffff)
> >  			return NULL;
> >  	}
> >
> > --
> > 1.8.3.1
> 
> Acked-by: Rosen Xu <rosen.xu@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
index 2ef96a9..e50fc73 100644
--- a/drivers/net/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
@@ -2579,7 +2579,7 @@  struct rte_eth_xstat_name *xstats_names,
 		}
 		rte_delay_us(50 * MS);
 
-		if (num == 0xffffff)
+		if (num == 0 || num == 0xffffff)
 			return NULL;
 	}