[2/2] net/sfc: fix resetting mark in tunnel offload switch rules
Checks
Commit Message
The currently used API is unfit for the purpose as it
checks the order in which the action is being added.
Use a dedicated API to request the reset.
Fixes: 012bf708c20f ("net/sfc: support group flows in tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
drivers/net/sfc/sfc_mae.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
Comments
On 3/9/23 07:28, Ivan Malov wrote:
> The currently used API is unfit for the purpose as it
> checks the order in which the action is being added.
> Use a dedicated API to request the reset.
>
> Fixes: 012bf708c20f ("net/sfc: support group flows in tunnel offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
@@ -3896,12 +3896,10 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,
break;
case SFC_FT_RULE_SWITCH:
/*
- * Packets that go to the rule's AR have FT mark set (from the
- * TUNNEL rule OR's RECIRC_ID). Remove this mark in matching
- * packets. The user may have provided their own action
- * MARK above, so don't check the return value here.
+ * Packets that go to the rule's AR have FT mark set (from
+ * the TUNNEL rule OR's RECIRC_ID). Reset the mark to zero.
*/
- (void)efx_mae_action_set_populate_mark(ctx.spec, 0);
+ efx_mae_action_set_populate_mark_reset(ctx.spec);
ctx.ft_switch_hit_counter =
&spec_mae->ft_ctx->switch_hit_counter;