diff mbox series

[2/4] net/ark: add new device to PCIe allowlist

Message ID 20230213145824.2886910-2-shepard.siegel@atomicrules.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [1/4] doc: clarify the existing net/ark guide |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Shepard Siegel Feb. 13, 2023, 2:58 p.m. UTC 
  This patch adds the Arkville FX2 device to the PCIe allowlist.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit Feb. 13, 2023, 3:51 p.m. UTC | #1 
On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> This patch adds the Arkville FX2 device to the PCIe allowlist.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>  drivers/net/ark/ark_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index c654a229f7..b2995427c8 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> +	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
>  	{.vendor_id = 0, /* sentinel */ },
>  };
>  

It is possible to squash 2/4, 3/4 & 4/4 into single patch, I can do it
while merging.

In the patch title it mentions 'PCIe allowlist', this is not a kind of
allow list, this is list of PCI ids supported by driver, so I can update
patch title as following while merging if there won't be a new version:
"net/ark: support Arkville FX2 device"
Shepard Siegel Feb. 13, 2023, 5:12 p.m. UTC | #2 
Hi Ferruh,

If you dont mind squashing 2/4 3/4 4/4 together, that would be great.

Thank you for correcting on the allowlist, s..b "supported PCIe ids list"
instead.

best, Shep


On Mon, Feb 13, 2023 at 10:51 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> > This patch adds the Arkville FX2 device to the PCIe allowlist.
> >
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> > ---
> >  drivers/net/ark/ark_ethdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> > index c654a229f7..b2995427c8 100644
> > --- a/drivers/net/ark/ark_ethdev.c
> > +++ b/drivers/net/ark/ark_ethdev.c
> > @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> > +     {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
> >       {.vendor_id = 0, /* sentinel */ },
> >  };
> >
>
> It is possible to squash 2/4, 3/4 & 4/4 into single patch, I can do it
> while merging.
>
> In the patch title it mentions 'PCIe allowlist', this is not a kind of
> allow list, this is list of PCI ids supported by driver, so I can update
> patch title as following while merging if there won't be a new version:
> "net/ark: support Arkville FX2 device"
>
diff mbox series

Patch

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c654a229f7..b2995427c8 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -99,6 +99,7 @@  static const struct rte_pci_id pci_id_ark_map[] = {
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
+	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
 	{.vendor_id = 0, /* sentinel */ },
 };