mbox

[0/2] add ring telemetry cmds

Message ID 20230117091049.20194-1-haijie1@huawei.com (mailing list archive)
Headers

Message

Jie Hai Jan. 17, 2023, 9:10 a.m. UTC 
  This patch set supports telemetry list rings and dump info of a ring
by its name.

Jie Hai (2):
  ring: add ring list telemetry cmd
  ring: add ring info telemetry cmd

 lib/ring/meson.build |   1 +
 lib/ring/rte_ring.c  | 128 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 129 insertions(+)

Comments

Jie Hai Jan. 27, 2024, 8:33 a.m. UTC | #1 
Hi, Thomas,

Kindly ping for review.

Thanks,
Jie Hai


On 2023/11/9 18:20, Jie Hai wrote:
> This patch set supports telemetry cmd to list rings and dump information
> of a ring by its name.
> 
> v1->v2:
> 1. Add space after "switch".
> 2. Fix wrong strlen parameter.
> 
> v2->v3:
> 1. Remove prefix "rte_" for static function.
> 2. Add Acked-by Konstantin Ananyev for PATCH 1.
> 3. Introduce functions to return strings instead copy strings.
> 4. Check pointer to memzone of ring.
> 5. Remove redundant variable.
> 6. Hold lock when access ring data.
> 
> v3->v4:
> 1. Update changelog according to reviews of Honnappa Nagarahalli.
> 2. Add Reviewed-by Honnappa Nagarahalli.
> 3. Correct grammar in help information.
> 4. Correct spell warning on "te" reported by checkpatch.pl.
> 5. Use ring_walk() to query ring info instead of rte_ring_lookup().
> 6. Fix that type definition the flag field of rte_ring does not match the usage.
> 7. Use rte_tel_data_add_dict_uint_hex instead of rte_tel_data_add_dict_u64
>     for mask and flags.
> 
> v4->v5:
> 1. Add Acked-by Konstantin Ananyev and Chengwen Feng.
> 2. Add ABI change explanation for commit message of patch 1/3.
> 
> v5->v6:
> 1. Add Acked-by Morten Br?rup.
> 2. Fix incorrect reference of commit.
> 
> v6->v7:
> 1. Remove prod/consumer head/tail info.
> 
> Jie Hai (3):
>    ring: fix unmatched type definition and usage
>    ring: add telemetry cmd to list rings
>    ring: add telemetry cmd for ring info
> 
>   lib/ring/meson.build     |   1 +
>   lib/ring/rte_ring.c      | 135 +++++++++++++++++++++++++++++++++++++++
>   lib/ring/rte_ring_core.h |   2 +-
>   3 files changed, 137 insertions(+), 1 deletion(-)
>
Thomas Monjalon Feb. 19, 2024, 10:09 a.m. UTC | #2 
> Jie Hai (2):
>   ring: add telemetry cmd to list rings
>   ring: add telemetry cmd for ring info

Applied, thanks.