diff mbox series

[v2,3/7] baseband/acc: acc100 fix multiplexing multiple ops

Message ID 20230106054443.199473-4-hernan.vargas@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series baseband/acc: changes for 23.03 |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Hernan Vargas Jan. 6, 2023, 5:44 a.m. UTC 
  Function to check if multiplexing is possible for multiple operations in
one descriptor returns number of enqueued ops.

Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code")

Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
 drivers/baseband/acc/rte_acc100_pmd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Maxime Coquelin Jan. 6, 2023, 8:57 a.m. UTC | #1 
On 1/6/23 06:44, Hernan Vargas wrote:
> Function to check if multiplexing is possible for multiple operations in
> one descriptor returns number of enqueued ops.
> 
> Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code")
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index d77d3b77b5..2f65f290b5 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -3423,9 +3423,9 @@ acc100_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,
>   		}
>   		avail--;
>   		enq = RTE_MIN(left, ACC_MUX_5GDL_DESC);
> -		if (check_mux(&ops[i], enq)) {
> -			ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i],
> -					desc_idx, enq);
> +		enq = check_mux(&ops[i], enq);
> +		if (enq > 1) {
> +			ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i], desc_idx, enq);
>   			if (ret < 0) {
>   				acc_enqueue_invalid(q_data);
>   				break;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
diff mbox series

Patch

diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index d77d3b77b5..2f65f290b5 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -3423,9 +3423,9 @@  acc100_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,
 		}
 		avail--;
 		enq = RTE_MIN(left, ACC_MUX_5GDL_DESC);
-		if (check_mux(&ops[i], enq)) {
-			ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i],
-					desc_idx, enq);
+		enq = check_mux(&ops[i], enq);
+		if (enq > 1) {
+			ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i], desc_idx, enq);
 			if (ret < 0) {
 				acc_enqueue_invalid(q_data);
 				break;