[2/2] mempool: avoid usage of term ring on put
Checks
Commit Message
Term ring is misleading since it is the default, but still just
one of possible drivers to store objects.
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
lib/mempool/rte_mempool.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru]
> Sent: Sunday, 9 October 2022 13.12
>
> Term ring is misleading since it is the default, but still just
> one of possible drivers to store objects.
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
PS: The term "ring" (representing the backend) is used a few more times in the documentation parts of the file, but that's a fix for another day. :-)
On 10/9/22 16:08, Morten Brørup wrote:
>> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru]
>> Sent: Sunday, 9 October 2022 13.12
>>
>> Term ring is misleading since it is the default, but still just
>> one of possible drivers to store objects.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> ---
>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
>
> PS: The term "ring" (representing the backend) is used a few more times in the documentation parts of the file, but that's a fix for another day. :-)
>
Yes, including top level of the description how mepool
works. Unfortunately I have no enough power right now
to fix the description.
@@ -1331,7 +1331,7 @@ rte_mempool_do_generic_put(struct rte_mempool *mp, void * const *obj_table,
/* No cache provided or if put would overflow mem allocated for cache */
if (unlikely(cache == NULL || n > RTE_MEMPOOL_CACHE_MAX_SIZE))
- goto ring_enqueue;
+ goto driver_enqueue;
cache_objs = &cache->objs[cache->len];
@@ -1339,7 +1339,7 @@ rte_mempool_do_generic_put(struct rte_mempool *mp, void * const *obj_table,
* The cache follows the following algorithm
* 1. Add the objects to the cache
* 2. Anything greater than the cache min value (if it crosses the
- * cache flush threshold) is flushed to the ring.
+ * cache flush threshold) is flushed to the backend.
*/
/* Add elements back into the cache */
@@ -1355,9 +1355,9 @@ rte_mempool_do_generic_put(struct rte_mempool *mp, void * const *obj_table,
return;
-ring_enqueue:
+driver_enqueue:
- /* push remaining objects in ring */
+ /* push objects to the backend */
rte_mempool_ops_enqueue_bulk(mp, obj_table, n);
}