[v11,4/5] net/hns3: support proactive error handling mode

Message ID 20221009091009.38978-5-fengchengwen@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series support error handling mode |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

fengchengwen Oct. 9, 2022, 9:10 a.m. UTC
  This patch supports proactive error handling mode.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 drivers/net/hns3/hns3_common.c |  2 ++
 drivers/net/hns3/hns3_intr.c   | 24 ++++++++++++++++++++++++
 2 files changed, 26 insertions(+)
  

Comments

Dongdong Liu Oct. 9, 2022, 11:05 a.m. UTC | #1
On 2022/10/9 17:10, Chengwen Feng wrote:
> This patch supports proactive error handling mode.
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>

Acked-by: Dongdong Liu <liudongdong3@huawei.com>

> ---
>  drivers/net/hns3/hns3_common.c |  2 ++
>  drivers/net/hns3/hns3_intr.c   | 24 ++++++++++++++++++++++++
>  2 files changed, 26 insertions(+)
>
> diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
> index 14291193cb..7adc6a4972 100644
> --- a/drivers/net/hns3/hns3_common.c
> +++ b/drivers/net/hns3/hns3_common.c
> @@ -149,6 +149,8 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
>  		info->max_mac_addrs = HNS3_VF_UC_MACADDR_NUM;
>  	}
>
> +	info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE;
> +
>  	return 0;
>  }
>
> diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c
> index 57679254ee..44a1119415 100644
> --- a/drivers/net/hns3/hns3_intr.c
> +++ b/drivers/net/hns3/hns3_intr.c
> @@ -1480,6 +1480,27 @@ static const struct hns3_hw_err_type hns3_hw_error_type[] = {
>  	}
>  };
>
> +static void
> +hns3_report_reset_begin(struct hns3_hw *hw)
> +{
> +	struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
> +	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_ERR_RECOVERING, NULL);
> +}
> +
> +static void
> +hns3_report_reset_success(struct hns3_hw *hw)
> +{
> +	struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
> +	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_RECOVERY_SUCCESS, NULL);
> +}
> +
> +static void
> +hns3_report_reset_failed(struct hns3_hw *hw)
> +{
> +	struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
> +	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_RECOVERY_FAILED, NULL);
> +}
> +
>  static int
>  hns3_config_ncsi_hw_err_int(struct hns3_adapter *hns, bool en)
>  {
> @@ -2642,6 +2663,7 @@ hns3_reset_pre(struct hns3_adapter *hns)
>  	if (hw->reset.stage == RESET_STAGE_NONE) {
>  		__atomic_store_n(&hns->hw.reset.resetting, 1, __ATOMIC_RELAXED);
>  		hw->reset.stage = RESET_STAGE_DOWN;
> +		hns3_report_reset_begin(hw);
>  		ret = hw->reset.ops->stop_service(hns);
>  		hns3_clock_gettime(&tv);
>  		if (ret) {
> @@ -2751,6 +2773,7 @@ hns3_reset_post(struct hns3_adapter *hns)
>  			  hns3_clock_calctime_ms(&tv_delta),
>  			  tv.tv_sec, tv.tv_usec);
>  		hw->reset.level = HNS3_NONE_RESET;
> +		hns3_report_reset_success(hw);
>  	}
>  	return 0;
>
> @@ -2796,6 +2819,7 @@ hns3_reset_fail_handle(struct hns3_adapter *hns)
>  		  hns3_clock_calctime_ms(&tv_delta),
>  		  tv.tv_sec, tv.tv_usec);
>  	hw->reset.level = HNS3_NONE_RESET;
> +	hns3_report_reset_failed(hw);
>  }
>
>  /*
>
  

Patch

diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index 14291193cb..7adc6a4972 100644
--- a/drivers/net/hns3/hns3_common.c
+++ b/drivers/net/hns3/hns3_common.c
@@ -149,6 +149,8 @@  hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
 		info->max_mac_addrs = HNS3_VF_UC_MACADDR_NUM;
 	}
 
+	info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE;
+
 	return 0;
 }
 
diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c
index 57679254ee..44a1119415 100644
--- a/drivers/net/hns3/hns3_intr.c
+++ b/drivers/net/hns3/hns3_intr.c
@@ -1480,6 +1480,27 @@  static const struct hns3_hw_err_type hns3_hw_error_type[] = {
 	}
 };
 
+static void
+hns3_report_reset_begin(struct hns3_hw *hw)
+{
+	struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_ERR_RECOVERING, NULL);
+}
+
+static void
+hns3_report_reset_success(struct hns3_hw *hw)
+{
+	struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_RECOVERY_SUCCESS, NULL);
+}
+
+static void
+hns3_report_reset_failed(struct hns3_hw *hw)
+{
+	struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+	rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_RECOVERY_FAILED, NULL);
+}
+
 static int
 hns3_config_ncsi_hw_err_int(struct hns3_adapter *hns, bool en)
 {
@@ -2642,6 +2663,7 @@  hns3_reset_pre(struct hns3_adapter *hns)
 	if (hw->reset.stage == RESET_STAGE_NONE) {
 		__atomic_store_n(&hns->hw.reset.resetting, 1, __ATOMIC_RELAXED);
 		hw->reset.stage = RESET_STAGE_DOWN;
+		hns3_report_reset_begin(hw);
 		ret = hw->reset.ops->stop_service(hns);
 		hns3_clock_gettime(&tv);
 		if (ret) {
@@ -2751,6 +2773,7 @@  hns3_reset_post(struct hns3_adapter *hns)
 			  hns3_clock_calctime_ms(&tv_delta),
 			  tv.tv_sec, tv.tv_usec);
 		hw->reset.level = HNS3_NONE_RESET;
+		hns3_report_reset_success(hw);
 	}
 	return 0;
 
@@ -2796,6 +2819,7 @@  hns3_reset_fail_handle(struct hns3_adapter *hns)
 		  hns3_clock_calctime_ms(&tv_delta),
 		  tv.tv_sec, tv.tv_usec);
 	hw->reset.level = HNS3_NONE_RESET;
+	hns3_report_reset_failed(hw);
 }
 
 /*