diff mbox series

[v2] net/mlx5: fix CPU socket ID for Rx queue creation

Message ID 20220309194900.341944-1-thinhtr@linux.vnet.ibm.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v2] net/mlx5: fix CPU socket ID for Rx queue creation |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Thinh Tran March 9, 2022, 7:49 p.m. UTC 
  The default CPU socket ID was used while creating the Rx queue and this caused
creation failure in case if hardware was not resided on the default socket.

The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before
calling the mlx5_rxq_create_devx_rq_resources() which eventually calls
mlx5_devx_rq_create() with correct CPU socket ID.

v2: change patch description, no code change

Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
Cc: stable@dpdk.org


Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>

---
 drivers/net/mlx5/mlx5_devx.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Slava Ovsiienko March 10, 2022, 9:23 a.m. UTC | #1 
Hi, Thinh

the line: "v2: change patch description, no code change"
should not be in commit message body, it should be after "---"
Besides this:
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

With best regards,
Slava

> -----Original Message-----
> From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Sent: Wednesday, March 9, 2022 21:49
> To: dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Thinh Tran <thinhtr@linux.vnet.ibm.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
> 
> The default CPU socket ID was used while creating the Rx queue and this
> caused creation failure in case if hardware was not resided on the default
> socket.
> 
> The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before calling
> the mlx5_rxq_create_devx_rq_resources() which eventually calls
> mlx5_devx_rq_create() with correct CPU socket ID.
> 
> v2: change patch description, no code change
> 
> Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
> Cc: stable@dpdk.org
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
> 
> ---
>  drivers/net/mlx5/mlx5_devx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
> index af106bda50..5ab092a259 100644
> --- a/drivers/net/mlx5/mlx5_devx.c
> +++ b/drivers/net/mlx5/mlx5_devx.c
> @@ -947,6 +947,8 @@ mlx5_rxq_devx_obj_drop_create(struct rte_eth_dev
> *dev)
>  		rte_errno = ENOMEM;
>  		goto error;
>  	}
> +	/* set the CPU socket ID where the rxq_ctrl was allocated */
> +	rxq_ctrl->socket = socket_id;
>  	rxq_obj->rxq_ctrl = rxq_ctrl;
>  	rxq_ctrl->is_hairpin = false;
>  	rxq_ctrl->sh = priv->sh;
> --
> 2.27.0
Raslan Darawsheh March 10, 2022, 9:30 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Thursday, March 10, 2022 11:23 AM
> To: Thinh Tran <thinhtr@linux.vnet.ibm.com>; dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Raslan Darawsheh <rasland@nvidia.com>;
> Dmitry Kozlyuk <dkozlyuk@nvidia.com>; stable@dpdk.org
> Subject: RE: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
> 
> Hi, Thinh
> 
> the line: "v2: change patch description, no code change"
> should not be in commit message body, it should be after "---"

I'll handle this before integration, 
It's also missing the Ack from Matan from the previous version, I'll add it as well. 

> Besides this:
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 
> With best regards,
> Slava
> 
Kindest regards
Raslan Darawsheh
Raslan Darawsheh March 10, 2022, 3:38 p.m. UTC | #3 
Hi,

> -----Original Message-----
> From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Sent: Wednesday, March 9, 2022 9:49 PM
> To: dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Thinh Tran <thinhtr@linux.vnet.ibm.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
> 
> The default CPU socket ID was used while creating the Rx queue and this
> caused creation failure in case if hardware was not resided on the default
> socket.
> 
> The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before calling
> the mlx5_rxq_create_devx_rq_resources() which eventually calls
> mlx5_devx_rq_create() with correct CPU socket ID.
> 
> v2: change patch description, no code change
Removed this part,
> 
> Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
> Cc: stable@dpdk.org
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
Added missing Ack from V1 from Matan,

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
index af106bda50..5ab092a259 100644
--- a/drivers/net/mlx5/mlx5_devx.c
+++ b/drivers/net/mlx5/mlx5_devx.c
@@ -947,6 +947,8 @@  mlx5_rxq_devx_obj_drop_create(struct rte_eth_dev *dev)
 		rte_errno = ENOMEM;
 		goto error;
 	}
+	/* set the CPU socket ID where the rxq_ctrl was allocated */
+	rxq_ctrl->socket = socket_id;
 	rxq_obj->rxq_ctrl = rxq_ctrl;
 	rxq_ctrl->is_hairpin = false;
 	rxq_ctrl->sh = priv->sh;