[2/3] dma/idxd: configure max batch size to high value

Message ID 20220216160610.475242-3-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series idxd driver update fixes |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Bruce Richardson Feb. 16, 2022, 4:06 p.m. UTC
  When configuring an Intel DSA instance using the utility script
dpdk_idxd_cfg.py, explicitly set the max supported batch size value to a
high value, to ensure large bursts are supported if so desired. The
default in the linux kernel is now just 32 [1], which may not be
sufficient for all DPDK apps.

[1] https://lore.kernel.org/r/163528473483.3926048.7950067926287180976.stgit@djiang5-desk3.ch.intel.com

Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
Note: although not fixing a bug in DPDK itself, due to kernel changes
this patch should be considered for backport as a fix, so cc'ing stable.
---
 drivers/dma/idxd/dpdk_idxd_cfg.py | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Kevin Laatz Feb. 17, 2022, 5:48 p.m. UTC | #1
On 16/02/2022 16:06, Bruce Richardson wrote:
> When configuring an Intel DSA instance using the utility script
> dpdk_idxd_cfg.py, explicitly set the max supported batch size value to a
> high value, to ensure large bursts are supported if so desired. The
> default in the linux kernel is now just 32 [1], which may not be
> sufficient for all DPDK apps.
>
> [1] https://lore.kernel.org/r/163528473483.3926048.7950067926287180976.stgit@djiang5-desk3.ch.intel.com
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> Note: although not fixing a bug in DPDK itself, due to kernel changes
> this patch should be considered for backport as a fix, so cc'ing stable.
> ---
>   drivers/dma/idxd/dpdk_idxd_cfg.py | 1 +
>   1 file changed, 1 insertion(+)
>
Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
  

Patch

diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py b/drivers/dma/idxd/dpdk_idxd_cfg.py
index 34537cb980..3f5d5ee752 100755
--- a/drivers/dma/idxd/dpdk_idxd_cfg.py
+++ b/drivers/dma/idxd/dpdk_idxd_cfg.py
@@ -89,6 +89,7 @@  def configure_dsa(dsa_id, queues, prefix):
                              "mode": "dedicated",
                              "name": f"{prefix}_wq{dsa_id}.{q}",
                              "priority": 1,
+                             "max_batch_size": 1024,
                              "size": int(max_work_queues_size / nb_queues)})
 
     # enable device and then queues