[v2,6/6] app/test: add dmadev fill tests
Checks
Commit Message
From: Kevin Laatz <kevin.laatz@intel.com>
For dma devices which support the fill operation, run unit tests to
verify fill behaviour is correct.
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_dmadev.c | 73 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 73 insertions(+)
Comments
> From: Kevin Laatz <kevin.laatz@intel.com>
>
> For dma devices which support the fill operation, run unit tests to
> verify fill behaviour is correct.
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Reviewed-by: Conor Walsh <conor.walsh@intel.com>
It's probably worth noting that the new DMA IOAT drivers passes all of
these driver tests.
>
>> From: Kevin Laatz <kevin.laatz@intel.com>
>>
>> For dma devices which support the fill operation, run unit tests to
>> verify fill behaviour is correct.
>>
>> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>
> Reviewed-by: Conor Walsh <conor.walsh@intel.com>
>
On Fri, Sep 03, 2021 at 05:17:49PM +0100, Conor Walsh wrote:
>
> It's probably worth noting that the new DMA IOAT drivers passes all of these
> driver tests.
>
That's probably better called out in the cover letter of the IOAT set
itself.
@@ -710,6 +710,62 @@ test_completion_status(int dev_id, uint16_t vchan, bool fence)
return 0;
}
+static int
+test_enqueue_fill(int dev_id, uint16_t vchan)
+{
+ const unsigned int lengths[] = {8, 64, 1024, 50, 100, 89};
+ struct rte_mbuf *dst;
+ char *dst_data;
+ uint64_t pattern = 0xfedcba9876543210;
+ unsigned int i, j;
+
+ dst = rte_pktmbuf_alloc(pool);
+ if (dst == NULL) {
+ PRINT_ERR("Failed to allocate mbuf\n");
+ return -1;
+ }
+ dst_data = rte_pktmbuf_mtod(dst, char *);
+
+ for (i = 0; i < RTE_DIM(lengths); i++) {
+ /* reset dst_data */
+ memset(dst_data, 0, rte_pktmbuf_data_len(dst));
+
+ /* perform the fill operation */
+ int id = rte_dmadev_fill(dev_id, vchan, pattern,
+ rte_pktmbuf_iova(dst), lengths[i], RTE_DMA_OP_FLAG_SUBMIT);
+ if (id < 0) {
+ PRINT_ERR("Error with rte_ioat_enqueue_fill\n");
+ return -1;
+ }
+ await_hw(dev_id, vchan);
+
+ if (rte_dmadev_completed(dev_id, vchan, 1, NULL, NULL) != 1) {
+ PRINT_ERR("Error: fill operation failed (length: %u)\n", lengths[i]);
+ return -1;
+ }
+ /* check the data from the fill operation is correct */
+ for (j = 0; j < lengths[i]; j++) {
+ char pat_byte = ((char *)&pattern)[j % 8];
+ if (dst_data[j] != pat_byte) {
+ PRINT_ERR("Error with fill operation (lengths = %u): got (%x), not (%x)\n",
+ lengths[i], dst_data[j], pat_byte);
+ return -1;
+ }
+ }
+ /* check that the data after the fill operation was not written to */
+ for (; j < rte_pktmbuf_data_len(dst); j++) {
+ if (dst_data[j] != 0) {
+ PRINT_ERR("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n",
+ lengths[i], dst_data[j], 0);
+ return -1;
+ }
+ }
+ }
+
+ rte_pktmbuf_free(dst);
+ return 0;
+}
+
static int
test_dmadev_instance(uint16_t dev_id)
{
@@ -813,6 +869,23 @@ test_dmadev_instance(uint16_t dev_id)
goto err;
}
+ if ((info.dev_capa & RTE_DMADEV_CAPA_OPS_FILL) == 0)
+ printf("DMA Dev: %u, No device fill support - skipping fill tests\n", dev_id);
+ else {
+ rte_dmadev_stats_reset(dev_id, vchan);
+ printf("DMA Dev: %u, Running Fill Tests\n", dev_id);
+
+ if (test_enqueue_fill(dev_id, vchan) != 0)
+ goto err;
+
+ rte_dmadev_stats_get(dev_id, 0, &stats);
+ printf("Ops submitted: %"PRIu64"\t", stats.submitted);
+ printf("Ops completed: %"PRIu64"\t", stats.completed);
+ printf("Errors: %"PRIu64"\n", stats.errors);
+ if (check_stats(&stats, true) < 0)
+ goto err;
+ }
+
rte_mempool_free(pool);
rte_dmadev_stop(dev_id);
rte_dmadev_stats_reset(dev_id, vchan);