| Message ID | 20210723081222.4176279-1-s.v.naga.harish.k@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Jerin Jacob |
| Headers | show |
| Series | eventdev: remove event port config override in tx adapter | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/github-robot | success | github build: passed |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/intel-Testing | success | Testing PASS |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-testing | success | Testing PASS |
> -----Original Message----- > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > Sent: Friday, July 23, 2021 1:42 PM > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com > Cc: dev@dpdk.org > Subject: [PATCH] eventdev: remove event port config override in tx adapter > > The event port config set by application is modified in > default configuration callback function. This patch removes > this override and use application configured event port > config value. > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > --- > lib/eventdev/rte_event_eth_tx_adapter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c > index db260bfb68..18c0359db7 100644 > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, > return ret; > } > > - pc->event_port_cfg = 0; > ret = rte_event_port_setup(dev_id, port_id, pc); > if (ret) { > RTE_EDEV_LOG_ERR("failed to setup event port %u\n", > -- > 2.25.1 Looks good to me. Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
On Fri, Jul 23, 2021 at 1:42 PM Naga Harish K, S V <s.v.naga.harish.k@intel.com> wrote: > > The event port config set by application is modified in > default configuration callback function. This patch removes > this override and use application configured event port > config value. Is this enhancement or bug fix? If it is a bug fix, please add Fixes: and update the git subject. We will take it in RC3. > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > --- > lib/eventdev/rte_event_eth_tx_adapter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c > index db260bfb68..18c0359db7 100644 > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, > return ret; > } > > - pc->event_port_cfg = 0; > ret = rte_event_port_setup(dev_id, port_id, pc); > if (ret) { > RTE_EDEV_LOG_ERR("failed to setup event port %u\n", > -- > 2.25.1 >
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index db260bfb68..18c0359db7 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, return ret; } - pc->event_port_cfg = 0; ret = rte_event_port_setup(dev_id, port_id, pc); if (ret) { RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
The event port config set by application is modified in default configuration callback function. This patch removes this override and use application configured event port config value. Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com> --- lib/eventdev/rte_event_eth_tx_adapter.c | 1 - 1 file changed, 1 deletion(-)