diff mbox series

[2/2] qede: make driver accept bigger rss tables

Message ID 20210221111637.31193-3-irusskikh@marvell.com (mailing list archive)
State New
Delegated to: Jerin Jacob
Headers show
Series qede: 2020-02 minor fixes | expand


Context Check Description
ci/iol-abi-testing warning Testing issues
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

Igor Russkikh Feb. 21, 2021, 11:16 a.m. UTC
We found some dpdk applications blindly pass fixed side rss hash tables,
and do not check driver/device capabilities.

Moreover, many other drivers do not do such a strong check as well.

So here we fix it, making qede accept any size rss_key. For larger key
tables we just crop it with notice trace message.

CC: stable@dpdk.org
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
 drivers/net/qede/qede_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b106..7363d98f2 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2139,8 +2139,8 @@  int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
 		/* RSS hash key */
 		if (key) {
 			if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {
-				DP_ERR(edev, "RSS key length exceeds limit\n");
-				return -EINVAL;
+				len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
+				DP_NOTICE(edev, false, "RSS key length exceeds limit\n");
 			DP_INFO(edev, "Applying user supplied hash key\n");
 			rss_params.update_rss_key = 1;