| Message ID | 20210128051653.20503-1-adwivedi@marvell.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | akhil goyal |
| Headers | show |
| Series | [v2] crypto/octeontx2: fix null pointer dereferences | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-testing | fail | Testing issues |
| ci/iol-testing | fail | Testing issues |
| ci/iol-testing | fail | Testing issues |
| ci/iol-testing | fail | Testing issues |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/Intel-compilation | fail | Compilation issues |
| ci/checkpatch | success | coding style OK |
> Coverity reports that pointers ip and ip6 may be dereferenced > with null value. This patch fixes this. > > Coverity issue: 365549 > Coverity issue: 365551 > > Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") > > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> > --- > v2: > * Fixed wrong fixes reference in commit message. Applied to dpdk-next-crypto Thanks.
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c index 89ed7cbd2..342f089df 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c +++ b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c @@ -208,10 +208,10 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev, struct otx2_ipsec_po_sa_ctl *ctl; int cipher_key_len, auth_key_len; struct otx2_ipsec_po_out_sa *sa; - struct rte_ipv6_hdr *ip6 = NULL; - struct rte_ipv4_hdr *ip = NULL; struct otx2_sec_session *sess; struct otx2_cpt_inst_s inst; + struct rte_ipv6_hdr *ip6; + struct rte_ipv4_hdr *ip; int ret, ctx_len; sess = get_sec_session_private_data(sec_sess); @@ -282,6 +282,8 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev, sa->sha2.template.ip4); ctx_len = RTE_ALIGN_CEIL(ctx_len, 8); lp->ctx_len = ctx_len >> 3; + } else { + return -EINVAL; } ip->version_ihl = RTE_IPV4_VHL_DEF; ip->next_proto_id = IPPROTO_ESP; @@ -331,6 +333,8 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev, sa->sha2.template.ip6); ctx_len = RTE_ALIGN_CEIL(ctx_len, 8); lp->ctx_len = ctx_len >> 3; + } else { + return -EINVAL; } ip6->vtc_flow = rte_cpu_to_be_32(0x60000000 |
Coverity reports that pointers ip and ip6 may be dereferenced with null value. This patch fixes this. Coverity issue: 365549 Coverity issue: 365551 Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com> --- v2: * Fixed wrong fixes reference in commit message. drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)