| Message ID | 20210127173330.1671341-4-bruce.richardson@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Marchand |
| Headers | show |
| Series | add checking of header includes | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
On Wed, Jan 27, 2021 at 6:33 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > The rte_rib6 header was using RTE_MIN macro from rte_common.h but not > including the header file. > > Fixes: f7e861e21c46 ("rib: support IPv6") > Cc: vladimir.medvedkin@intel.com Cc: stable@dpdk.org Or was it intentionally skipped?
On Thu, Jan 28, 2021 at 12:01:02PM +0100, David Marchand wrote: > On Wed, Jan 27, 2021 at 6:33 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > The rte_rib6 header was using RTE_MIN macro from rte_common.h but not > > including the header file. > > > > Fixes: f7e861e21c46 ("rib: support IPv6") > > Cc: vladimir.medvedkin@intel.com > > Cc: stable@dpdk.org > Or was it intentionally skipped? > Nope, just a miss on my part. Apologies.
diff --git a/lib/librte_rib/rte_rib6.h b/lib/librte_rib/rte_rib6.h index b5e10569b9..dbd52928a2 100644 --- a/lib/librte_rib/rte_rib6.h +++ b/lib/librte_rib/rte_rib6.h @@ -20,6 +20,7 @@ #include <rte_memcpy.h> #include <rte_compat.h> +#include <rte_common.h> #ifdef __cplusplus extern "C" {
The rte_rib6 header was using RTE_MIN macro from rte_common.h but not including the header file. Fixes: f7e861e21c46 ("rib: support IPv6") Cc: vladimir.medvedkin@intel.com Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- lib/librte_rib/rte_rib6.h | 1 + 1 file changed, 1 insertion(+)