| Message ID | 20201202181959.13753-1-drc@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | [1/1] usertools: show hugepages on POWER systems | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-testing | success | Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/travis-robot | success | Travis build: passed |
| ci/checkpatch | success | coding style OK |
On Wed, 2 Dec 2020 10:19:59 -0800 David Christensen <drc@linux.vnet.ibm.com> wrote: > The IBM PowerNV systems include NUMA nodes that don't have associated > CPUs or hugepage memory. Here is an example on an IBM AC922 system: > > $ lscpu > ... > NUMA node0 CPU(s): 0-63 > NUMA node8 CPU(s): 64-127 > NUMA node252 CPU(s): > ... > > $ numastat -m > ... > Node 0 Node 8 Node 252 > --------------- --------------- --------------- > MemTotal 126763.19 130785.06 0.00 > MemFree 119513.38 125294.44 0.00 > MemUsed 7249.81 5490.62 0.00 > ... > HugePages_Total 4.00 1734.00 0.00 > HugePages_Free 0.00 4.00 0.00 > HugePages_Surp 4.00 1730.00 0.00 > ... > > Modify dpdk-hugepages.py to test for the ../hugepages directory before > attempting to parse the hugepage entries. > > Signed-off-by: David Christensen <drc@linux.vnet.ibm.com> Ok, but using continue avoids having to do so much indentation. if not os.path.exists(path): continue
diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk-hugepages.py index 1be100ca3..89945f187 100755 --- a/usertools/dpdk-hugepages.py +++ b/usertools/dpdk-hugepages.py @@ -70,13 +70,14 @@ def show_numa_pages(): for numa_path in glob.glob('/sys/devices/system/node/node*'): node = numa_path[29:] # slice after /sys/devices/system/node/node path = numa_path + '/hugepages' - for hdir in os.listdir(path): - pages = get_hugepages(path + '/' + hdir) - if pages > 0: - kb = int(hdir[10:-2]) # slice out of hugepages-NNNkB - print('{:<4} {:<5} {:<6} {}'.format(node, pages, - fmt_memsize(kb), - fmt_memsize(pages * kb))) + if os.path.exists(path): + for hdir in os.listdir(path): + pages = get_hugepages(path + '/' + hdir) + if pages > 0: + kb = int(hdir[10:-2]) # slice out of hugepages-NNNkB + print('{:<4} {:<5} {:<6} {}'.format(node, pages, + fmt_memsize(kb), + fmt_memsize(pages * kb))) def show_non_numa_pages():
The IBM PowerNV systems include NUMA nodes that don't have associated CPUs or hugepage memory. Here is an example on an IBM AC922 system: $ lscpu ... NUMA node0 CPU(s): 0-63 NUMA node8 CPU(s): 64-127 NUMA node252 CPU(s): ... $ numastat -m ... Node 0 Node 8 Node 252 --------------- --------------- --------------- MemTotal 126763.19 130785.06 0.00 MemFree 119513.38 125294.44 0.00 MemUsed 7249.81 5490.62 0.00 ... HugePages_Total 4.00 1734.00 0.00 HugePages_Free 0.00 4.00 0.00 HugePages_Surp 4.00 1730.00 0.00 ... Modify dpdk-hugepages.py to test for the ../hugepages directory before attempting to parse the hugepage entries. Signed-off-by: David Christensen <drc@linux.vnet.ibm.com> --- usertools/dpdk-hugepages.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)