[v3,4/5] net/i40e: enable flow query RSS
Checks
Commit Message
This patch enables flow query function to get the
configuration of the specified rule.
Signed-off-by: Chenxu Di <chenxux.di@intel.com>
---
doc/guides/rel_notes/release_20_08.rst | 1 +
drivers/net/i40e/i40e_flow.c | 49 ++++++++++++++++++++++++++
2 files changed, 50 insertions(+)
Comments
On 7/1/2020 4:24 PM, Chenxu Di wrote:
> This patch enables flow query function to get the
> configuration of the specified rule.
>
> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> ---
> doc/guides/rel_notes/release_20_08.rst | 1 +
> drivers/net/i40e/i40e_flow.c | 49 ++++++++++++++++++++++++++
> 2 files changed, 50 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
> index 1252a337a..a7fb3136d 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -90,6 +90,7 @@ New Features
>
> * Re-implemented get_fdir_info and get_fdir_stat in private API.
> * Re-implemented set_gre_key_len in private API.
> + * Added support for flow query RSS.
>
> * **Updated the Intel ixgbe driver.**
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 8f8df6fae..4186a5df2 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -43,6 +43,10 @@ static int i40e_flow_destroy(struct rte_eth_dev *dev,
> struct rte_flow_error *error);
> static int i40e_flow_flush(struct rte_eth_dev *dev,
> struct rte_flow_error *error);
> +static int i40e_flow_query(struct rte_eth_dev *dev,
> + struct rte_flow *flow,
> + const struct rte_flow_action *actions,
> + void *data, struct rte_flow_error *error);
> static int
> i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
> const struct rte_flow_item *pattern,
> @@ -129,6 +133,7 @@ const struct rte_flow_ops i40e_flow_ops = {
> .create = i40e_flow_create,
> .destroy = i40e_flow_destroy,
> .flush = i40e_flow_flush,
> + .query = i40e_flow_query,
> };
>
> static union i40e_filter_t cons_filter;
> @@ -5462,3 +5467,47 @@ i40e_flow_flush_rss_filter(struct rte_eth_dev *dev)
>
> return ret;
> }
> +
> +static int
> +i40e_flow_query(struct rte_eth_dev *dev __rte_unused,
> + struct rte_flow *flow,
> + const struct rte_flow_action *actions,
> + void *data, struct rte_flow_error *error)
> +{
> + struct i40e_rss_filter *rss_rule = (struct i40e_rss_filter *)flow->rule;
> + enum rte_filter_type filter_type = flow->filter_type;
> + struct rte_flow_action_rss *rss_conf = data;
> +
> + if (!rss_rule) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_HANDLE,
> + NULL, "Invalid rule");
> + return -rte_errno;
> + }
> +
> + for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
> + switch (actions->type) {
> + case RTE_FLOW_ACTION_TYPE_VOID:
> + break;
> + case RTE_FLOW_ACTION_TYPE_RSS:
> + if (filter_type != RTE_ETH_FILTER_HASH) {
> + rte_flow_error_set(error, ENOTSUP,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + actions,
> + "action not supported");
> + return -rte_errno;
> + }
> + rte_memcpy(rss_conf,
> + &rss_rule->rss_filter_info.conf,
> + sizeof(struct rte_flow_action_rss));
> + break;
> + default:
> + return rte_flow_error_set(error, ENOTSUP,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + actions,
> + "action not supported");
> + }
> + }
> +
> + return 0;
> +}
Acked-by: Jeff Guo <jia.guo@intel.com <mailto:jia.guo@intel.com>>
@@ -90,6 +90,7 @@ New Features
* Re-implemented get_fdir_info and get_fdir_stat in private API.
* Re-implemented set_gre_key_len in private API.
+ * Added support for flow query RSS.
* **Updated the Intel ixgbe driver.**
@@ -43,6 +43,10 @@ static int i40e_flow_destroy(struct rte_eth_dev *dev,
struct rte_flow_error *error);
static int i40e_flow_flush(struct rte_eth_dev *dev,
struct rte_flow_error *error);
+static int i40e_flow_query(struct rte_eth_dev *dev,
+ struct rte_flow *flow,
+ const struct rte_flow_action *actions,
+ void *data, struct rte_flow_error *error);
static int
i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
const struct rte_flow_item *pattern,
@@ -129,6 +133,7 @@ const struct rte_flow_ops i40e_flow_ops = {
.create = i40e_flow_create,
.destroy = i40e_flow_destroy,
.flush = i40e_flow_flush,
+ .query = i40e_flow_query,
};
static union i40e_filter_t cons_filter;
@@ -5462,3 +5467,47 @@ i40e_flow_flush_rss_filter(struct rte_eth_dev *dev)
return ret;
}
+
+static int
+i40e_flow_query(struct rte_eth_dev *dev __rte_unused,
+ struct rte_flow *flow,
+ const struct rte_flow_action *actions,
+ void *data, struct rte_flow_error *error)
+{
+ struct i40e_rss_filter *rss_rule = (struct i40e_rss_filter *)flow->rule;
+ enum rte_filter_type filter_type = flow->filter_type;
+ struct rte_flow_action_rss *rss_conf = data;
+
+ if (!rss_rule) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_HANDLE,
+ NULL, "Invalid rule");
+ return -rte_errno;
+ }
+
+ for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
+ switch (actions->type) {
+ case RTE_FLOW_ACTION_TYPE_VOID:
+ break;
+ case RTE_FLOW_ACTION_TYPE_RSS:
+ if (filter_type != RTE_ETH_FILTER_HASH) {
+ rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ actions,
+ "action not supported");
+ return -rte_errno;
+ }
+ rte_memcpy(rss_conf,
+ &rss_rule->rss_filter_info.conf,
+ sizeof(struct rte_flow_action_rss));
+ break;
+ default:
+ return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ actions,
+ "action not supported");
+ }
+ }
+
+ return 0;
+}